Performance: Causal profile results #92843

New Issue

Jeroen Bakker · 2021-11-05T08:25:10+01:00

Jeroen Bakker commented

2021-11-05 08:25:10 +01:00

Came up when profiling sprite fright scenes with the causal profiler.

sprite_fright/pro/shots/030_village/030_0140_A/030_0140_A.anim.blend
https://drive.google.com/file/d/1Kss6SQHK131rQpnUG8YqMOKHhma5E9F_/view?usp=sharing
File can be loaded at https://plasma-umass.org/coz/
BKE_pose_channel_free_bbone_cache: The 4 allocations could be reduced to a single. They are allocated, calculated and freed at the same together. We could even reuse the previous allocation.
extract_pos_nor_iter_poly_mesh: move mp->flag+MR_EXTRACT_MAPPED to an outer loop. mapped could also be a different function? Although I think that the issue with this function is data locality. Check ordering of ml_index, ml->v. Should we combine data->normals with mv->pos.
BLI_noise_voronoi: migrate to CPP use templates to reduce unneeded branches. In core we only use squared distance. BPY/texture can use other as well. Check implementation cycles and eevee uses as well
BLI_kdopbvh?

Came up when profiling sprite fright scenes with the causal profiler. * `sprite_fright/pro/shots/030_village/030_0140_A/030_0140_A.anim.blend` * https://drive.google.com/file/d/1Kss6SQHK131rQpnUG8YqMOKHhma5E9F_/view?usp=sharing File can be loaded at https://plasma-umass.org/coz/ * `BKE_pose_channel_free_bbone_cache`: The 4 allocations could be reduced to a single. They are allocated, calculated and freed at the same together. We could even reuse the previous allocation. * `extract_pos_nor_iter_poly_mesh`: move mp->flag+MR_EXTRACT_MAPPED to an outer loop. mapped could also be a different function? Although I think that the issue with this function is data locality. Check ordering of ml_index, ml->v. Should we combine `data->normals` with `mv->pos`. * `BLI_noise_voronoi`: migrate to CPP use templates to reduce unneeded branches. In core we only use squared distance. BPY/texture can use other as well. Check implementation cycles and eevee uses as well * `BLI_kdopbvh`?

Jeroen Bakker self-assigned this 2021-11-05 08:25:10 +01:00

Jeroen Bakker commented

2021-11-05 08:25:10 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2021-11-05 08:25:10 +01:00

Added subscriber: @Jeroen-Bakker

Hans Goudey commented

2021-11-05 17:31:37 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2021-11-05 17:31:37 +01:00

For voronoi, the Cycles and EEVEE implementations have been ported to BLI_noise.hh. Maybe it would be nice to use the same implementation everywhere.

For voronoi, the Cycles and EEVEE implementations have been ported to `BLI_noise.hh`. Maybe it would be nice to use the same implementation everywhere.

Chris Kohl commented

2022-01-24 05:47:30 +01:00

Added subscriber: @ckohl_art

Brecht Van Lommel commented

2022-02-28 17:35:30 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2022-02-28 17:35:30 +01:00

Moving to next release since it's too late in 3.1, though not sure this should be tagged with any release unless you specifically plan to work on this within a given timeframe.

Jeroen Bakker removed their assignment 2022-03-02 17:15:14 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Performance: Causal profile results #92843