Crash when creating a new object #93250

New Issue

Erik Abrahamsson · 2021-11-20T23:23:22+01:00

Erik Abrahamsson commented

2021-11-20 23:23:22 +01:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.47

Blender Version
Broken: version: 3.1.0 Alpha, branch: master
Caused by 01df48a983

Short description of error
Crash when a new object is created with a spreadsheet view visible.

Exact steps for others to reproduce the error

Open Blender
Delete default Cube
Go to the Geometry Nodes workspace
Create a new object in the 3d view

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.47 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master Caused by 01df48a983 **Short description of error** Crash when a new object is created with a spreadsheet view visible. **Exact steps for others to reproduce the error** - Open Blender - Delete default Cube - Go to the Geometry Nodes workspace - Create a new object in the 3d view

Erik Abrahamsson commented

2021-11-20 23:23:22 +01:00

Added subscriber: @erik85

blender-admin commented

2021-11-20 23:23:22 +01:00

#93260 was marked as duplicate of this issue

Pratik Borhade commented

2021-11-21 10:33:09 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2021-11-21 10:33:13 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-11-21 11:09:53 +01:00

Added subscriber: @HooglyBoogly

Pratik Borhade commented

2021-11-21 11:09:53 +01:00

Yes, caused by 01df48a983

cc @HooglyBoogly

Yes, caused by 01df48a983 cc @HooglyBoogly

Pratik Borhade commented

2021-11-21 11:13:08 +01:00

Added subscriber: @tiles

Jacques Lucke commented

2021-11-21 11:25:38 +01:00

Added subscribers: @JulianEisel, @JacquesLucke

Jacques Lucke commented

2021-11-21 11:25:38 +01:00

May also need some feedback from @severin.

Hans Goudey commented

2021-11-21 17:23:10 +01:00

It seems the tree view code assumes there is always an old tree view around to retrieve the state from. That makes sense for the asset browser where it has been used so far, but I don't think it makes sense for the spreadsheet:

This is how I would expect to fix the issue:

diff --git a/source/blender/editors/interface/tree_view.cc b/source/blender/editors/interface/tree_view.cc
index e9d68a734d2..5fcf78dd565 100644
--- a/source/blender/editors/interface/tree_view.cc
+++ b/source/blender/editors/interface/tree_view.cc
@@ -111,7 +111,10 @@ void AbstractTreeView::update_from_old(uiBlock &new_block)
 
   uiTreeViewHandle *old_view_handle = ui_block_view_find_matching_in_old_block(
       &new_block, reinterpret_cast<uiTreeViewHandle *>(this));
-  BLI_assert(old_view_handle);
+  if (old_view_handle == nullptr) {
+    is_reconstructed_ = true;
+    return;
+  }
 
   AbstractTreeView &old_view = reinterpret_cast<AbstractTreeView &>(*old_view_handle);

However, the issue is also fixed by adding a poll function to the panel to make sure the old uiBlock never existed in the first place (which also makes the reconstruction not run, just in a different way).

I don't think the data set region panel should require a poll function necessarily, so I'll submit the above as a patch.

It seems the tree view code assumes there is always an old tree view around to retrieve the state from. That makes sense for the asset browser where it has been used so far, but I don't think it makes sense for the spreadsheet: This is how I would expect to fix the issue: ``` diff --git a/source/blender/editors/interface/tree_view.cc b/source/blender/editors/interface/tree_view.cc index e9d68a734d2..5fcf78dd565 100644 --- a/source/blender/editors/interface/tree_view.cc +++ b/source/blender/editors/interface/tree_view.cc @@ -111,7 +111,10 @@ void AbstractTreeView::update_from_old(uiBlock &new_block) uiTreeViewHandle *old_view_handle = ui_block_view_find_matching_in_old_block( &new_block, reinterpret_cast<uiTreeViewHandle *>(this)); - BLI_assert(old_view_handle); + if (old_view_handle == nullptr) { + is_reconstructed_ = true; + return; + } AbstractTreeView &old_view = reinterpret_cast<AbstractTreeView &>(*old_view_handle); ``` However, the issue is also fixed by adding a poll function to the panel to make sure the old `uiBlock` never existed in the first place (which also makes the reconstruction not run, just in a different way). I don't think the data set region panel should require a poll function necessarily, so I'll submit the above as a patch.

blender-admin commented

2021-11-22 14:47:02 +01:00

This issue was referenced by 77ddc6e350

This issue was referenced by 77ddc6e3500e4d736195202438df50190be85e5a

Hans Goudey commented

2021-11-22 14:47:34 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2021-11-22 14:47:34 +01:00

Hans Goudey self-assigned this 2021-11-22 14:47:34 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when creating a new object #93250