Can't input '. ' in Transform input box (when using IME) #93626

New Issue

czf · 2021-12-04T04:53:27+01:00

czf commented

2021-12-04 04:53:27 +01:00

System Information
Operating system Win 10:
Graphics card:

Blender Version

version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: f1cca30557, type: release
build date: 2021-12-02, 18:49:35
platform: 'Windows-10-10.0.19041-SP0'

Short description of error
I want to modify object's scale, and want to input scale value "0.001" but I can't input '.' in the input box

Exact steps for others to reproduce the error
open blender. select anything,then do modify operation ,see attached image.
![9B%8N`CZOWZJ]NS6GVXWVGY.png](https://archive.blender.org/developer/F12688210/9B_8N_CZOWZJ_NS6GVXWVGY.png)

**System Information** Operating system Win 10: Graphics card: **Blender Version** version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: f1cca3055776, type: release build date: 2021-12-02, 18:49:35 platform: 'Windows-10-10.0.19041-SP0' **Short description of error** I want to modify object's scale, and want to input scale value "0.001" but I can't input '.' in the input box **Exact steps for others to reproduce the error** open blender. select anything,then do modify operation ,see attached image. ![9B%8N`CZOWZJ]NS6GVXWVGY.png](https://archive.blender.org/developer/F12688210/9B_8N_CZOWZJ_NS6GVXWVGY.png)

czf commented

2021-12-04 04:53:27 +01:00

Added subscriber: @maskerman

Jesse Yurkovich commented

2021-12-04 10:52:36 +01:00

Added subscriber: @deadpin

Jesse Yurkovich commented

2021-12-04 10:52:36 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Jesse Yurkovich commented

2021-12-04 10:52:36 +01:00

I'm not able to reproduce the problem here. Does this still occur if you try to do the following: File -> Defaults -> Load Factory Settings? Are you using a particular language or keyboard layout?

czf commented

2021-12-06 04:40:47 +01:00

It seems IME will make things worse. If use english layout, It seems OK .

Jesse Yurkovich changed title from ~~Can't input '. ' in Transform input box.~~ to Can't input '. ' in Transform input box (when using IME)

2021-12-06 10:26:43 +01:00

Jesse Yurkovich commented

2021-12-06 10:26:43 +01:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Yuki Hashimoto commented

2021-12-07 05:22:45 +01:00

Added subscribers: @sntulix, @hzuika

Yuki Hashimoto commented

2021-12-07 05:22:45 +01:00

If you add information about the type of IME (Microsoft IME?, Google IME?) and the language (Chinese? Japanese? Korean?), it will be easier to reproduce the problem.

@sntulix Do you know the cause of that bug?

If you add information about the type of IME (Microsoft IME?, Google IME?) and the language (Chinese? Japanese? Korean?), it will be easier to reproduce the problem. @sntulix Do you know the cause of that bug?

Takahiro Shizuki commented

2021-12-07 05:48:05 +01:00

Hi. @hzuika

I don’t know it yet.

By the way, I will do a task (https://developer.blender.org/T93421#1264170).
It’s approach may be not conflict with here, but I tell it as FYI.

Hi. @hzuika I don’t know it yet. By the way, I will do a task (https://developer.blender.org/T93421#1264170). It’s approach may be not conflict with here, but I tell it as FYI.

lictex_ commented

2021-12-07 06:54:01 +01:00

Added subscriber: @lictex_1

Takahiro Shizuki commented

2021-12-07 07:28:16 +01:00

I reproduce this with Microsoft Chinese IME, maybe.

Takahiro Shizuki commented

2021-12-07 07:58:15 +01:00

a reproducing capture by ffmpeg. (ffmpeg.exe -offset_x 1360 -offset_y 0 -video_size 1200x1600 -framerate 30 -f gdigrab -i desktop -vcodec libx264 -pix_fmt yuv420p desktop.mp4)

desktop.mp4

"." key's define in windows: code 190, 0xBE, VK_OEM_PERIOD "." key [.>]

a reproducing capture by ffmpeg. (ffmpeg.exe -offset_x 1360 -offset_y 0 -video_size 1200x1600 -framerate 30 -f gdigrab -i desktop -vcodec libx264 -pix_fmt yuv420p desktop.mp4) [desktop.mp4](https://archive.blender.org/developer/F12703086/desktop.mp4) "." key's define in windows: code 190, 0xBE, VK_OEM_PERIOD "." key [.>]

炎臻 commented

2021-12-11 09:11:24 +01:00

Added subscriber: @PrettyFireNOI7

Takahiro Shizuki commented

2022-01-08 07:40:30 +01:00

Hi.

I am checking this.

About {key .} key code in Microsoft IME Pinyin.

Case when inputting {key .} key,

This has START, END of COMPOSITION event.
This has no problem.

Case when inputting {key 0} {key .} {key 0} keys,

This has no COMPOSITION event.
This is expected to be "0.0", but "00".

Shoud I do modify the function of handling Chinese letters at GHOST_ImeWin32::IsImeKeyEvent() like below?

diff --git a/intern/ghost/intern/GHOST_ImeWin32.cpp b/intern/ghost/intern/GHOST_ImeWin32.cpp
index d1fc80adf56..78c441ceb28 100644
--- a/intern/ghost/intern/GHOST_ImeWin32.cpp
+++ b/intern/ghost/intern/GHOST_ImeWin32.cpp
@@ -98,24 +98,34 @@ bool GHOST_ImeWin32::IsEnglishMode()

 bool GHOST_ImeWin32::IsImeKeyEvent(char ascii)
 {
   if (!(IsEnglishMode())) {
     /* In Chinese, Japanese, Korean, all alpha keys are processed by IME. */
     if ((ascii >= 'A' && ascii <= 'Z') || (ascii >= 'a' && ascii <= 'z')) {
       return true;
     }
     if (IsLanguage(IMELANG_JAPANESE) && (ascii >= ' ' && ascii <= '~')) {
       return true;
     }
     else if (IsLanguage(IMELANG_CHINESE) && ascii && strchr("!\"$'(),.:;<>?[\\]^_`/", ascii)) {
+      switch (ascii) {
+        case '.':
+        /*
+        * check if IME is not in COMPOSITION by some way.
+        */
+        return false; /* This makes key handling with GHOST and print '.' letter. */
+
+        default:
+          break;
+      }
       return true;
     }
   }
   return false;
 }

Hi. I am checking this. About {key .} key code in Microsoft IME Pinyin. Case when inputting {key .} key, ![InkedT93626-input-'.'_key_LI.jpg](https://archive.blender.org/developer/F12793949/InkedT93626-input-_.__key_LI.jpg) - This has START, END of COMPOSITION event. - This has no problem. Case when inputting {key 0} {key .} {key 0} keys, ![#93626-input-'0.0'_key.PNG](https://archive.blender.org/developer/F12793951/T93626-input-_0.0__key.PNG) - This has no COMPOSITION event. - This is expected to be "0.0", but "00". Shoud I do modify the function of handling Chinese letters at GHOST_ImeWin32::IsImeKeyEvent() like below? ``` diff --git a/intern/ghost/intern/GHOST_ImeWin32.cpp b/intern/ghost/intern/GHOST_ImeWin32.cpp index d1fc80adf56..78c441ceb28 100644 --- a/intern/ghost/intern/GHOST_ImeWin32.cpp +++ b/intern/ghost/intern/GHOST_ImeWin32.cpp @@ -98,24 +98,34 @@ bool GHOST_ImeWin32::IsEnglishMode() bool GHOST_ImeWin32::IsImeKeyEvent(char ascii) { if (!(IsEnglishMode())) { /* In Chinese, Japanese, Korean, all alpha keys are processed by IME. */ if ((ascii >= 'A' && ascii <= 'Z') || (ascii >= 'a' && ascii <= 'z')) { return true; } if (IsLanguage(IMELANG_JAPANESE) && (ascii >= ' ' && ascii <= '~')) { return true; } else if (IsLanguage(IMELANG_CHINESE) && ascii && strchr("!\"$'(),.:;<>?[\\]^_`/", ascii)) { + switch (ascii) { + case '.': + /* + * check if IME is not in COMPOSITION by some way. + */ + return false; /* This makes key handling with GHOST and print '.' letter. */ + + default: + break; + } return true; } } return false; } ```

Germano Cavalcante commented

2022-01-11 15:28:48 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-01-11 15:28:48 +01:00

@sntulix, it takes someone with experience in this to review the suggested change (if you're sure it's safe, i think we can skip the review).
I suggest creating a patch through https:*developer.blender.org/differential/diff/create/ and contacting one of the developers who worked in the area (Eg. https:*developer.blender.org/diffusion/B/history/master/intern/ghost/intern/GHOST_ImeWin32.cpp).

@sntulix, it takes someone with experience in this to review the suggested change (if you're sure it's safe, i think we can skip the review). I suggest creating a patch through https:*developer.blender.org/differential/diff/create/ and contacting one of the developers who worked in the area (Eg. https:*developer.blender.org/diffusion/B/history/master/intern/ghost/intern/GHOST_ImeWin32.cpp).

Harley Acheson commented

2022-01-11 15:59:02 +01:00

Added subscriber: @Harley

Harley Acheson commented

2022-01-11 15:59:02 +01:00

This is just a wild guess, but is it possible that this IME is converting the keypress of the period key to Chinese full stop (U+3002 ideographic full stop)? This is a period that is the same width as other characters. If this is the case we could probably treat that as a regular decimal in the numeric input code.

Edit - No. But it is a little odd

When in English I get both a KM_PRESS and KM_RELEASE of EVT_PADPERIOD. But in Chinese I am seeing only KM_RELEASE of EVT_PADPERIOD and not the KM_PRESS we act on.

This is just a wild guess, but is it possible that this IME is converting the keypress of the period key to Chinese full stop (U+3002 ideographic full stop)? This is a period that is the same width as other characters. If this is the case we could probably treat that as a regular decimal in the numeric input code. Edit - No. But it is a little odd When in English I get both a KM_PRESS and KM_RELEASE of EVT_PADPERIOD. But in Chinese I am seeing only KM_RELEASE of EVT_PADPERIOD and not the KM_PRESS we act on.

Harley Acheson commented

2022-01-11 17:20:11 +01:00

@sntulix - I am seeing proper behavior in number input while in Pinyin if I remove decimal from your list of IsImeKeyEvent, like this:

diff --git a/intern/ghost/intern/GHOST_ImeWin32.cpp b/intern/ghost/intern/GHOST_ImeWin32.cpp
index d1fc80adf56..b2ef0023099 100644
--- a/intern/ghost/intern/GHOST_ImeWin32.cpp
+++ b/intern/ghost/intern/GHOST_ImeWin32.cpp
@@ -106,7 +106,7 @@ bool GHOST_ImeWin32::IsImeKeyEvent(char ascii)
     if (IsLanguage(IMELANG_JAPANESE) && (ascii >= ' ' && ascii <= '~')) {
       return true;
     }
-    else if (IsLanguage(IMELANG_CHINESE) && ascii && strchr("!\"$'(),.:;<>?[\\]^_`/", ascii)) {
+    else if (IsLanguage(IMELANG_CHINESE) && ascii && strchr("!\"$'(),:;<>?[\\]^_`/", ascii)) {
       return true;
     }
   }

@sntulix - I am seeing proper behavior in number input while in Pinyin if I remove decimal from your list of IsImeKeyEvent, like this: ``` diff --git a/intern/ghost/intern/GHOST_ImeWin32.cpp b/intern/ghost/intern/GHOST_ImeWin32.cpp index d1fc80adf56..b2ef0023099 100644 --- a/intern/ghost/intern/GHOST_ImeWin32.cpp +++ b/intern/ghost/intern/GHOST_ImeWin32.cpp @@ -106,7 +106,7 @@ bool GHOST_ImeWin32::IsImeKeyEvent(char ascii) if (IsLanguage(IMELANG_JAPANESE) && (ascii >= ' ' && ascii <= '~')) { return true; } - else if (IsLanguage(IMELANG_CHINESE) && ascii && strchr("!\"$'(),.:;<>?[\\]^_`/", ascii)) { + else if (IsLanguage(IMELANG_CHINESE) && ascii && strchr("!\"$'(),:;<>?[\\]^_`/", ascii)) { return true; } } ```

Harley Acheson commented

2022-01-11 19:43:36 +01:00

One complication is that there are two different keys that can enter "." in a numerical input (the one among regular keys and the one in the numerical keypad).

With current code I can press the regular period key to enter that character in text inputs to enter a wide Chinese period - "。" into text inputs. That seems fine as I can enter a regular period in English mode? But I can't enter a decimal point into a numerical entry with either key. With regular key it enters a wide period that is not accepted as valid, while numpad key does not register (I get KM_RELEASE but no KM_PRESS).

With above change I can enter decimals into numerical entries with either key. But I can duplicated characters when entering into a text input like this ".。". This might be a compromise you find is okay.

An alternative is to pass the GHOST_TKey to IsImeKeyEvent, take "." out of that test and add an "||" for key == GHOST_kKeyPeriod. That way it is for GHOST_kKeyPeriod but not for GHOST_kKeyNumpadPeriod.

With this you can enter decimal into numerical entries with numpad decimal, and you get wide period with regular key in text inputs. The only limitation is unable to enter decimal into numerical inputs with the regular period key. Again, might be a compromise you are okay with since you can toggle to English mode.

So far not seeing any nicer solution. It would be weird to change a "。" to a "." within ui_do_but_textedit at WM_IME_COMPOSITE_EVENT. ie: check ime_data->str_result against 0xE3 0x80 0x82 and insert a "." instead if ELEM(but->type, UI_BTYPE_NUM, UI_BTYPE_NUM_SLIDER) but would work in theory.

One complication is that there are two different keys that can enter "." in a numerical input (the one among regular keys and the one in the numerical keypad). With current code I can press the regular period key to enter that character in text inputs to enter a wide Chinese period - "。" into text inputs. That seems fine as I can enter a regular period in English mode? But I can't enter a decimal point into a numerical entry with either key. With regular key it enters a wide period that is not accepted as valid, while numpad key does not register (I get KM_RELEASE but no KM_PRESS). With above change I can enter decimals into numerical entries with either key. But I can duplicated characters when entering into a text input like this ".。". This might be a compromise you find is okay. An alternative is to pass the GHOST_TKey to IsImeKeyEvent, take "." out of that test and add an "||" for key == GHOST_kKeyPeriod. That way it is for GHOST_kKeyPeriod but not for GHOST_kKeyNumpadPeriod. With this you can enter decimal into numerical entries with numpad decimal, and you get wide period with regular key in text inputs. The only limitation is unable to enter decimal into numerical inputs with the regular period key. Again, might be a compromise you are okay with since you can toggle to English mode. So far not seeing any nicer solution. It would be weird to change a "。" to a "." within `ui_do_but_textedit` at WM_IME_COMPOSITE_EVENT. ie: check ime_data->str_result against 0xE3 0x80 0x82 and insert a "." instead if `ELEM(but->type, UI_BTYPE_NUM, UI_BTYPE_NUM_SLIDER)` but would work in theory.

Takahiro Shizuki commented

2022-01-12 08:28:49 +01:00

In #93626#1286354, @mano-wii wrote:
@sntulix, it takes someone with experience in this to review the suggested change (if you're sure it's safe, i think we can skip the review).
I suggest creating a patch through https:*developer.blender.org/differential/diff/create/ and contacting one of the developers who worked in the area (Eg. https:*developer.blender.org/diffusion/B/history/master/intern/ghost/intern/GHOST_ImeWin32.cpp).

I'll do it. There are also other many peoples!! Thank you.

> In #93626#1286354, @mano-wii wrote: > @sntulix, it takes someone with experience in this to review the suggested change (if you're sure it's safe, i think we can skip the review). > I suggest creating a patch through https:*developer.blender.org/differential/diff/create/ and contacting one of the developers who worked in the area (Eg. https:*developer.blender.org/diffusion/B/history/master/intern/ghost/intern/GHOST_ImeWin32.cpp). I'll do it. There are also other many peoples!! Thank you.

Takahiro Shizuki commented

2022-01-12 08:43:37 +01:00

In #93626#1286426, @Harley wrote:
@sntulix - I am seeing proper behavior in number input while in Pinyin if I remove decimal from your list of IsImeKeyEvent, like this:

: )

> In #93626#1286426, @Harley wrote: > @sntulix - I am seeing proper behavior in number input while in Pinyin if I remove decimal from your list of IsImeKeyEvent, like this: > : )

Takahiro Shizuki commented

2022-01-13 08:14:55 +01:00

Hi.

I found a icon Chinese/English punctuation in Microsoft IME PinYin.

It's status value can get by ImmGetConversionStatus().

- Microsoft Chinese IME Pinyin input pattern (conversion mode)
  - English (Half/Full, English punctuation only)
    - English Half width (1 IME_CMODE_NATIVE)
    - English Full width (8 IME_CMODE_FULLSHAPE)
  - Chinese (Half/Full, Chinese/English punctuation)
    - Chinese Half width, English punctuation (1 IME_CMODE_NATIVE?)
    - Chinese Half width, Chinese punctuation (401 IME_CMODE_SYMBOL | IME_CMODE_CHINESE)
    - Chinese Full width, English punctuation (9 IME_CMODE_CHINESE | IME_CMODE_FULLSHAPE)
    - Chinese Full width, Chinese punctuation (409 IME_CMODE_SYMBOL | IME_CMODE_CHINESE | IME_CMODE_FULLSHAPE)

But when input "0.0", the conversion status was not changed.

This is just think that Microsoft IME PinYin has numeric mode status. Maybe, he is changed by the key "{key 0}-{key 9}" to English punctuation, and it ends by the key not "{key 0}-{key 9}" and swich to Chinese punctuation.
I'll find about this.

Although, This task may be fix by creating a status property of punctuation language at GHOST_ImeWin32.

edit

By the way, I found that when input {key 0} with Fullwidth in Microsoft IME PinYin's Fullwidth mode, I got "0０". -> #94868

Hi. I found a icon Chinese/English punctuation in Microsoft IME PinYin. ![chinese_ime-punctuation_icon.PNG](https://archive.blender.org/developer/F12803451/chinese_ime-punctuation_icon.PNG) It's status value can get by ImmGetConversionStatus(). ``` - Microsoft Chinese IME Pinyin input pattern (conversion mode) - English (Half/Full, English punctuation only) - English Half width (1 IME_CMODE_NATIVE) - English Full width (8 IME_CMODE_FULLSHAPE) - Chinese (Half/Full, Chinese/English punctuation) - Chinese Half width, English punctuation (1 IME_CMODE_NATIVE?) - Chinese Half width, Chinese punctuation (401 IME_CMODE_SYMBOL | IME_CMODE_CHINESE) - Chinese Full width, English punctuation (9 IME_CMODE_CHINESE | IME_CMODE_FULLSHAPE) - Chinese Full width, Chinese punctuation (409 IME_CMODE_SYMBOL | IME_CMODE_CHINESE | IME_CMODE_FULLSHAPE) ``` But when input "0.0", the conversion status was not changed. This is just think that Microsoft IME PinYin has numeric mode status. Maybe, he is changed by the key "{key 0}-{key 9}" to English punctuation, and it ends by the key not "{key 0}-{key 9}" and swich to Chinese punctuation. I'll find about this. Although, This task may be fix by creating a status property of punctuation language at GHOST_ImeWin32. edit ---- By the way, I found that when input {key 0} with Fullwidth in Microsoft IME PinYin's Fullwidth mode, I got "0０". -> #94868

Takahiro Shizuki commented

2022-01-13 08:18:11 +01:00

FYI

ime_cmodes.h
// bit field for conversion mode
- define IME_CMODE_ALPHANUMERIC          0x0000
- define IME_CMODE_NATIVE                0x0001
- define IME_CMODE_CHINESE               IME_CMODE_NATIVE
- define IME_CMODE_HANGUL                IME_CMODE_NATIVE
- define IME_CMODE_JAPANESE              IME_CMODE_NATIVE
- define IME_CMODE_KATAKANA              0x0002  // only effect under IME_CMODE_NATIVE
- define IME_CMODE_LANGUAGE              0x0003
- define IME_CMODE_FULLSHAPE             0x0008
- define IME_CMODE_ROMAN                 0x0010
- define IME_CMODE_CHARCODE              0x0020
- define IME_CMODE_HANJACONVERT          0x0040
- define IME_CMODE_NATIVESYMBOL          0x0080


imm.h
*bit field for conversion mode* IME_CMODE_HANGEUL is old name of IME_CMODE_HANGUL. It will be gone eventually.
- define IME_CMODE_HANGEUL               IME_CMODE_NATIVE
- define IME_CMODE_SOFTKBD               0x0080
- define IME_CMODE_NOCONVERSION          0x0100
- define IME_CMODE_EUDC                  0x0200
- define IME_CMODE_SYMBOL                0x0400
- define IME_CMODE_FIXED                 0x0800
#define IME_CMODE_RESERVED          0xF0000000

// bit field for sentence mode
- define IME_SMODE_NONE                  0x0000
- define IME_SMODE_PLAURALCLAUSE         0x0001
- define IME_SMODE_SINGLECONVERT         0x0002
- define IME_SMODE_AUTOMATIC             0x0004
- define IME_SMODE_PHRASEPREDICT         0x0008
- define IME_SMODE_CONVERSATION          0x0010
#define IME_SMODE_RESERVED          0x0000F000

FYI ``` ime_cmodes.h // bit field for conversion mode - define IME_CMODE_ALPHANUMERIC 0x0000 - define IME_CMODE_NATIVE 0x0001 - define IME_CMODE_CHINESE IME_CMODE_NATIVE - define IME_CMODE_HANGUL IME_CMODE_NATIVE - define IME_CMODE_JAPANESE IME_CMODE_NATIVE - define IME_CMODE_KATAKANA 0x0002 // only effect under IME_CMODE_NATIVE - define IME_CMODE_LANGUAGE 0x0003 - define IME_CMODE_FULLSHAPE 0x0008 - define IME_CMODE_ROMAN 0x0010 - define IME_CMODE_CHARCODE 0x0020 - define IME_CMODE_HANJACONVERT 0x0040 - define IME_CMODE_NATIVESYMBOL 0x0080 imm.h *bit field for conversion mode* IME_CMODE_HANGEUL is old name of IME_CMODE_HANGUL. It will be gone eventually. - define IME_CMODE_HANGEUL IME_CMODE_NATIVE - define IME_CMODE_SOFTKBD 0x0080 - define IME_CMODE_NOCONVERSION 0x0100 - define IME_CMODE_EUDC 0x0200 - define IME_CMODE_SYMBOL 0x0400 - define IME_CMODE_FIXED 0x0800 #define IME_CMODE_RESERVED 0xF0000000 // bit field for sentence mode - define IME_SMODE_NONE 0x0000 - define IME_SMODE_PLAURALCLAUSE 0x0001 - define IME_SMODE_SINGLECONVERT 0x0002 - define IME_SMODE_AUTOMATIC 0x0004 - define IME_SMODE_PHRASEPREDICT 0x0008 - define IME_SMODE_CONVERSATION 0x0010 #define IME_SMODE_RESERVED 0x0000F000 ```

Takahiro Shizuki commented

2022-01-13 12:46:34 +01:00

In #93626#1286499, @Harley wrote:

So far not seeing any nicer solution. It would be weird to change a "。" to a "." within ui_do_but_textedit at WM_IME_COMPOSITE_EVENT. ie: check ime_data->str_result against 0xE3 0x80 0x82 and insert a "." instead if ELEM(but->type, UI_BTYPE_NUM, UI_BTYPE_NUM_SLIDER) but would work in theory.

If it is true that Microsoft IME PinyYin has numeric mode and if ime_data->str_result gets always each key press, you may get that pressing {key .} is 'period' or 'fullstop' by check last character of ime_data->str_result.

> In #93626#1286499, @Harley wrote: > So far not seeing any nicer solution. It would be weird to change a "。" to a "." within `ui_do_but_textedit` at WM_IME_COMPOSITE_EVENT. ie: check ime_data->str_result against 0xE3 0x80 0x82 and insert a "." instead if `ELEM(but->type, UI_BTYPE_NUM, UI_BTYPE_NUM_SLIDER)` but would work in theory. If it is true that Microsoft IME PinyYin has numeric mode and if ime_data->str_result gets always each key press, you may get that pressing {key .} is 'period' or 'fullstop' by check last character of ime_data->str_result.

Harley Acheson commented

2022-01-13 18:42:53 +01:00

The following is the minimum changes I could find to fix this:

IMEDecimal.diff

The change to IsImeKeyEvent is needed to allow numpad decimal entry. The change to ui_do_but_textedit allows using Chinese full stop as decimal. So this allows both keys to enter "." into a number, while still allowing entry of "。" into text fields.

The following is the minimum changes I could find to fix this: [IMEDecimal.diff](https://archive.blender.org/developer/F12803993/IMEDecimal.diff) The change to `IsImeKeyEvent` is needed to allow numpad decimal entry. The change to `ui_do_but_textedit` allows using Chinese full stop as decimal. So this allows both keys to enter "." into a number, while still allowing entry of "。" into text fields.

Takahiro Shizuki commented

2022-01-22 09:38:06 +01:00

Hi. @Harley

IMEDecimal.diff

The change to IsImeKeyEvent is needed to allow numpad decimal entry. The change to ui_do_but_textedit allows using Chinese full stop as decimal. So this allows both keys to enter "." into a number, while still allowing entry of "。" into text fields.

I checked. It's good.

checked list

object properties
- Location X
  - Microsoft IME Pinyin
    - Numpad's key 0-9 . - + * /
    - Numpad's key "0.1+1" -> 1.1m.
  - Microsoft IME Pinyin (compatible)
    - Numpad's key 0-9 . - + * /
    - Numpad's key "0.1+1" -> 1.1m.

Hi. @Harley > [IMEDecimal.diff](https://archive.blender.org/developer/F12803993/IMEDecimal.diff) > > The change to `IsImeKeyEvent` is needed to allow numpad decimal entry. The change to `ui_do_but_textedit` allows using Chinese full stop as decimal. So this allows both keys to enter "." into a number, while still allowing entry of "。" into text fields. I checked. It's good. checked list - object properties - Location X - Microsoft IME Pinyin - Numpad's key 0-9 . - + * / - Numpad's key "0.1+1" -> 1.1m. - Microsoft IME Pinyin (compatible) - Numpad's key 0-9 . - + * / - Numpad's key "0.1+1" -> 1.1m.

Harley Acheson commented

2022-01-22 17:16:55 +01:00

Okay, I think we’ll have to do this slightly differently. I’ll probably submit this as two separate patches because there are two quite different things here that should be considered separately. And I’ll probably make you, @sntulix, one of the reviewers.

Okay, I think we’ll have to do this slightly differently. I’ll probably submit this as two separate patches because there are two quite different things here that should be considered separately. And I’ll probably make you, @sntulix, one of the **reviewers**.

blender-admin commented

2022-01-28 22:11:56 +01:00

This issue was referenced by 4311a32bc2

This issue was referenced by 4311a32bc2d9c9e5db475a75cac5b11760f4db71

blender-admin commented

2022-01-28 22:32:46 +01:00

This issue was referenced by 6b7756279f

This issue was referenced by 6b7756279f719a434505d461fb03b5faa5ce9aa0

Harley Acheson commented

2022-01-28 22:33:47 +01:00

Changed status from 'Needs Triage' to: 'Resolved'

Harley Acheson closed this issue

2022-01-28 22:33:47 +01:00

Harley Acheson self-assigned this 2022-01-28 22:33:47 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Can't input '. ' in Transform input box (when using IME) #93626

edit