Naming attribute in multiple geometry nodes modifier causes blender to crash #93782

Closed
opened 2021-12-07 00:48:23 +01:00 by Godwin Jimoh · 15 comments

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.11

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: f1cca30557
Worked: (newest version of Blender that worked as expected)

Short description of error
When I stack up multiple geometry node modifiers with node groups similar to the one below and try to rename the output attributes then blender crashes.
output attribute bug.png
this is the error from the console
crash report.jpg

Exact steps for others to reproduce the error

  1. open this blend file: output attribute bug.blend or set up the same node group from the picture above
  2. Duplicate the geometry nodes modifier up to 5 times
  3. Try to rename the output attributes in the modifier panel of each of the geometry nodes modifier and then blender crashes

Some things to note about this bug:

  • The error only happens when the geometry being instanced are curve objects. mesh works just fine.
  • The attribute output does not need to be connected to anything. Just that they must be named in the modifier panel and they must be at least two outputs beyond just the geometry output.
  • The bug goes away when the Realize Instance node is removed.
  • The crash is triggered when you duplicate the geo nodes modifier and try to rename the output. (It does not matter if it's duplicated or a new node group. as long as it meets the criteria above it will eventually crash)
  • The previous step must be repeated like 2 to 3 (at most 5) times before there’s a crash (at least on my end).
  • I can stack the same geometry nodes modifier with the same node group over and over as many times as I like. The crash only happens when I try to enter the name of the output attribute in the modifier panel.
**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 466.11 **Blender Version** Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: `f1cca30557` Worked: (newest version of Blender that worked as expected) **Short description of error** When I stack up multiple geometry node modifiers with node groups similar to the one below and try to rename the output attributes then blender crashes. ![output attribute bug.png](https://archive.blender.org/developer/F12700841/output_attribute_bug.png) this is the error from the console ![crash report.jpg](https://archive.blender.org/developer/F12700848/crash_report.jpg) **Exact steps for others to reproduce the error** 1. open this blend file: [output attribute bug.blend](https://archive.blender.org/developer/F12700856/output_attribute_bug.blend) or set up the same node group from the picture above 2. Duplicate the geometry nodes modifier up to 5 times 3. Try to rename the output attributes in the modifier panel of each of the geometry nodes modifier and then blender crashes **Some things to note about this bug:** - The error only happens when the geometry being instanced are curve objects. mesh works just fine. - The attribute output does not need to be connected to anything. Just that they must be named in the modifier panel and they must be at least two outputs beyond just the geometry output. - The bug goes away when the Realize Instance node is removed. - The crash is triggered when you duplicate the geo nodes modifier and try to rename the output. (It does not matter if it's duplicated or a new node group. as long as it meets the criteria above it will eventually crash) - The previous step must be repeated like 2 to 3 (at most 5) times before there’s a crash (at least on my end). - I can stack the same geometry nodes modifier with the same node group over and over as many times as I like. The crash only happens when I try to enter the name of the output attribute in the modifier panel.
Author

Added subscriber: @Astronet-4

Added subscriber: @Astronet-4

#94106 was marked as duplicate of this issue

#94106 was marked as duplicate of this issue
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Added subscriber: @JacquesLucke

Added subscriber: @JacquesLucke
Member

I can reproduce it in 3.0 but not in master. It seems to be a problem with joining curves.
Backtrace: P2657.
It asserts when calling assert_valid_point_attributes.
In master that was probably fixed by 506d672524, can someone confirm that?

I can reproduce it in 3.0 but not in master. It seems to be a problem with joining curves. Backtrace: [P2657](https://archive.blender.org/developer/P2657.txt). It asserts when calling `assert_valid_point_attributes`. In master that was probably fixed by 506d672524, can someone confirm that?
Member

Added subscriber: @JoseConseco

Added subscriber: @JoseConseco
Member

can someone confirm that?

@JacquesLucke , sure. I will check

Fix lies between 88e9e97ee9 - fed4fc9c42 so probably 506d672524 has fixed the crash? I will confirm with git bisect.

> can someone confirm that? @JacquesLucke , sure. I will check Fix lies between 88e9e97ee907 - fed4fc9c42d2 so probably `506d672524` has fixed the crash? I will confirm with git bisect.
Member

Yes, on master crash was fixed by 506d672524

3.0.0 is still broken.

Yes, on master crash was fixed by 506d672524 3.0.0 is still broken.
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

3.0.0 is still broken.

@JacquesLucke , would it be safe to backport 506d672524?

Confirming for now because crash persists on 3.0.0 branch. (Feel free to reset status)

> 3.0.0 is still broken. @JacquesLucke , would it be safe to backport 506d672524? Confirming for now because crash persists on 3.0.0 branch. (Feel free to reset status)
Member

Yes, I think backporting this commit should be safe. It would only not be safe if the realize-instances code in 3.0 has a bug as well (which we haven't found yet afaik). However, if such a bug exists, it should be fixed anyway.

Yes, I think backporting this commit should be safe. It would only not be safe if the realize-instances code in 3.0 has a bug as well (which we haven't found yet afaik). However, if such a bug exists, it should be fixed anyway.
Author

The same "EXCEPTION_ACCESS_VIOLATION" error seems to show up in a geometry nodes bug I just reported: #94659. This time it is triggered when the collection Info node and the Separate Geometry node are connected together under certain conditions

The same "**EXCEPTION_ACCESS_VIOLATION**" error seems to show up in a geometry nodes bug I just reported: #94659. This time it is triggered when the **collection Info** node and the **Separate Geometry** node are connected together under certain conditions

Added subscriber: @mont29

Added subscriber: @mont29

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Bastien Montagne self-assigned this 2022-01-27 16:30:25 +01:00

Will consider this issue as resolved since it is fixed in master. Unfortunately it seems it missed the 3.0.1 corrective release though?

Will consider this issue as resolved since it is fixed in master. Unfortunately it seems it missed the 3.0.1 corrective release though?
Thomas Dinges added this to the 3.0 milestone 2023-02-08 15:58:47 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#93782
No description provided.