Make Instances Real doesn't work for geometry instances #93903

New Issue

Dusan · 2021-12-09T15:35:42+01:00

Dusan commented

2021-12-09 15:35:42 +01:00

System Information
Operating system: Windows-10-10.0.18363-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 750/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.41

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: f1cca30557
Worked: (newest version of Blender that worked as expected)

Short description of error
When I want to make instances real on object that has geometry nodes, blender create duplicate of whole mesh, togather with instances, on each place (point) where single instance mesh should be. I have attached screenshots and test scene that reproduces the bug.

Exact steps for others to reproduce the error
Open .blend file I sent you, hover with mouse over 4 instaced spheres, and pres ctrl+A... select make instances real. You will see that geometry nodes instances are not created properly (whole geometry is duplicated on each geometry node point).

Similar thing happens when instancing collections, and trying to make them real - the parent relationship/hiararchy is not working. So there is a bug there also.geom_nodes_bug.zip

**System Information** Operating system: Windows-10-10.0.18363-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 750/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 471.41 **Blender Version** Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: `f1cca30557` Worked: (newest version of Blender that worked as expected) **Short description of error** When I want to make instances real on object that has geometry nodes, blender create duplicate of whole mesh, togather with instances, on each place (point) where single instance mesh should be. I have attached screenshots and test scene that reproduces the bug. **Exact steps for others to reproduce the error** Open .blend file I sent you, hover with mouse over 4 instaced spheres, and pres ctrl+A... select make instances real. You will see that geometry nodes instances are not created properly (whole geometry is duplicated on each geometry node point). Similar thing happens when instancing collections, and trying to make them real - the parent relationship/hiararchy is not working. So there is a bug there also.[geom_nodes_bug.zip](https://archive.blender.org/developer/F12720758/geom_nodes_bug.zip) ![blend01.jpg](https://archive.blender.org/developer/F12720783/blend01.jpg) ![blend02.jpg](https://archive.blender.org/developer/F12720784/blend02.jpg) ![blend03.jpg](https://archive.blender.org/developer/F12720785/blend03.jpg)

Dusan commented

2021-12-09 15:35:42 +01:00

Added subscriber: @DS44

blender-admin commented

2021-12-09 15:35:42 +01:00

#103919 was marked as duplicate of this issue

blender-admin commented

2021-12-09 15:35:42 +01:00

#93734 was marked as duplicate of this issue

Richard Antalik commented

2021-12-09 22:13:10 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey changed title from ~~Make Instances Real on geometry nodes creates duplicate geometry~~ to Make Instances Real doesn't work for geometry instances

2021-12-10 18:14:06 +01:00

Hans Goudey commented

2021-12-14 01:13:33 +01:00

Added subscribers: @pixldg, @lichtwerk

Matt Curtis commented

2021-12-17 17:13:45 +01:00

Added subscriber: @MattCurtis

Andy Cuccaro commented

2021-12-29 19:10:34 +01:00

Added subscriber: @AndyCuccaro

Mike commented

2022-01-28 15:00:11 +01:00

Added subscriber: @MMMM

Mike commented

2022-01-28 15:00:11 +01:00

How is that a bug?
You're still applying the geometry node to the mesh, while changing the mesh.

When you "realize" instances, in this case, you're creating an entirely new mesh, but your geometry node modifier is still applied.
Instead, use the realize instances node, or delete the geo-nodes modifier of the new mesh.

How is that a bug? You're still applying the geometry node to the mesh, while changing the mesh. When you "realize" instances, in this case, you're creating an entirely new mesh, but your geometry node modifier is still applied. Instead, use the realize instances node, or delete the geo-nodes modifier of the new mesh.

Dusan commented

2022-01-29 16:19:12 +01:00

Added subscriber: @Mike-102

Dusan commented

2022-01-29 16:19:12 +01:00

In #93903#1297015, @MMMM wrote:
How is that a bug?

It is a bug since you are unable to make real meshes from instanced geometry (you get copy of original mesh with geomnode modifier, on each point of the original mesh), and also behavior is changed from previous versions of Blender (in previous versions it was enough to just go to Object->Apply->Make instances real, and visible instances would become meshes, simple as that - now that is not the case)

> In #93903#1297015, @MMMM wrote: > How is that a bug? It is a bug since you are unable to make real meshes from instanced geometry (you get copy of original mesh with geomnode modifier, on each point of the original mesh), and also behavior is changed from previous versions of Blender (in previous versions it was enough to just go to Object->Apply->Make instances real, and visible instances would become meshes, simple as that - now that is not the case)

Mike commented

2022-01-29 17:12:20 +01:00

I see. I'm guessing that, that function would just internally add a "realize instance" after the geo-nodes modifier, just like the node would.

Dusan commented

2022-01-29 18:17:10 +01:00

In #93903#1297528, @MMMM wrote:
I see. I'm guessing that, that function would just internally add a "realize instance" after the geo-nodes modifier, just like the node would.

Realize instance - works to some extent, since you can make a collapsed mesh from it afterwards (Object->Convert->Mesh). But that is not intended behavior, since in previous versions, when you make instances real, it creates real objects (separate instance mesh for each point) and you can parent them etc.

> In #93903#1297528, @MMMM wrote: > I see. I'm guessing that, that function would just internally add a "realize instance" after the geo-nodes modifier, just like the node would. Realize instance - works to some extent, since you can make a collapsed mesh from it afterwards (Object->Convert->Mesh). But that is not intended behavior, since in previous versions, when you make instances real, it creates real objects (separate instance mesh for each point) and you can parent them etc.

Jacques Lucke commented

2022-03-02 12:39:43 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2022-03-02 12:39:44 +01:00

Something like this can work:

diff --git a/source/blender/editors/object/object_add.c b/source/blender/editors/object/object_add.c
index e9cbd7bed55..7fd18835c86 100644
--- a/source/blender/editors/object/object_add.c
+++ b/source/blender/editors/object/object_add.c
@@ -2324,7 +2324,17 @@ static void make_object_duplilist_real(bContext *C,
 
   LISTBASE_FOREACH (DupliObject *, dob, lb_duplis) {
     Object *ob_src = DEG_get_original_object(dob->ob);
-    Object *ob_dst = ID_NEW_SET(ob_src, BKE_id_copy(bmain, &ob_src->id));
+    Object *ob_dst;
+    if (dob->ob == object_eval) {
+      ID *new_data = BKE_id_copy(bmain, dob->ob_data);
+      ob_dst = ID_NEW_SET(ob_src, BKE_id_new(bmain, ID_OB, ob_src->id.name + 2));
+      ob_dst->data = new_data;
+      ob_dst->type = BKE_object_obdata_to_type(new_data);
+    }
+    else {
+      ob_dst = ID_NEW_SET(ob_src, BKE_id_copy(bmain, &ob_src->id));
+    }
+
     id_us_min(&ob_dst->id);
 
     /* font duplis can have a totcol without material, we get them from parent

However, this needs some more investigation with regards to user counting etc.
IMO that's too risky to do for 3.1 now and it's not important enough to justify that risk. Still should be fixed soonish.

Something like this can work: ``` diff --git a/source/blender/editors/object/object_add.c b/source/blender/editors/object/object_add.c index e9cbd7bed55..7fd18835c86 100644 --- a/source/blender/editors/object/object_add.c +++ b/source/blender/editors/object/object_add.c @@ -2324,7 +2324,17 @@ static void make_object_duplilist_real(bContext *C, LISTBASE_FOREACH (DupliObject *, dob, lb_duplis) { Object *ob_src = DEG_get_original_object(dob->ob); - Object *ob_dst = ID_NEW_SET(ob_src, BKE_id_copy(bmain, &ob_src->id)); + Object *ob_dst; + if (dob->ob == object_eval) { + ID *new_data = BKE_id_copy(bmain, dob->ob_data); + ob_dst = ID_NEW_SET(ob_src, BKE_id_new(bmain, ID_OB, ob_src->id.name + 2)); + ob_dst->data = new_data; + ob_dst->type = BKE_object_obdata_to_type(new_data); + } + else { + ob_dst = ID_NEW_SET(ob_src, BKE_id_copy(bmain, &ob_src->id)); + } + id_us_min(&ob_dst->id); /* font duplis can have a totcol without material, we get them from parent ``` However, this needs some more investigation with regards to user counting etc. IMO that's too risky to do for 3.1 now and it's not important enough to justify that risk. Still should be fixed soonish.

Mark Arrebola commented

2022-03-28 10:17:22 +02:00

Added subscriber: @markbola3d

Mark Arrebola commented

2022-03-28 10:17:22 +02:00

Hi all,

Any word on when this will be fixed?

As far as I can tell this was the only workaround for getting UVed instances into Unity from Geometry Nodes. If anyone has any other workarounds in the interim, I'm all ears!

Video of ideal behaviour here:

https://youtu.be/qrXZNG4yAa8?t=248

Edit: So, commentator's curse is a thing, the moment I posted this I found a workaround:

Future people with same question as me - make a copy of your geo nodes object (for safety), apply geo nodes modifier, convert UVMap attribute from object data properties to an actual UVMap!

Edit 2: It would still be nice to have the Make Instances Real trick working for occlusion culling purposes.

Many thanks,
Mark

Hi all, Any word on when this will be fixed? As far as I can tell this was the only workaround for getting UVed instances into Unity from Geometry Nodes. If anyone has any other workarounds in the interim, I'm all ears! Video of ideal behaviour here: https://youtu.be/qrXZNG4yAa8?t=248 Edit: So, commentator's curse is a thing, the moment I posted this I found a workaround: Future people with same question as me - make a copy of your geo nodes object (for safety), apply geo nodes modifier, convert UVMap attribute from object data properties to an actual UVMap! Edit 2: It would still be nice to have the Make Instances Real trick working for occlusion culling purposes. Many thanks, Mark

thierrry kobyleski commented

2022-04-19 20:21:32 +02:00

Added subscriber: @thierrykobyleski

Tom Smalley commented

2022-06-03 10:55:07 +02:00

Added subscriber: @tomsmalley

Jan Kadeřábek commented

2022-06-07 17:52:03 +02:00

Added subscriber: @JanKaderabek

Sergey commented

2022-06-24 11:03:21 +02:00

Added subscriber: @randum

Ryan Yoshimoto commented

2022-08-10 01:29:46 +02:00

Added subscriber: @Yoshir

Ryan Yoshimoto commented

2022-08-10 01:29:46 +02:00

+1 to fix this.

"Make Instances real" is super important to get blender creations into Unreal and other frameworks. Make Instances Real also does no see to work if you have added a Realize Instance node to you geometry node (graph)

all the best

ryan

+1 to fix this. "Make Instances real" is super important to get blender creations into Unreal and other frameworks. Make Instances Real also does no see to work if you have added a Realize Instance node to you geometry node (graph) all the best - ryan

Wilsimar commented

2023-01-16 16:59:57 +01:00

Added subscriber: @wilBr

Wilsimar commented

2023-01-16 16:59:57 +01:00

Still no fixed for 3.4.1 ?

Iliya Katushenock commented

2023-01-16 17:12:47 +01:00

Added subscriber: @F_Scociety

Soeren Schmidt-Clausen commented

2023-01-16 18:59:06 +01:00

In #93903#1401970, @Yoshir wrote:
+1 to fix this.

"Make Instances real" is super important to get blender creations into Unreal and other frameworks. Make Instances Real also does no see to work if you have added a Realize Instance node to you geometry node (graph)

all the best
-ryan

+1 from me too
Without this the only way is to relalize the instances and Export them as one mesh, which a is very slow in some cases.

> In #93903#1401970, @Yoshir wrote: > +1 to fix this. > > "Make Instances real" is super important to get blender creations into Unreal and other frameworks. Make Instances Real also does no see to work if you have added a Realize Instance node to you geometry node (graph) > > all the best > -ryan +1 from me too Without this the only way is to relalize the instances and Export them as one mesh, which a is very slow in some cases.

Wilsimar commented

2023-01-17 02:45:25 +01:00

Without this the only way is to relalize the instances and Export them as one mesh, which a is very slow in some cases.

With a collection info node the "make instances real" operator works very well, creating individual instances.

> Without this the only way is to relalize the instances and Export them as one mesh, which a is very slow in some cases. With a collection info node the "make instances real" operator works very well, creating individual instances.

👍 1

Soeren Schmidt-Clausen commented

2023-01-17 09:53:01 +01:00

In #93903#1475269, @wilBr wrote:

Without this the only way is to relalize the instances and Export them as one mesh, which a is very slow in some cases.

With a collection info node the "make instances real" operator works very well, creating individual instances.

This works, even with multiple collection that each contain one object. Thank you so much!

> In #93903#1475269, @wilBr wrote: >> Without this the only way is to relalize the instances and Export them as one mesh, which a is very slow in some cases. > > With a collection info node the "make instances real" operator works very well, creating individual instances. This works, even with multiple collection that each contain one object. Thank you so much!

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Make Instances Real doesn't work for geometry instances #93903