Cycles/Compositor: The denoiser returns a black image if not all requirements are fulfilled #94127

New Issue

Raimund Klink · 2021-12-15T21:47:50+01:00

Raimund Klink commented

2021-12-15 21:47:50 +01:00

System Information
Operating system: Default KVM (Proxmox, Linux)
Graphics card: None

Blender Version
Broken: Blender 3.0
Worked: Before Blender 3.0 the frame was just not denoised

Short description of error
If you enable OIDN/Optix denoising without having the needed CPU flags you will get a black frame back.
The desired outcome would be an aborted render with a helpful error.

Exact steps for others to reproduce the error

Set up a default KVM
Enable denoising
Render over the CLI one Frame
It will be black

Further information
The config of a default KVM:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   40 bits physical, 48 bits virtual
CPU(s):                          6
On-line CPU(s) list:             0-5
Thread(s) per core:              1
Core(s) per socket:              6
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       AuthenticAMD
CPU family:                      15
Model:                           6
Model name:                      Common KVM processor
Stepping:                        1
CPU MHz:                         3399.998
BogoMIPS:                        6799.99
Hypervisor vendor:               KVM
Virtualization type:             full
L1d cache:                       384 KiB
L1i cache:                       384 KiB
L2 cache:                        3 MiB
L3 cache:                        16 MiB
NUMA node0 CPU(s):               0-5
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Spec store bypass: Not affected
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Full AMD retpoline, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx lm rep_good nopl cpuid extd_apicid tsc_known_freq pni cx16 x2apic hypervisor cmp_legacy 3dnowprefetch vmmcal
                                 l

The command that I used to render one frame:

./blender -b --debug --debug-cycles --python-expr 'import _cycles;print(_cycles.with_openimagedenoise);print(_cycles.with_embree);print(_cycles.with_osl)' "your path to the .blend" -f 1

oidn_disabled.blend
oidn_disabled.txt

oidn_enabled.blend
oidn_enabled.txt

optix_enabled.blend
optix_enabled.txt

If I set up the KVM to use HOST at least OIDN works
HOST config:

Virtualization:                  AMD-V
Hypervisor vendor:               KVM
Virtualization type:             full
L1d cache:                       384 KiB
L1i cache:                       384 KiB
L2 cache:                        3 MiB
L3 cache:                        16 MiB
NUMA node0 CPU(s):               0-5
Vulnerability Itlb multihit:     Not affected
Vulnerability L1tf:              Not affected
Vulnerability Mds:               Not affected
Vulnerability Meltdown:          Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Full AMD retpoline, IBPB conditional, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm rep_good nopl cpuid extd_apicid tsc_known_freq pni pclmulqdq ssse3 fma cx1
                                 6 sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw perfctr_core ssbd ibpb vmmcall fsgsbase tsc_adjust bm
                                 i1 avx2 smep bmi2 rdseed adx smap clflushopt sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr virt_ssbd arat npt nrip_save arch_capabilities

Why it would be nice to have the bug fixed:
We have a renderfarm that consist out of random machines and it is always a problem if random frames are black/not denoised/strange colored/broken/out of order.

**System Information** Operating system: Default KVM (Proxmox, Linux) Graphics card: None **Blender Version** Broken: Blender 3.0 Worked: Before Blender 3.0 the frame was just not denoised **Short description of error** If you enable OIDN/Optix denoising without having the needed CPU flags you will get a black frame back. The desired outcome would be an aborted render with a helpful error. **Exact steps for others to reproduce the error** 1. Set up a default KVM 2. Enable denoising 3. Render over the CLI one Frame 4. It will be black **Further information** The config of a default KVM: ``` Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 40 bits physical, 48 bits virtual CPU(s): 6 On-line CPU(s) list: 0-5 Thread(s) per core: 1 Core(s) per socket: 6 Socket(s): 1 NUMA node(s): 1 Vendor ID: AuthenticAMD CPU family: 15 Model: 6 Model name: Common KVM processor Stepping: 1 CPU MHz: 3399.998 BogoMIPS: 6799.99 Hypervisor vendor: KVM Virtualization type: full L1d cache: 384 KiB L1i cache: 384 KiB L2 cache: 3 MiB L3 cache: 16 MiB NUMA node0 CPU(s): 0-5 Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Spec store bypass: Not affected Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Full AMD retpoline, STIBP disabled, RSB filling Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx lm rep_good nopl cpuid extd_apicid tsc_known_freq pni cx16 x2apic hypervisor cmp_legacy 3dnowprefetch vmmcal l ``` The command that I used to render one frame: ``` ./blender -b --debug --debug-cycles --python-expr 'import _cycles;print(_cycles.with_openimagedenoise);print(_cycles.with_embree);print(_cycles.with_osl)' "your path to the .blend" -f 1 ``` [oidn_disabled.blend](https://archive.blender.org/developer/F12749974/oidn_disabled.blend) [oidn_disabled.txt](https://archive.blender.org/developer/F12749975/oidn_disabled.txt) ![oidn_disabled_0001.png](https://archive.blender.org/developer/F12749976/oidn_disabled_0001.png) [oidn_enabled.blend](https://archive.blender.org/developer/F12749978/oidn_enabled.blend) [oidn_enabled.txt](https://archive.blender.org/developer/F12749980/oidn_enabled.txt) ![oidn_enabled_0001.png](https://archive.blender.org/developer/F12749981/oidn_enabled_0001.png) [optix_enabled.blend](https://archive.blender.org/developer/F12749984/optix_enabled.blend) [optix_enabled.txt](https://archive.blender.org/developer/F12749985/optix_enabled.txt) ![optix_enabled_0001.png](https://archive.blender.org/developer/F12749986/optix_enabled_0001.png) If I set up the KVM to use HOST at least OIDN works HOST config: ``` Virtualization: AMD-V Hypervisor vendor: KVM Virtualization type: full L1d cache: 384 KiB L1i cache: 384 KiB L2 cache: 3 MiB L3 cache: 16 MiB NUMA node0 CPU(s): 0-5 Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Full AMD retpoline, IBPB conditional, STIBP disabled, RSB filling Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm rep_good nopl cpuid extd_apicid tsc_known_freq pni pclmulqdq ssse3 fma cx1 6 sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw perfctr_core ssbd ibpb vmmcall fsgsbase tsc_adjust bm i1 avx2 smep bmi2 rdseed adx smap clflushopt sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr virt_ssbd arat npt nrip_save arch_capabilities ``` **Why it would be nice to have the bug fixed:** We have a renderfarm that consist out of random machines and it is always a problem if random frames are black/not denoised/strange colored/broken/out of order.

Raimund Klink commented

2021-12-15 21:47:51 +01:00

Added subscriber: @Raimund58

Raimund Klink commented

2021-12-15 21:58:39 +01:00

Another example:
The black frames are rendered by a default KVM, the normal ones by a HOST KVM

Another example: The black frames are rendered by a default KVM, the normal ones by a HOST KVM ![2021-12-15 21_57_04-SheepIt Render Farm.png](https://archive.blender.org/developer/F12750203/2021-12-15_21_57_04-SheepIt_Render_Farm.png)

Ryan Inch commented

2021-12-19 09:06:35 +01:00

Added subscriber: @Imaginer

Raimund Klink commented

2021-12-19 21:24:55 +01:00

Sometimes other features seem to break as well:

The broken frame was rendered by a "Common KVM processor"

Sometimes other features seem to break as well: ![0511.png](https://archive.blender.org/developer/F12764420/0511.png) ![0512.png](https://archive.blender.org/developer/F12764422/0512.png) ![0513.png](https://archive.blender.org/developer/F12764424/0513.png) The broken frame was rendered by a "Common KVM processor"

Raimund Klink commented

2021-12-19 21:32:57 +01:00

Another Blender 2.93 example:

Another Blender 2.93 example: ![0025.png](https://archive.blender.org/developer/F12764436/0025.png) ![0026.png](https://archive.blender.org/developer/F12764440/0026.png) ![0027.png](https://archive.blender.org/developer/F12764437/0027.png)

Philipp Oeser commented

2022-01-24 12:43:30 +01:00

Added subscribers: @Sergey, @brecht, @lichtwerk

Philipp Oeser commented

2022-01-24 12:43:30 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2022-01-24 12:43:30 +01:00

#76668, #94333 could be related.

@Sergey, @brecht: I am unable to test this, is this something to be expected?

#76668, #94333 could be related. @Sergey, @brecht: I am unable to test this, is this something to be expected?

Philipp Oeser commented

2022-01-27 10:19:42 +01:00

#93838 (Denoise on Image sequence fails ( results in a blank,transparent image) after first frame) smells the same as well

Raimund Klink commented

2022-01-27 12:36:13 +01:00

In #94127#1295825, @lichtwerk wrote:
#93838 (Denoise on Image sequence fails ( results in a blank,transparent image) after first frame) smells the same as well

Maybe, but we can identify that better after he attaches his system-info.

> In #94127#1295825, @lichtwerk wrote: > #93838 (Denoise on Image sequence fails ( results in a blank,transparent image) after first frame) smells the same as well Maybe, but we can identify that better after he attaches his system-info.

blender-admin commented

2022-01-28 13:25:23 +01:00

This issue was referenced by 430f71fce2

This issue was referenced by 430f71fce289e876602178330ac725c46c043abf

Sergey Sharybin commented

2022-01-28 13:30:56 +01:00

Proposed fix for the Cycles part is at D13944. Note that SSE 4.1 is required for OIDN, so the patch will effectively make render fail on the configuration where SSE 4.1 support is not detected.

Not sure what is the best way to tackle Compositor node.

For the extra features which are not working reliably (mentioned in #94127#1275555) think is better to submit a separate report with a demo .blend file.

Proposed fix for the Cycles part is at [D13944](https://archive.blender.org/developer/D13944). Note that SSE 4.1 is required for OIDN, so the patch will effectively make render fail on the configuration where SSE 4.1 support is not detected. Not sure what is the best way to tackle Compositor node. For the extra features which are not working reliably (mentioned in #94127#1275555) think is better to submit a separate report with a demo .blend file.

Raimund Klink commented

2022-01-28 14:19:14 +01:00

For the extra features which are not working reliably (mentioned in #94127#1275555) think is better to submit a separate report with a demo .blend file.

I would do that if I still had the .blend. But I only have the screenshots. Sorry about that :/
But I think that mainly the denoise broke, but I can not verify that.

Thank you for fixing this <3

>For the extra features which are not working reliably (mentioned in #94127#1275555) think is better to submit a separate report with a demo .blend file. I would do that if I still had the .blend. But I only have the screenshots. Sorry about that :/ But I think that mainly the denoise broke, but I can not verify that. Thank you for fixing this <3

Raimund Klink commented

2022-01-28 14:32:20 +01:00

@Sergey You wrote:

This change makes it so that if OIDN is not supported on the current
CPU Cycles will report an error and stop rendering. This behavior is
similar to when an OptiX denoiser is requested and there is no OptiX
compatible device available.

But in my tests I also got a black frame from Optix denoising.
Are you sure about the behaviour or did I make a mistake?

@Sergey You wrote: >This change makes it so that if OIDN is not supported on the current >CPU Cycles will report an error and stop rendering. **This behavior is >similar to when an OptiX denoiser is requested and there is no OptiX >compatible device available.** But in my tests I also got a black frame from Optix denoising. Are you sure about the behaviour or did I make a mistake?

Sergey Sharybin commented

2022-01-28 15:01:29 +01:00

@Raimund58 What a great question! In my initial implementation that what would've happened. What I didn't realize is that this change has been made 0ab1b19de4.

@Raimund58 What a great question! In my initial implementation that what would've happened. What I didn't realize is that this change has been made 0ab1b19de4.

Sergey Sharybin commented

2022-01-28 15:15:56 +01:00

@Raimund58 The complicated part is that we kind of want .blend files to be easily shareable between artists in a way that they can render them without running into errors, and this is an opposite of what one'd want for the render farms and studios. Additionally, making such changes without any notification to artists is not good either.

Had a quick discussion with Brecht. The idea is to make it so that warnings will be generated in the interface when requested settings are overwritten and look into adding warnings-as-error type of a toggle for Cycles (with a goal to avoid CPU time waste on the farms, and possibly covering more than just denoiser/device fallback).

Anyway, this is something which is being discussed.

@Raimund58 The complicated part is that we kind of want .blend files to be easily shareable between artists in a way that they can render them without running into errors, and this is an opposite of what one'd want for the render farms and studios. Additionally, making such changes without any notification to artists is not good either. Had a quick discussion with Brecht. The idea is to make it so that warnings will be generated in the interface when requested settings are overwritten and look into adding warnings-as-error type of a toggle for Cycles (with a goal to avoid CPU time waste on the farms, and possibly covering more than just denoiser/device fallback). Anyway, this is something which is being discussed.

Raimund Klink commented

2022-01-28 15:35:24 +01:00

I am looking forward for good solutions/compromises.
You guys are usually quite good in finding those :)

I am looking forward for good solutions/compromises. You guys are usually quite good in finding those :)

Raimund Klink commented

2022-01-28 15:35:38 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cycles/Compositor: The denoiser returns a black image if not all requirements are fulfilled #94127