Top bar and Status bar have hardcoded color offset #94148

New Issue

Ludvik Koutny · 2021-12-16T12:23:02+01:00

Ludvik Koutny commented

2021-12-16 12:23:02 +01:00

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76

Blender Version
Broken: version: 3.0.0, branch: SelectThrough (modified), commit date: 2021-12-15 12:21, hash: 6349dd43b1
Worked: 2.93 and earlier

Short description of error
Blender 3.0 has introduced hardcoded color offset to UI header and footer, making the theme creation and maintenance once again more difficult. The accumulation of these mistakes makes already very difficult theme creation, editing and maintenance even more difficult in newer versions.

These two areas are set to be the exact same hex color:

Yet, when the same gray hex color is used, the colors of the elements are different:

Exact steps for others to reproduce the error

In theme editor, set Top Bar > Theme Space > Header to a dark gray color
In theme editor, set User Interface > Styles > Editor Outline to the exact same dark gray color
Result: The colors displayed in the UI are not matching despite being set to same color
Expected: The colors are identical

**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76 **Blender Version** Broken: version: 3.0.0, branch: SelectThrough (modified), commit date: 2021-12-15 12:21, hash: `6349dd43b1` Worked: 2.93 and earlier **Short description of error** Blender 3.0 has introduced hardcoded color offset to UI header and footer, making the theme creation and maintenance once again more difficult. The accumulation of these mistakes makes already very difficult theme creation, editing and maintenance even more difficult in newer versions. These two areas are set to be the exact same hex color: ![image.png](https://archive.blender.org/developer/F12753128/image.png) Yet, when the same gray hex color is used, the colors of the elements are different: ![image.png](https://archive.blender.org/developer/F12753130/image.png) **Exact steps for others to reproduce the error** 1. In theme editor, set Top Bar > Theme Space > Header to a dark gray color 2. In theme editor, set User Interface > Styles > Editor Outline to the exact same dark gray color Result: The colors displayed in the UI are not matching despite being set to same color Expected: The colors are identical

Yevgeny Makarov commented

2021-12-17 16:15:11 +01:00

It is set to use the "active" style for the status and top bar.

I would say it is a mistake in e89fefdc69.

lang=c
static ThemeColorID region_background_color_id(const bContext *C, const ARegion *region)
{
  ScrArea *area = CTX_wm_area(C);

  switch (region->regiontype) {
    case RGN_TYPE_HEADER:
    case RGN_TYPE_TOOL_HEADER:
      if (ED_screen_area_active(C) || ED_area_is_global(area)) {
        return TH_HEADER_ACTIVE;
      }
      else {
        return TH_HEADER;
      }
    case RGN_TYPE_PREVIEW:
      return TH_PREVIEW_BACK;
    default:
      return TH_BACK;
  }
}

It is set to use the "active" style for the status and top bar. I would say it is a mistake in e89fefdc69. ``` lang=c static ThemeColorID region_background_color_id(const bContext *C, const ARegion *region) { ScrArea *area = CTX_wm_area(C); switch (region->regiontype) { case RGN_TYPE_HEADER: case RGN_TYPE_TOOL_HEADER: if (ED_screen_area_active(C) || ED_area_is_global(area)) { return TH_HEADER_ACTIVE; } else { return TH_HEADER; } case RGN_TYPE_PREVIEW: return TH_PREVIEW_BACK; default: return TH_BACK; } } ```

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Top bar and Status bar have hardcoded color offset #94148