Node editor group background color can not be specified in 3.0 #94153

New Issue

Ludvik Koutny · 2021-12-16T14:06:59+01:00

Ludvik Koutny commented

2021-12-16 14:06:59 +01:00

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76

Blender Version
Broken: version: 3.0.0, branch: SelectThrough (modified), commit date: 2021-12-15 12:21, hash: 6349dd43b1
Worked: 2.93 and earlier

This changed in 919e513fa8

Short description of error
Blender 3.0 has hardcoded modification of node editor background color when inside the node group. This makes it impossible for users to create aesthetically pleasing themes. For example, here is a minimalistic color setup intended to minimize the clutter:

But entering the node group introduces ugly seams in the theme style:

Exact steps for others to reproduce the error

Go to Theme Editor and adjust the Node Editor theme so that the Window Background color matches the Header color and the Region Background color
In node editor, create a node group and enter it
Attempt to fix the color discrepancy between the Node Editor background and surrounding UI elements
Result: The node editor group background has hardcoded color modification, making it impossible for users to specify theme aesthetic.
Expected: The node editor group background color modification is not hardcoded, and can be changed.

**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76 **Blender Version** Broken: version: 3.0.0, branch: SelectThrough (modified), commit date: 2021-12-15 12:21, hash: `6349dd43b1` Worked: 2.93 and earlier This changed in 919e513fa8 **Short description of error** Blender 3.0 has hardcoded modification of node editor background color when inside the node group. This makes it impossible for users to create aesthetically pleasing themes. For example, here is a minimalistic color setup intended to minimize the clutter: ![image.png](https://archive.blender.org/developer/F12753280/image.png) But entering the node group introduces ugly seams in the theme style: ![image.png](https://archive.blender.org/developer/F12753282/image.png) **Exact steps for others to reproduce the error** 1. Go to Theme Editor and adjust the Node Editor theme so that the Window Background color matches the Header color and the Region Background color 2. In node editor, create a node group and enter it 3. Attempt to fix the color discrepancy between the Node Editor background and surrounding UI elements Result: The node editor group background has hardcoded color modification, making it impossible for users to specify theme aesthetic. Expected: The node editor group background color modification is not hardcoded, and can be changed.

Ludvik Koutny commented

2021-12-16 14:06:59 +01:00

Added subscriber: @Rawalanche

Pratik Borhade commented

2021-12-17 12:37:08 +01:00

Added subscriber: @PratikPB2123

Dalai Felinto commented

2021-12-17 16:57:15 +01:00

Added subscriber: @dfelinto

Dalai Felinto commented

2021-12-17 16:57:15 +01:00

You are not supposed to be able to change the specific background of when you are inside a node group. This is by design a dimmed version of the background of the editor (which gets brighter the more inside a group you are).

Now, the actual issue here is that the Region Background for the Nodes Editor has an alpha channel is is not used. The alpha should either be removed from there or we should support full "Regions Overlap" in the node editor, the same way we do for the viewport.

Not sure if this is something the #user_interface team is interested on looking at. I'm sure we must have the same issue in plenty of other editors.

You are not supposed to be able to change the specific background of when you are inside a node group. This is by design a dimmed version of the background of the editor (which gets brighter the more inside a group you are). Now, the actual issue here is that the Region Background for the Nodes Editor has an alpha channel is is not used. The alpha should either be removed from there or we should support full "Regions Overlap" in the node editor, the same way we do for the viewport. Not sure if this is something the #user_interface team is interested on looking at. I'm sure we must have the same issue in plenty of other editors.

Ludvik Koutny commented

2021-12-17 18:10:48 +01:00

In #94153#1274678, @dfelinto wrote:
You are not supposed to be able to change the specific background of when you are inside a node group. This is by design a dimmed version of the background of the editor (which gets brighter the more inside a group you are).

Now, the actual issue here is that the Region Background for the Nodes Editor has an alpha channel is is not used. The alpha should either be removed from there or we should support full "Regions Overlap" in the node editor, the same way we do for the viewport.

Not sure if this is something the #user_interface team is interested on looking at. I'm sure we must have the same issue in plenty of other editors.

While this would solve the seam between the editor background and sidebar, it would not solve the seam between editor background and header. Either inside node group, or outside of it, there would be seam. If Blender allows users to color editor background and header separately, it should be up to the creator of the theme to decide if they want header to be separate color or not.

I don't understand why should we not be able to change background of a node editor inside a node group when the amount of theme customization Blender offers sits on the border of sanity. On the one hand, you trust the user to not set the text color to be the same as background color, rendering the software unusable, but at the same time, you don't trust the users to pick whether they want to be the node group background explicitly visualized? (Especially when there are other means of indication, such as the breadcrumbs on the top left). That just makes no sense.

There is unnecessary amount of granularity when it comes to theme customization in Blender, yet on the places where it actually matters, we are getting more and more hardcoded color modifiers.

> In #94153#1274678, @dfelinto wrote: > You are not supposed to be able to change the specific background of when you are inside a node group. This is by design a dimmed version of the background of the editor (which gets brighter the more inside a group you are). > > Now, the actual issue here is that the Region Background for the Nodes Editor has an alpha channel is is not used. The alpha should either be removed from there or we should support full "Regions Overlap" in the node editor, the same way we do for the viewport. > > Not sure if this is something the #user_interface team is interested on looking at. I'm sure we must have the same issue in plenty of other editors. While this would solve the seam between the editor background and sidebar, it would not solve the seam between editor background and header. Either inside node group, or outside of it, there would be seam. If Blender allows users to color editor background and header separately, it should be up to the creator of the theme to decide if they want header to be separate color or not. I don't understand why should we not be able to change background of a node editor inside a node group when the amount of theme customization Blender offers sits on the border of sanity. On the one hand, you trust the user to not set the text color to be the same as background color, rendering the software unusable, but at the same time, you don't trust the users to pick whether they want to be the node group background explicitly visualized? (Especially when there are other means of indication, such as the breadcrumbs on the top left). That just makes no sense. There is unnecessary amount of granularity when it comes to theme customization in Blender, yet on the places where it actually matters, we are getting more and more hardcoded color modifiers.

Dan Ryba commented

2022-01-13 18:23:45 +01:00

Added subscriber: @drthunder

Dan Ryba commented

2022-01-13 18:23:45 +01:00

I agree that background color is very helpful within a nested node group. It's a quicker visual aid than having to reference the bread crumbs. I didn't even realize the background was getting brighter deeper levels in because it's so subtle right now. I really like the idea of brightening per level, but it would be enhanced by being able to control the amount per, and especially by adding color/tint.

Richard Antalik commented

2022-02-02 04:54:37 +01:00

Added subscribers: @HooglyBoogly, @JulianEisel, @iss

Richard Antalik commented

2022-02-02 04:54:37 +01:00

I can say that for example in sequencer, there are quite a lot instances of hardcoded colors or custom shading based on theme colors, so this practice is not unheared of. Also region overlap sounds like a better solution than tweaking background color. It's quite hard to consider this to be a regression, but also don't want to close right away.

I was looking for code author to make final decision, but it was Dalai... I will poke UI devs again, and will check later if there is any feedback, so this could be classified as known issue/TODO. Otherwise will close report and advise to discuss such matters elsewhere.

@HooglyBoogly and @JulianEisel, do you think this should be addressed in future?

I can say that for example in sequencer, there are quite a lot instances of hardcoded colors or custom shading based on theme colors, so this practice is not unheared of. Also region overlap sounds like a better solution than tweaking background color. It's quite hard to consider this to be a regression, but also don't want to close right away. I was looking for code author to make final decision, but it was Dalai... I will poke UI devs again, and will check later if there is any feedback, so this could be classified as known issue/TODO. Otherwise will close report and advise to discuss such matters elsewhere. @HooglyBoogly and @JulianEisel, do you think this should be addressed in future?

Richard Antalik commented

2022-02-02 04:55:26 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Hans Goudey commented

2022-02-02 23:13:33 +01:00

If someone created a patch for adjusting the color that fades in when you go into a node group, personally I would accept it. Not sure if Dalai agrees with that though.

Region overlap would be nice for the node editor, but I don't think it's really the issue here. The issue is that a color that used to be changeable by themes now isn't, which is sort of the opposite direction we want to be heading.

If someone created a patch for adjusting the color that fades in when you go into a node group, personally I would accept it. Not sure if Dalai agrees with that though. --- Region overlap would be nice for the node editor, but I don't think it's really the issue here. The issue is that a color that used to be changeable by themes now isn't, which is sort of the opposite direction we want to be heading.

Dalai Felinto commented

2022-02-03 10:19:14 +01:00

@HooglyBoogly I will get behind whatever decision the UI team can propose. I actually wouldn't mind to hear from other UI members if I"m being obtuse or not here. But I stand to what I said in my previous reply.

Philipp Oeser commented

2022-02-03 10:23:58 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-02-03 10:23:58 +01:00

In #94153#1299830, @iss wrote:
I was looking for code author to make final decision, but it was Dalai...

I think it is always helpful to post which commit changed/broke behavior in the task description. Which commit was it?

> In #94153#1299830, @iss wrote: > I was looking for code author to make final decision, but it was Dalai... I think it is always helpful to post which commit changed/broke behavior in the task description. Which commit was it?

Pratik Borhade commented

2022-02-03 10:39:47 +01:00

I think it is always helpful to post which commit changed/broke behavior in the task description. Which commit was it?

You mean code that removed color background?: 919e513fa8

edit: follow up change to make background brighter- ebe2374528

> I think it is always helpful to post which commit changed/broke behavior in the task description. Which commit was it? You mean code that removed color background?: 919e513fa8 edit: follow up change to make background brighter- ebe2374528

Pratik Borhade commented

2022-12-06 05:30:33 +01:00

In #94153#1300836, @dfelinto wrote:
@HooglyBoogly I will get behind whatever decision the UI team can propose. I actually wouldn't mind to hear from other UI members if I"m being obtuse or not here. But I stand to what I said in my previous reply.

Hi, any updated here?
Is #user_interface / #nodes_physics team still considering this improvement? Otherwise we can close this ticket.

> In #94153#1300836, @dfelinto wrote: > @HooglyBoogly I will get behind whatever decision the UI team can propose. I actually wouldn't mind to hear from other UI members if I"m being obtuse or not here. But I stand to what I said in my previous reply. Hi, any updated here? Is #user_interface / #nodes_physics team still considering this improvement? Otherwise we can close this ticket.

Dalai Felinto commented

2022-12-06 09:35:39 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Archived'

Dalai Felinto closed this issue

2022-12-06 09:35:39 +01:00

Dalai Felinto commented

2022-12-06 09:35:39 +01:00

Thanks for the poke Pratik.

I will go ahead and close this since it is working as intended. If the #user_interface wants to support region overlap it can be done as a TODO (not tied to a bug report anyways). But as Hans said, it is not the issue directly reported here.

Thanks for the report @Rawalanche .

Thanks for the poke Pratik. I will go ahead and close this since it is working as intended. If the #user_interface wants to support region overlap it can be done as a TODO (not tied to a bug report anyways). But as Hans said, it is not the issue directly reported here. Thanks for the report @Rawalanche .

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Node editor group background color can not be specified in 3.0 #94153