Geometry nodes: Split edges node leads to a crash in edit mode #94495

New Issue

Yegor · 2021-12-30T12:03:54+01:00

Yegor commented

2021-12-30 12:03:54 +01:00

System Information
Operating system: Linux-5.4.0-91-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.91.03

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2021-12-25 21:08, hash: dd3a72f275, 3.0
Worked: (newest version of Blender that worked as expected)

Short description of error
Adding a split edge node and going in edit mode when all modifier flags (except Render) are selected will result crash.
2021-12-30_13-56-06.mp4

Exact steps for others to reproduce the error
Go into edit mode
geonodes_split_edit_mode_crash.blend

**System Information** Operating system: Linux-5.4.0-91-generic-x86_64-with-glibc2.31 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.91.03 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master, commit date: 2021-12-25 21:08, hash: `dd3a72f275`, 3.0 Worked: (newest version of Blender that worked as expected) **Short description of error** Adding a split edge node and going in edit mode when all modifier flags (except `Render`) are selected will result crash. [2021-12-30_13-56-06.mp4](https://archive.blender.org/developer/F12781736/2021-12-30_13-56-06.mp4) **Exact steps for others to reproduce the error** Go into edit mode [geonodes_split_edit_mode_crash.blend](https://archive.blender.org/developer/F12781737/geonodes_split_edit_mode_crash.blend)

Yegor commented

2021-12-30 12:03:54 +01:00

Added subscriber: @YegorSmirnov

Pratik Borhade commented

2021-12-30 12:17:00 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2021-12-30 12:23:46 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2021-12-30 12:23:46 +01:00

Hi, Thanks for the report. I can reproduce crash on current master.

blender.exe         :0x00007FF66BD37450  blender::draw::extract_edit_data_iter_poly_mesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\mesh_extractors\extract_mesh_vbo_edit_data.cc:179
blender.exe         :0x00007FF66BCE79E0  blender::draw::extract_range_iter_poly_mesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache_extract_mesh.cc:326
blender.exe         :0x00007FF66C5DB1C0  BLI_task_parallel_range C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_range.cc:139
blender.exe         :0x00007FF66BCE7B80  blender::draw::extract_task_range_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache_extract_mesh.cc:461
blender.exe         :0x00007FF66C604110  TaskNode::run_serial C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_graph.cc:102
blender.exe         :0x00007FF66C604310  BLI_task_graph_node_push_work C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_graph.cc:149
blender.exe         :0x00007FF66BCE82A0  blender::draw::mesh_buffer_cache_create_requested C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache_extract_mesh.cc:759
blender.exe         :0x00007FF66BCD2F50  DRW_mesh_batch_cache_create_requested C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache_impl_mesh.c:2093
blender.exe         :0x00007FF66BCC21F0  drw_batch_cache_generate_requested C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache.c:3455
blender.exe         :0x00007FF66BCAF5A0  drw_engines_cache_populate C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_manager.c:1096
blender.exe         :0x00007FF66BCABD70  DRW_draw_render_loop_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_manager.c:1689
blender.exe         :0x00007FF66BCACE20  DRW_draw_view C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_manager.c:1611
blender.exe         :0x00007FF66C2FAE60  view3d_main_region_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\space_view3d\view3d_draw.c:1584
blender.exe         :0x00007FF66B8B8C40  ED_region_do_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\screen\area.c:563
blender.exe         :0x00007FF66B89F0C0  wm_draw_window_offscreen C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:732
blender.exe         :0x00007FF66B89EF10  wm_draw_window C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:884
blender.exe         :0x00007FF66B89EA50  wm_draw_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:1083
blender.exe         :0x00007FF66B879800  WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:646
blender.exe         :0x00007FF66B874FF0  main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:566
blender.exe         :0x00007FF66C6A2DF8  __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
KERNEL32.DLL        :0x00007FFD99647020  BaseThreadInitThunk
ntdll.dll           :0x00007FFD99B42630  RtlUserThreadStart```

Hi, Thanks for the report. I can reproduce crash on current master. ```lines=10 blender.exe :0x00007FF66BD37450 blender::draw::extract_edit_data_iter_poly_mesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\mesh_extractors\extract_mesh_vbo_edit_data.cc:179 blender.exe :0x00007FF66BCE79E0 blender::draw::extract_range_iter_poly_mesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache_extract_mesh.cc:326 blender.exe :0x00007FF66C5DB1C0 BLI_task_parallel_range C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_range.cc:139 blender.exe :0x00007FF66BCE7B80 blender::draw::extract_task_range_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache_extract_mesh.cc:461 blender.exe :0x00007FF66C604110 TaskNode::run_serial C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_graph.cc:102 blender.exe :0x00007FF66C604310 BLI_task_graph_node_push_work C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_graph.cc:149 blender.exe :0x00007FF66BCE82A0 blender::draw::mesh_buffer_cache_create_requested C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache_extract_mesh.cc:759 blender.exe :0x00007FF66BCD2F50 DRW_mesh_batch_cache_create_requested C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache_impl_mesh.c:2093 blender.exe :0x00007FF66BCC21F0 drw_batch_cache_generate_requested C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_cache.c:3455 blender.exe :0x00007FF66BCAF5A0 drw_engines_cache_populate C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_manager.c:1096 blender.exe :0x00007FF66BCABD70 DRW_draw_render_loop_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_manager.c:1689 blender.exe :0x00007FF66BCACE20 DRW_draw_view C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\draw\intern\draw_manager.c:1611 blender.exe :0x00007FF66C2FAE60 view3d_main_region_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\space_view3d\view3d_draw.c:1584 blender.exe :0x00007FF66B8B8C40 ED_region_do_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\screen\area.c:563 blender.exe :0x00007FF66B89F0C0 wm_draw_window_offscreen C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:732 blender.exe :0x00007FF66B89EF10 wm_draw_window C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:884 blender.exe :0x00007FF66B89EA50 wm_draw_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:1083 blender.exe :0x00007FF66B879800 WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:646 blender.exe :0x00007FF66B874FF0 main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:566 blender.exe :0x00007FF66C6A2DF8 __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 KERNEL32.DLL :0x00007FFD99647020 BaseThreadInitThunk ntdll.dll :0x00007FFD99B42630 RtlUserThreadStart```

Pratik Borhade changed title from ~~[Geometry nodes] Split edges node leads to a crash in edit mode~~ to Geometry nodes: Split edges node leads to a crash in edit mode

2021-12-30 12:24:00 +01:00

Fen commented

2021-12-30 15:19:37 +01:00

Added subscriber: @chemicalcrux

Fen commented

2021-12-30 15:19:37 +01:00

Can replicate on MacOS too. The similar "Edge Split" node in 2.93 does not cause a crash.

Here's the assert failure from a developer build on e0d1e66732: P2689

Can replicate on MacOS too. The similar "Edge Split" node in 2.93 does not cause a crash. Here's the assert failure from a developer build on e0d1e66732: [P2689](https://archive.blender.org/developer/P2689.txt)

Philipp Oeser commented

2021-12-31 13:24:53 +01:00

Added subscribers: @HooglyBoogly, @lichtwerk

Philipp Oeser self-assigned this 2021-12-31 13:24:53 +01:00

Philipp Oeser commented

2021-12-31 13:24:53 +01:00

Seems like this is not the only geo node that does not handle ORIGINDEX well (but apparently the only one that crashes).
This either leads to crashes (like in this report), or in other cases selection goes terribly wrong.
(got the feeling that editmode is not the radar often in geonode development @HooglyBoogly ?)

Think I got a fix, will post shortly.

Seems like this is not the only geo node that does not handle `ORIGINDEX` well (but apparently the only one that crashes). This either leads to crashes (like in this report), or in other cases selection goes terribly wrong. (got the feeling that editmode is not the radar often in geonode development @HooglyBoogly ?) Think I got a fix, will post shortly.

Philipp Oeser removed their assignment 2022-01-18 21:05:00 +01:00

Philipp Oeser commented

2022-01-18 21:05:00 +01:00

Will have to concentrate on triaging for a while (and step down).

Hans Goudey self-assigned this 2022-02-07 06:51:05 +01:00

blender-admin commented

2022-02-18 17:34:00 +01:00

This issue was referenced by 82c3bef765

This issue was referenced by 82c3bef7655bb115f739842b815a2ee1c40a9320

Hans Goudey commented

2022-02-18 17:34:20 +01:00

Changed status from 'Confirmed' to: 'Resolved'