Removing an image used for camera background from python console crashes blender #94544

Closed
opened 2022-01-01 12:37:02 +01:00 by takaaki takeda · 10 comments

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: f1cca30557
Worked: 2.79

Short description of error
Removing an image used for camera background from python console crashes blender.

Exact steps for others to reproduce the error
Make an image and use it as camera background.
Then try remove image date from python console, like

bpy.data.images.remove(bpy.data.images['SomeImage'])

Then, blender crashes.
If image is not used for camera, the image would be removed without any trouble.

LayoutImage.blend

I atached .blend file with image setup and python command.
Press enter in python console panel and blender would crash.

**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86 **Blender Version** Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: `f1cca30557` Worked: 2.79 **Short description of error** Removing an image used for camera background from python console crashes blender. **Exact steps for others to reproduce the error** Make an image and use it as camera background. Then try remove image date from python console, like bpy.data.images.remove(bpy.data.images['SomeImage']) Then, blender crashes. If image is not used for camera, the image would be removed without any trouble. [LayoutImage.blend](https://archive.blender.org/developer/F12784132/LayoutImage.blend) I atached .blend file with image setup and python command. Press enter in python console panel and blender would crash.
Author

Added subscriber: @popqjp

Added subscriber: @popqjp
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Hi, thanks for the report. Can reproduce crash on master.
Probably a regression (works here on a few older builds. I will check)

Stack trace:

blender.exe         :0x00007FF7F67C9460  pyrna_struct_CreatePyObject C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\python\intern\bpy_rna.c:7419
blender.exe         :0x00007FF7F67C7D30  pyrna_prop_to_py C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\python\intern\bpy_rna.c:1443
blender.exe         :0x00007FF7F67C0E70  pyrna_struct_getattro C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\python\intern\bpy_rna.c:4214
python39.dll        :0x00007FFD26C41700  PyEval_EvalFrameDefault
python39.dll        :0x00007FFD26B402C0  PyCFunction_Call
python39.dll        :0x00007FFD26B403D0  PyFunction_Vectorcall
blender.exe         :0x00007FF7F67C43E0  bpy_class_call C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\python\intern\bpy_rna.c:8554
blender.exe         :0x00007FF7F6724F80  panel_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\makesrna\intern\rna_ui.c:145
blender.exe         :0x00007FF7F617BF30  ed_panel_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\screen\area.c:2801
blender.exe         :0x00007FF7F617A2D0  ED_region_panels_layout_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\screen\area.c:2997
blender.exe         :0x00007FF7F6D615B0  buttons_main_region_layout C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\space_buttons\space_buttons.c:515
blender.exe         :0x00007FF7F61790F0  ED_region_do_layout C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\screen\area.c:526
blender.exe         :0x00007FF7F615F0C0  wm_draw_window_offscreen C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:682
blender.exe         :0x00007FF7F615EF10  wm_draw_window C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:884
blender.exe         :0x00007FF7F615EA50  wm_draw_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:1083
blender.exe         :0x00007FF7F6139800  WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:646
blender.exe         :0x00007FF7F6134FF0  main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:566
blender.exe         :0x00007FF7F6F62338  __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
KERNEL32.DLL        :0x00007FFD99647020  BaseThreadInitThunk
ntdll.dll           :0x00007FFD99B42630  RtlUserThreadStart```
Hi, thanks for the report. Can reproduce crash on master. Probably a regression (works here on a few older builds. I will check) Stack trace: ```lines=10 blender.exe :0x00007FF7F67C9460 pyrna_struct_CreatePyObject C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\python\intern\bpy_rna.c:7419 blender.exe :0x00007FF7F67C7D30 pyrna_prop_to_py C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\python\intern\bpy_rna.c:1443 blender.exe :0x00007FF7F67C0E70 pyrna_struct_getattro C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\python\intern\bpy_rna.c:4214 python39.dll :0x00007FFD26C41700 PyEval_EvalFrameDefault python39.dll :0x00007FFD26B402C0 PyCFunction_Call python39.dll :0x00007FFD26B403D0 PyFunction_Vectorcall blender.exe :0x00007FF7F67C43E0 bpy_class_call C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\python\intern\bpy_rna.c:8554 blender.exe :0x00007FF7F6724F80 panel_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\makesrna\intern\rna_ui.c:145 blender.exe :0x00007FF7F617BF30 ed_panel_draw C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\screen\area.c:2801 blender.exe :0x00007FF7F617A2D0 ED_region_panels_layout_ex C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\screen\area.c:2997 blender.exe :0x00007FF7F6D615B0 buttons_main_region_layout C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\space_buttons\space_buttons.c:515 blender.exe :0x00007FF7F61790F0 ED_region_do_layout C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\editors\screen\area.c:526 blender.exe :0x00007FF7F615F0C0 wm_draw_window_offscreen C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:682 blender.exe :0x00007FF7F615EF10 wm_draw_window C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:884 blender.exe :0x00007FF7F615EA50 wm_draw_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_draw.c:1083 blender.exe :0x00007FF7F6139800 WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:646 blender.exe :0x00007FF7F6134FF0 main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:566 blender.exe :0x00007FF7F6F62338 __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 KERNEL32.DLL :0x00007FFD99647020 BaseThreadInitThunk ntdll.dll :0x00007FFD99B42630 RtlUserThreadStart```
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser self-assigned this 2022-01-04 10:19:55 +01:00
Member

Since 2.8, background images are tied to cameras (in 2.79 these were tied to a View3D I think).
Code in BKE_library_id_can_use_idtype wasnt taking this relation between Camera and Image into account, thus leading to libblock_remap_data not doing its thing (and leaving the camera as a user of the image), things went downhill from there...

Think I got a simple fix.

Since 2.8, background images are tied to cameras (in 2.79 these were tied to a View3D I think). Code in `BKE_library_id_can_use_idtype` wasnt taking this relation between `Camera` and `Image` into account, thus leading to `libblock_remap_data` not doing its thing (and leaving the camera as a user of the image), things went downhill from there... Think I got a simple fix.

This issue was referenced by 22ce804c7d

This issue was referenced by 22ce804c7dad335fc53a5c4c90515864f6ae7b68

This issue was referenced by 9bae5988ba

This issue was referenced by 9bae5988ba819065ad715e8e5124179797385db9

This issue was referenced by f7018f7b06

This issue was referenced by f7018f7b06f9283ed8ddc169234ef5a543cbaaf1
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#94544
No description provided.