Compositor: Add Scene Time node #94603

New Issue

Closed

opened 2022-01-03 15:22:22 +01:00 by Jeroen Bakker · 14 comments

Jeroen Bakker commented

2022-01-03 15:22:22 +01:00

Member

Implement a Scene Time node similar to the one of geometry nodes.

Implement a Scene Time node similar to the one of geometry nodes. ![image.png](https://archive.blender.org/developer/F12786796/image.png)

Jeroen Bakker commented

2022-01-03 15:22:22 +01:00

Author

Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2022-01-03 15:22:22 +01:00

Author

Member

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker

Paul Larson commented

2022-01-03 19:45:02 +01:00

Added subscriber: @GeorgiaPacific

Added subscriber: @GeorgiaPacific

Nathan Rozendaal commented

2022-01-05 20:46:36 +01:00

Added subscriber: @super_jo_nathan

Added subscriber: @super_jo_nathan

Nathan Rozendaal commented

2022-01-05 21:04:49 +01:00

I would like to start contributing to Blender and this seems like a great place to start. If I have any questions I'll be sure to let you guys know!

I would like to start contributing to Blender and this seems like a great place to start. If I have any questions I'll be sure to let you guys know!

Jeroen Bakker commented

2022-01-05 23:13:25 +01:00

Author

Member

Great!

Great!

Nathan Rozendaal commented

2022-01-06 12:01:41 +01:00

I've done some looking around and I've been able to build blender and I've found where I should be working in. But I've also found the time node already available in the compositor. If I add the scene time node there will be two very similar nodes. Should the functionality of the scene time node be added into the already existing time node? Because I'm afraid that two similar nodes might cause confusion.

I've done some looking around and I've been able to build blender and I've found where I should be working in. But I've also found the time node already available in the compositor. If I add the scene time node there will be two very similar nodes. Should the functionality of the scene time node be added into the already existing time node? Because I'm afraid that two similar nodes might cause confusion.

Nathan Rozendaal commented

2022-01-06 18:48:40 +01:00

Managed to get it working as a separate node, will check my code and make a commit tomorrow if that's the route we're going with.

Managed to get it working as a separate node, will check my code and make a commit tomorrow if that's the route we're going with.

Aaron Carlisle commented

2022-01-08 03:59:58 +01:00

Member

Added subscriber: @Blendify

Added subscriber: @Blendify

Aaron Carlisle commented

2022-01-08 03:59:58 +01:00

Member

The current time node should be renamed to the "time curve" node and its purpose is to create custom transitions between any set of frames.

So in some sense its not needed if you use keyframes but it is also nice to create simple transitions without needing the animation editors.

The current time node should be renamed to the "time curve" node and its purpose is to create custom transitions between any set of frames. So in some sense its not needed if you use keyframes but it is also nice to create simple transitions without needing the animation editors.

Nathan Rozendaal commented

2022-01-08 08:41:58 +01:00

Sounds like a good idea to me, should this change be made in a new diff or added to the one already up? And should everything in the code base be renamed (class names etc) or just the ui related elements?

Sounds like a good idea to me, should this change be made in a new diff or added to the one already up? And should everything in the code base be renamed (class names etc) or just the ui related elements?

Jeroen Bakker commented

2022-01-10 08:41:57 +01:00

Author

Member

@super_jo_nathan Thanks for your work. Any changes should be done inside the same patch.

@super_jo_nathan Thanks for your work. Any changes should be done inside the same patch.

blender-admin commented

2022-01-12 12:16:41 +01:00

This issue was referenced by b2ccd8546c

This issue was referenced by b2ccd8546c7249a5ce279210d45ddbb5e90cd10d

Jeroen Bakker commented

2022-01-12 12:30:06 +01:00

Author

Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2022-01-12 12:30:06 +01:00

Jeroen Bakker self-assigned this 2022-01-12 12:30:06 +01:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#94603

No description provided.