The ground created by Setup Tracking Scene is no longer marked as a Shadow Catcher #94751

New Issue

George Hawkins · 2022-01-08T19:42:28+01:00

George Hawkins commented

2022-01-08 19:42:28 +01:00

System Information
Operating system: Ubuntu 20.04.3 LTS
Graphics card: GeForce RTX 2060

Blender Version
Broken: 3.0.0, f1cca30557, master, 2021-12-02
Worked: 2.93.7, a5b7f9dc90, master, 2021-12-14

Short description of error

In Blender 2.93, when you pressed Setup Tracking Scene, you got a scene with a cube and a plane and the plane was marked as a shadow catcher.

If you do this in 3.0.0, the plane is no longer automatically marked as a shadow catcher and is visible in renders of your scene.

Exact steps for others to reproduce the error

Open a video clip and solve for the camera motion. Set the renderer to Cycles (as Eevee doesn't support shadow catcher). Press Setup Tracking Scene, select the ground, go to its Object properties, expand the Visibility section and you'll see that Shadow Catcher is not ticked.

In 2.93, it was ticked. If this is a deliberate change then it seems odd - the shadow catcher was what grounded your scene in the video clip - the shadows are what make the scene and the clip feel connected rather than one just floating on the other.

Obviously, one usually creates a far more complex scene than this cube and ground plane but it's a nice start - and while it's easy enough to tick the Shadow Catcher for the ground, it feels like it should be on by default as it was in the past.

It just feels like an unexpected change, and hence a bug, rather than a sensible change in defaults.

Here's a sample .blend file where things are just ready for you to press Setup Tracking Scene.
blender-daily-3.0-frames.blend
You also need the Footage.mp4 file found here.

**System Information** Operating system: Ubuntu 20.04.3 LTS Graphics card: GeForce RTX 2060 **Blender Version** Broken: 3.0.0, f1cca3055776, master, 2021-12-02 Worked: 2.93.7, a5b7f9dc9011, master, 2021-12-14 **Short description of error** In Blender 2.93, when you pressed *Setup Tracking Scene*, you got a scene with a cube and a plane and the plane was marked as a shadow catcher. If you do this in 3.0.0, the plane is no longer automatically marked as a shadow catcher and is visible in renders of your scene. **Exact steps for others to reproduce the error** Open a video clip and solve for the camera motion. Set the renderer to Cycles (as Eevee doesn't support shadow catcher). Press *Setup Tracking Scene*, select the ground, go to its *Object* properties, expand the *Visibility* section and you'll see that *Shadow Catcher* is not ticked. In 2.93, it was ticked. If this is a deliberate change then it seems odd - the shadow catcher was what grounded your scene in the video clip - the shadows are what make the scene and the clip feel connected rather than one just floating on the other. Obviously, one usually creates a far more complex scene than this cube and ground plane but it's a nice start - and while it's easy enough to tick the *Shadow Catcher* for the ground, it feels like it should be on by default as it was in the past. It just feels like an unexpected change, and hence a bug, rather than a sensible change in defaults. Here's a sample `.blend` file where things are just ready for you to press *Setup Tracking Scene*. [blender-daily-3.0-frames.blend](https://archive.blender.org/developer/F12796209/blender-daily-3.0-frames.blend) You also need the `Footage.mp4` file found [here](https://drive.google.com/drive/folders/1WHNNXcz74CZb4kF51ZqYNloraMeQHtJd).

George Hawkins commented

2022-01-08 19:42:28 +01:00

Added subscriber: @GeorgeHawkins

Germano Cavalcante commented

2022-01-11 03:33:39 +01:00

Added subscribers: @brecht, @mano-wii

Germano Cavalcante commented

2022-01-11 03:33:39 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Germano Cavalcante commented

2022-01-11 03:33:39 +01:00

I can confirm the problem.
Looks like it was something missing from ca64bd0aac

This change seems to solve the problem:

diff --git a/release/scripts/startup/bl_operators/clip.py b/release/scripts/startup/bl_operators/clip.py
index 45d1ea98a8a..f0e099244f4 100644
--- a/release/scripts/startup/bl_operators/clip.py
+++ b/release/scripts/startup/bl_operators/clip.py
@@ -949,7 +949,7 @@ class CLIP_OT_setup_tracking_scene(Operator):
             """Make all the newly created and the old objects of a collection """ \
                 """to be properly setup for shadow catch"""
             for ob in collection.objects:
-                ob.cycles.is_shadow_catcher = True
+                ob.is_shadow_catcher = True
                 for child in collection.children:
                     setup_shadow_catcher_objects(child)

CC. @brecht

I can confirm the problem. Looks like it was something missing from ca64bd0aac This change seems to solve the problem: ``` diff --git a/release/scripts/startup/bl_operators/clip.py b/release/scripts/startup/bl_operators/clip.py index 45d1ea98a8a..f0e099244f4 100644 --- a/release/scripts/startup/bl_operators/clip.py +++ b/release/scripts/startup/bl_operators/clip.py @@ -949,7 +949,7 @@ class CLIP_OT_setup_tracking_scene(Operator): """Make all the newly created and the old objects of a collection """ \ """to be properly setup for shadow catch""" for ob in collection.objects: - ob.cycles.is_shadow_catcher = True + ob.is_shadow_catcher = True for child in collection.children: setup_shadow_catcher_objects(child) ``` CC. @brecht

Brecht Van Lommel commented

2022-01-11 21:32:22 +01:00

@mano-wii, looks good to me, feel free to commit.

blender-admin commented

2022-01-11 23:01:53 +01:00

This issue was referenced by ab125f466c

This issue was referenced by ab125f466c975f80cc179f7e7a53e09feb868bfd

Germano Cavalcante commented

2022-01-11 23:03:02 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Germano Cavalcante closed this issue

2022-01-11 23:03:02 +01:00

Germano Cavalcante self-assigned this 2022-01-11 23:03:02 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

The ground created by Setup Tracking Scene is no longer marked as a Shadow Catcher #94751