Drag to add node search prioritizes wrong node type #94815

New Issue

Ludvik Koutny · 2022-01-11T13:41:12+01:00

Ludvik Koutny commented

2022-01-11 13:41:12 +01:00

System Information
Operating system: Windows-10-10.0.19042-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-10 22:45, hash: 922ae55a16
Worked: (newest version of Blender that worked as expected)

Short description of error
When using node socket drag search, the search results prioritize wrong type of the node considering the socket type it was dragged out of. When dragging out a Vector type socket, and searching for "Combine", the search prioritizes Combine RGB node instead of Combine XYZ node, which is more appropriate for the given socket type.

Exact steps for others to reproduce the error

In GN editor, drag out a Vector type input out of any node
Search for "combine"
Result: The highlighted result is Combine RGB node
Expected: The highlighted result is Combine XYZ node

**System Information** Operating system: Windows-10-10.0.19042-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.76 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-10 22:45, hash: `922ae55a16` Worked: (newest version of Blender that worked as expected) **Short description of error** When using node socket drag search, the search results prioritize wrong type of the node considering the socket type it was dragged out of. When dragging out a Vector type socket, and searching for "Combine", the search prioritizes Combine RGB node instead of Combine XYZ node, which is more appropriate for the given socket type. ![image.png](https://archive.blender.org/developer/F12800847/image.png) **Exact steps for others to reproduce the error** 1. In GN editor, drag out a Vector type input out of any node 2. Search for "combine" Result: The highlighted result is Combine RGB node Expected: The highlighted result is Combine XYZ node

Ludvik Koutny commented

2022-01-11 13:41:12 +01:00

Added subscriber: @Rawalanche

Pratik Borhade commented

2022-01-12 11:22:22 +01:00

Added subscriber: @PratikPB2123

Richard Antalik commented

2022-01-18 20:38:50 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2022-01-31 20:37:29 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2022-01-31 20:37:29 +01:00

I think this should work differently, like the expected behavior mentioned in this report. I'll add this as a #good_first_issue, since it's a nice task to get started with.

Hints: Check for uses of gather_link_search_ops, and uses of the weight argument to params.add_item in those functions. The shader math node would be a good place to look at first.

I think this should work differently, like the expected behavior mentioned in this report. I'll add this as a #good_first_issue, since it's a nice task to get started with. Hints: Check for uses of `gather_link_search_ops`, and uses of the weight argument to `params.add_item` in those functions. The shader math node would be a good place to look at first.

Shrey Aggarwal self-assigned this 2022-02-01 14:36:27 +01:00

Shrey Aggarwal commented

2022-02-02 12:29:40 +01:00

So far as I have seen the weight parameter decides the priority of the nodes displayed in the pop-up. But they are not characterized by the socket which is calling them. For eg. If the Vector Socket of any node is dragged out, the pop-up shows all the possible socket connections of all the nodes in no defined manner. In my Opinion it should show all the Vector type sockets first and then all the other sockets. Right now the weights are assigned by :

const int weight = (&socket == main_socket) ? 0 : -1 - i;

which is the same for all the sockets no matter what their type is.

What we can do is we can assign the weights using the "type" of sockets like SOCK_VECTOR, SOCK_FLOAT, etc . We can check if the "type" of socket matches the "type" of calling socket then we assign the weight 0 to them and rest less than 0. For this we need to create a function bool matches_type(const bNodeSocket &socket) in the class SocketDeclaration which will return true if the type of both the socket matches. Something like this:

const int weight = (socket.matches_type(params.other_socket())) ? 0 : -1 - i;

Am I going in the right direction @HooglyBoogly ?

So far as I have seen the weight parameter decides the priority of the nodes displayed in the pop-up. But they are not characterized by the socket which is calling them. For eg. If the Vector Socket of any node is dragged out, the pop-up shows all the possible socket connections of all the nodes in no defined manner. In my Opinion it should show all the Vector type sockets first and then all the other sockets. Right now the weights are assigned by : ``` const int weight = (&socket == main_socket) ? 0 : -1 - i; ``` which is the same for all the sockets no matter what their type is. What we can do is we can assign the weights using the "type" of sockets like SOCK_VECTOR, SOCK_FLOAT, etc . We can check if the "type" of socket matches the "type" of calling socket then we assign the weight 0 to them and rest less than 0. For this we need to create a function `bool matches_type(const bNodeSocket &socket)` in the class `SocketDeclaration` which will return true if the type of both the socket matches. Something like this: ``` const int weight = (socket.matches_type(params.other_socket())) ? 0 : -1 - i; ``` Am I going in the right direction @HooglyBoogly ?

Hans Goudey commented

2022-02-02 23:04:36 +01:00

Hmm, I think it would be simpler to just give the Combine XYZ and Combine RGB nodes special implementations of gather_link_search_ops that accounts for this. No need to generalize it further I don't think.

Hmm, I think it would be simpler to just give the Combine XYZ and Combine RGB nodes special implementations of `gather_link_search_ops` that accounts for this. No need to generalize it further I don't think.

Behe eddine commented

2022-04-18 19:29:11 +02:00

Added subscriber: @BEHE

Behe eddine commented

2022-04-18 19:29:11 +02:00

isn't this already done

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Drag to add node search prioritizes wrong node type #94815