GPU: Add CreateInfo Structs for builtin shaders #95009

New Issue

Jeroen Bakker · 2022-01-18T13:28:26+01:00

Jeroen Bakker commented

2022-01-18 13:28:26 +01:00

Recently the GPU module has a new way of creating shaders (D13360: GPUShaderCreateInfo for interface abstraction). This new way would allow us to cross compile to other (future) GPU backends like vulkan.

This task give an overview of the builtin shaders that still needs to be converted and the proposed way how to do this.
Community members that want to dive into the way how GPU is setup in Blender are welcome to help with the conversion.

Please reach out in the chat to jeroen-bakker or fclem for coordination and help to get started.
Most important would be to compile WITH_GPU_SHADER_BUILDER=On. This will validate the shaders already at compile time for quick turn around times.

More Resources

https://wiki.blender.org/wiki/EEVEE_%26_Viewport/GPU_Module/GLSL_Cross_Compilation Documentation about the cross compilation. (Not complete yet, and in some parts still confusing.)
08d008a508 an example how to convert a shader.

Recently the GPU module has a new way of creating shaders ([D13360: GPUShaderCreateInfo for interface abstraction](https://archive.blender.org/developer/D13360)). This new way would allow us to cross compile to other (future) GPU backends like vulkan. This task give an overview of the builtin shaders that still needs to be converted and the proposed way how to do this. Community members that want to dive into the way how GPU is setup in Blender are welcome to help with the conversion. Please reach out in the chat to jeroen-bakker or fclem for coordination and help to get started. Most important would be to compile `WITH_GPU_SHADER_BUILDER=On`. This will validate the shaders already at compile time for quick turn around times. ## More Resources * https://wiki.blender.org/wiki/EEVEE_%26_Viewport/GPU_Module/GLSL_Cross_Compilation Documentation about the cross compilation. (Not complete yet, and in some parts still confusing.) * 08d008a508 an example how to convert a shader.

Jeroen Bakker commented

2022-01-18 13:28:26 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2022-01-18 13:28:26 +01:00

Added subscriber: @Jeroen-Bakker

Jon Henry M. Faltis 9077149 commented

2022-01-18 19:42:14 +01:00

Added subscriber: @geocentric_wage

Shrey Aggarwal commented

2022-01-19 18:02:31 +01:00

Added subscriber: @SHREY-AGGARWAL

Marie Knudsen commented

2022-01-31 20:13:15 +01:00

Added subscriber: @mariek

Brecht Van Lommel commented

2022-02-28 17:28:17 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2022-02-28 17:28:17 +01:00

Removing this from the 3.1 workboard so it's clear which actual works remains for the release.

Ujwal Kundur commented

2022-03-26 17:10:41 +01:00

Added subscriber: @Ujwal-Kundur

Ujwal Kundur commented

2022-03-26 17:10:41 +01:00

Hi, I'm new here. Should I claim this task before working on it ( to prevent duplicate effort ) or should I claim it after I have a diff?

This may seem like low effort on my part, but I need some help getting started:

In the source/blender/gpu/GPU_shader_shared.h file, what does the following code segment do? Is the function expected to be called multiple times, if so, why a cap of 16?

#define MAX_CALLS 16

struct MultiRectCallData {
  float4 calls_data[MAX_CALLS * 3];
};
BLI_STATIC_ASSERT_ALIGN(struct MultiRectCallData, 16)

Hi, I'm new here. Should I claim this task before working on it ( to prevent duplicate effort ) or should I claim it after I have a diff? This may seem like low effort on my part, but I need some help getting started: - In the source/blender/gpu/GPU_shader_shared.h file, what does the following code segment do? Is the function expected to be called multiple times, if so, why a cap of 16? ``` #define MAX_CALLS 16 struct MultiRectCallData { float4 calls_data[MAX_CALLS * 3]; }; BLI_STATIC_ASSERT_ALIGN(struct MultiRectCallData, 16) ```

Jeroen Bakker commented

2022-03-26 20:36:36 +01:00

@Ujwal-Kundur you can claim the task you want to work on. Note that there is already a patch for one shader I forgot to administrate correctly. Will do that on Monday. D14159: Add CreateInfo for GPU_SHADER_2D_WIDGET_BASE

On the GPU the structs are organized differently than on a CPU. the assert will make sure that it follows the GPU struct sized so CPU memory can be copied directly to the GPU.

@Ujwal-Kundur you can claim the task you want to work on. Note that there is already a patch for one shader I forgot to administrate correctly. Will do that on Monday. [D14159: Add CreateInfo for GPU_SHADER_2D_WIDGET_BASE](https://archive.blender.org/developer/D14159) On the GPU the structs are organized differently than on a CPU. the assert will make sure that it follows the GPU struct sized so CPU memory can be copied directly to the GPU.

Ujwal Kundur commented

2022-03-27 09:59:36 +02:00

@Jeroen-Bakker thanks for the info! I'll take a shot at #95013 (Add CreateInfo for GPU_SHADER_INSTANCE_VARIYING_COLOR_VARIYING_SIZE) for my first patch

Jeroen Bakker commented

2022-06-03 11:22:10 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2022-06-03 11:22:10 +02:00

Jeroen Bakker self-assigned this 2022-06-03 11:22:10 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPU: Add CreateInfo Structs for builtin shaders #95009

More Resources