Add CreateInfo for GPU_SHADER_2D_WIDGET_SHADOW #95012

New Issue

Jeroen Bakker · 2022-01-18T13:30:32+01:00

Jeroen Bakker commented

2022-01-18 13:30:32 +01:00

See parent task for more details.

Vertex buffer
** vflag
PushConstant
** ModelViewProjectionMatrix
Uniform Buffer
** parameters- [x] (but use the aliases inside the shader (recti, rect, radsi, rads, roundCorners)

See parent task for more details. * Vertex buffer ** `vflag` * PushConstant ** `ModelViewProjectionMatrix` * Uniform Buffer ** `parameters- [x]` (but use the aliases inside the shader (`recti`, `rect`, `radsi`, `rads`, `roundCorners`)

Jeroen Bakker commented

2022-01-18 13:30:32 +01:00

Added subscriber: @Jeroen-Bakker

Jeroen Bakker commented

2022-01-18 15:34:18 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Sonny Campbell commented

2022-02-18 15:46:19 +01:00

Added subscriber: @Sonny-Campbell

Sonny Campbell commented

2022-02-18 15:46:19 +01:00

Hey @Jeroen-Bakker, I have a change locally for this task that compiles and runs fine, but I'm not 100% sure what I should be looking for. Where exactly should I be looking for the shadow?

I'd like to set some very obviously weird values to make sure my changes are actually being applied and doing something, and then validate my change results in the expected look.

Hey @Jeroen-Bakker, I have a change locally for this task that compiles and runs fine, but I'm not 100% sure what I should be looking for. Where exactly should I be looking for the shadow? I'd like to set some very obviously weird values to make sure my changes are actually being applied and doing _something_, and then validate my change results in the expected look.

Sonny Campbell commented

2022-02-20 20:26:54 +01:00

So I did some more digging and from what I can tell, the only place GPU_SHADER_2D_WIDGET_SHADOW is used is in ui_draw_dropshadow() in interface_draw.c, however ui_draw_dropshadow() isn't actually called anywhere.

Is this something that we can remove entirely, or is it something that needs to stick around for api reasons?

So I did some more digging and from what I can tell, the only place GPU_SHADER_2D_WIDGET_SHADOW is used is in ui_draw_dropshadow() in interface_draw.c, however ui_draw_dropshadow() isn't actually called anywhere. Is this something that we can remove entirely, or is it something that needs to stick around for api reasons?

Jeroen Bakker commented

2022-02-20 23:07:08 +01:00

Hi thanks for your effort, could be a shader for addon widgets will ask around if someone knows and let you know.

Have you already uploaded the patch?

Hi thanks for your effort, could be a shader for addon widgets will ask around if someone knows and let you know. Have you already uploaded the patch?

Sonny Campbell commented

2022-02-20 23:20:08 +01:00

Happy to help!

I haven't uploaded it yet, but I added the ui_draw_dropshadow() call into another function to get it tested and all seems to be working as expected. I can hold off uploading anything until we have an answer, and grab one of the other CreateInfo tasks in the meantime?

Happy to help! I haven't uploaded it yet, but I added the ui_draw_dropshadow() call into another function to get it tested and all seems to be working as expected. I can hold off uploading anything until we have an answer, and grab one of the other CreateInfo tasks in the meantime?

Jeroen Bakker commented

2022-02-21 07:48:34 +01:00

@Sonny-Campbell if you have a patch it is better to upload it so we can have a look.
Seems that the shader is used by the node editor to draw shaders borders around the nodes.

@Sonny-Campbell if you have a patch it is better to upload it so we can have a look. Seems that the shader is used by the node editor to draw shaders borders around the nodes.

Sanskar Chaubey commented

2022-03-03 16:31:27 +01:00

Added subscriber: @Sanskar-M-Chaubey