Add CreateInfo for GPU_SHADER_(2/3)D_LINE_DASHED_UNIFORM_COLOR #95014

Closed
opened 2022-01-18 13:31:42 +01:00 by Jeroen Bakker · 17 comments
Member

GPU_SHADER_2D_LINE_DASHED_UNIFORM_COLOR

  • Vertex Buffer
    ** pos
  • Uniform buffer
    ** color
    ** viewport_size
    ** dash_width
    ** dash_color
    ** colors_len
    ** colors
  • Push Constant
    ** ModelViewProjectionMatrix

GPU_SHADER_3D_LINE_DASHED_UNIFORM_COLOR

  • Vertex Buffer
    ** pos
  • Uniform buffer
    ** Reuse same buffer as for GPU_SHADER_2D_LINE_DASHED_UNIFORM_COLOR
  • Push Constant
    ** ModelViewProjectionMatrix

NOTE: For the 3d shader a variation for world clipping is needed. ModelMatrix should be send as a push constant.

## GPU_SHADER_2D_LINE_DASHED_UNIFORM_COLOR * Vertex Buffer ** `pos` * Uniform buffer ** `color` ** `viewport_size` ** `dash_width` ** `dash_color` ** `colors_len` ** `colors` * Push Constant ** `ModelViewProjectionMatrix` ## GPU_SHADER_3D_LINE_DASHED_UNIFORM_COLOR * Vertex Buffer ** `pos` * Uniform buffer ** Reuse same buffer as for GPU_SHADER_2D_LINE_DASHED_UNIFORM_COLOR * Push Constant ** `ModelViewProjectionMatrix` NOTE: For the 3d shader a variation for world clipping is needed. ModelMatrix should be send as a push constant.
Author
Member

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker

#95015 was marked as duplicate of this issue

#95015 was marked as duplicate of this issue
Jeroen Bakker changed title from Add CreateInfo for GPU_SHADER_3D_LINE_DASHED_UNIFORM_COLOR to Add CreateInfo for GPU_SHADER_(2/3)D_LINE_DASHED_UNIFORM_COLOR 2022-01-18 14:43:18 +01:00
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @dfelinto

Added subscriber: @dfelinto
Dalai Felinto self-assigned this 2022-01-18 17:04:18 +01:00

I want to at least try to do this one to understand the new system.

I want to at least try to do this one to understand the new system.
Dalai Felinto removed their assignment 2022-01-18 17:44:14 +01:00

On a second thought, let someone else have fun. I thought this was the nodelink shader, but this one is already done :)

On a second thought, let someone else have fun. I thought this was the nodelink shader, but this one is already done :)

Added subscriber: @dikshants

Added subscriber: @dikshants

Hi Jeroen , I have been using blender for 3 years and i really want to to contribute to it , but i am stuck at navigating in code so could you help me in getting started
thanks
regards
dikshant

Hi Jeroen , I have been using blender for 3 years and i really want to to contribute to it , but i am stuck at navigating in code so could you help me in getting started thanks regards dikshant
lokesh self-assigned this 2022-03-10 20:07:29 +01:00
[diff.txt](https://archive.blender.org/developer/F12920253/diff.txt)

Hi Jeroen , above diff contains my progress so far .
How can I test the changes . Is there any tool in blender which I can use to see changes .

Hi Jeroen , above diff contains my progress so far . How can I test the changes . Is there any tool in blender which I can use to see changes .

@Lokesh-Sharma this is used in a parent/child relationship in the viewport.

@Lokesh-Sharma this is used in a parent/child relationship in the viewport.
[2D_3D_dashed_line_create_info.diff](https://archive.blender.org/developer/F12923069/2D_3D_dashed_line_create_info.diff)

Above is diff from master . I tested it on my computer . Seems to work . If I missed something can someone check the diff .

Above is diff from master . I tested it on my computer . Seems to work . If I missed something can someone check the diff .
Author
Member

Hi, can you upload the diff as a patch, this way we can start code review.

Hi, can you upload the diff as a patch, this way we can start code review.
https://developer.blender.org/D14332
Author
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Author
Member

Has been solved by aaab3c8ad4

Has been solved by aaab3c8ad4
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#95014
No description provided.