New object exporter not save as right name #95044

Closed
opened 2022-01-19 09:01:03 +01:00 by yonghao lv · 17 comments

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.84

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-18 22:23, hash: 2e5aecf557
Worked: (newest version of Blender that worked as expected)

Short description of error
export an object call 测试.obj
and it save as 娴嬭瘯.obj
export 中文.obj
return 涓枃.obj

I think it cause by the encoding of the win system(China use gbk on win by default)

Exact steps for others to reproduce the error
use the new c++ obj to export with non-English name

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2080 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 472.84 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-18 22:23, hash: `2e5aecf557` Worked: (newest version of Blender that worked as expected) **Short description of error** export an object call `测试.obj ` and it save as `娴嬭瘯.obj` export `中文.obj` return `涓枃.obj` I think it cause by the encoding of the win system(China use gbk on win by default) **Exact steps for others to reproduce the error** use the new c++ obj to export with non-English name
Author

Added subscriber: @1029910278

Added subscriber: @1029910278
Author

Added subscriber: @howardt

Added subscriber: @howardt
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

I am getting this on linux with the new exporter (displayed in Gnome Files 41.1) -- which sounds about right:
image.png

I am getting this on linux with the new exporter (displayed in Gnome Files 41.1) -- which sounds about right: ![image.png](https://archive.blender.org/developer/F12811213/image.png)

Added subscriber: @deadpin

Added subscriber: @deadpin

Here on Windows (en-us defaults), I'm seeing something that is probably related but different at the same time. It looks like the filepath used in the exporter is fed directly into the fopen api without regard to Window's UTF16 setup.

Trying to export 测试.obj will yield the following for me:
unicode-obj-export.png

Here on Windows (en-us defaults), I'm seeing something that is probably related but different at the same time. It looks like the filepath used in the exporter is fed directly into the `fopen` api without regard to Window's UTF16 setup. Trying to export `测试.obj` will yield the following for me: ![unicode-obj-export.png](https://archive.blender.org/developer/F12811255/unicode-obj-export.png)
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @ankitm

Added subscriber: @ankitm
Member

I'll take this confirmed for now.

CC @ankitm
CC @howardt

I'll take this confirmed for now. CC @ankitm CC @howardt
Member

Added subscriber: @LazyDodo

Added subscriber: @LazyDodo
Member

If someone wants an easy issue, FileHandler's ctor in source\blender\io\wavefront_obj\exporter\obj_export_io.hh needs to call BLI_fopen rather than std::fopen and this should be resolved.

If someone wants an easy issue, `FileHandler`'s ctor in `source\blender\io\wavefront_obj\exporter\obj_export_io.hh` needs to call `BLI_fopen` rather than `std::fopen` and this *should* be resolved.

Added subscriber: @aras_p

Added subscriber: @aras_p

I can take this as an exercise in how to make a codebase change

I can take this as an exercise in how to make a codebase change
Aras Pranckevicius was assigned by Ankit Meel 2022-01-20 09:40:16 +01:00
Member

In #95044#1291536, @aras_p wrote:
I can take this as an exercise in how to make a codebase change

what a nice crossover
context: https:*github.com/aras-p/ClangBuildAnalyzer/issues/79 https:*github.com/z-aki/buildanalyzeronblender

> In #95044#1291536, @aras_p wrote: > I can take this as an exercise in how to make a codebase change what a nice crossover context: https:*github.com/aras-p/ClangBuildAnalyzer/issues/79 https:*github.com/z-aki/buildanalyzeronblender

This issue was referenced by 9350005d8b

This issue was referenced by 9350005d8b56a831f4c592d58fdf190af64efad4
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Member
9350005d8b
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#95044
No description provided.