blender
/
blender
134
398
Fork 580
Code Issues 6.3k Pull Requests 757 Projects 19 Wiki Activity

Debug assert: If the weld modifier merges all verts on the mesh #95169

New Issue
Closed
opened 2022-01-24 07:43:44 +01:00 by Jesse Yurkovich · 8 comments
Jesse Yurkovich commented 2022-01-24 07:43:44 +01:00
Member
Copy Link

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: AMD FirePro W2100 ATI Technologies Inc. 4.5.14831 Core Profile Context FireGL 21.Q2.1 27.20.21026.2006
|
|
Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-23 22:42:49, hash: 95981c9876
Worked: (newest version of Blender that worked as expected)

Short description of error
If all the verts are welded out of existence, then an assert fires from the Weld modifier.

The modifiers test suite will catch this during the "MergeAll" testcase.

Exact steps for others to reproduce the error

  • Use a Debug build (with asserts enabled)
  • Put a Weld modifier on the default cube
  • Change the merge distance to 4m
BLI_assert failed: F:\source\blender-git\blender\source\blender\blenlib\BLI_array.hh:212, operator [](), at 'index < size_'

blender.exe!_BLI_assert_print_backtrace F:\source\blender-git\blender\source\blender\blenlib\intern\BLI_assert.c:50
blender.exe!blender::Array<WeldGroupEdge,4,blender::GuardedAllocator>::operator[] F:\source\blender-git\blender\source\blender\blenlib\BLI_array.hh:212
blender.exe!weld_edge_groups_setup F:\source\blender-git\blender\source\blender\modifiers\intern\MOD_weld.cc:620
blender.exe!weld_mesh_context_create F:\source\blender-git\blender\source\blender\modifiers\intern\MOD_weld.cc:1293
blender.exe!weldModifier_doWeld F:\source\blender-git\blender\source\blender\modifiers\intern\MOD_weld.cc:1687
blender.exe!modifyMesh F:\source\blender-git\blender\source\blender\modifiers\intern\MOD_weld.cc:1879
**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: AMD FirePro W2100 ATI Technologies Inc. 4.5.14831 Core Profile Context FireGL 21.Q2.1 27.20.21026.2006 | | **Blender Version** Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-23 22:42:49, hash: `95981c9876 ` Worked: (newest version of Blender that worked as expected) **Short description of error** If all the verts are welded out of existence, then an assert fires from the Weld modifier. The `modifiers` test suite will catch this during the "MergeAll" testcase. **Exact steps for others to reproduce the error** - Use a Debug build (with asserts enabled) - Put a Weld modifier on the default cube - Change the merge distance to 4m ``` BLI_assert failed: F:\source\blender-git\blender\source\blender\blenlib\BLI_array.hh:212, operator [](), at 'index < size_' blender.exe!_BLI_assert_print_backtrace F:\source\blender-git\blender\source\blender\blenlib\intern\BLI_assert.c:50 blender.exe!blender::Array<WeldGroupEdge,4,blender::GuardedAllocator>::operator[] F:\source\blender-git\blender\source\blender\blenlib\BLI_array.hh:212 blender.exe!weld_edge_groups_setup F:\source\blender-git\blender\source\blender\modifiers\intern\MOD_weld.cc:620 blender.exe!weld_mesh_context_create F:\source\blender-git\blender\source\blender\modifiers\intern\MOD_weld.cc:1293 blender.exe!weldModifier_doWeld F:\source\blender-git\blender\source\blender\modifiers\intern\MOD_weld.cc:1687 blender.exe!modifyMesh F:\source\blender-git\blender\source\blender\modifiers\intern\MOD_weld.cc:1879 ```
Jesse Yurkovich commented 2022-01-24 07:43:44 +01:00
Author
Member
Copy Link

Added subscriber: @deadpin

Added subscriber: @deadpin
Jesse Yurkovich changed title from Debug assert: If the weld modifier merges all verts on the mesh -- to Debug assert: If the weld modifier merges all verts on the mesh 2022-01-24 07:43:56 +01:00
Pratik Borhade commented 2022-01-24 11:39:11 +01:00
Member
Copy Link

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Pratik Borhade commented 2022-01-24 11:39:11 +01:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Pratik Borhade commented 2022-01-24 11:39:11 +01:00
Member
Copy Link

I can confirm

Stack trace:
blender.exe         :0x00007FF7FB748CD0  bli_windows_system_backtrace_stack_thread C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\system_win32.c:233
blender.exe         :0x00007FF7FB747D50  BLI_windows_system_backtrace_stack C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\system_win32.c:320
blender.exe         :0x00007FF7FB747720  BLI_system_backtrace C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\system_win32.c:386
blender.exe         :0x00007FF7FB74C540  _BLI_assert_print_backtrace C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\BLI_assert.c:50
blender.exe         :0x00007FF7F9DFB6E0  blender::Array<WeldGroupEdge,4,blender::GuardedAllocator>::operator[] C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\BLI_array.hh:212
blender.exe         :0x00007FF7F9E03F00  weld_edge_groups_setup C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_weld.cc:617
blender.exe         :0x00007FF7F9E04CD0  weld_mesh_context_create C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_weld.cc:1303
blender.exe         :0x00007FF7F9E00840  weldModifier_doWeld C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_weld.cc:1691
blender.exe         :0x00007FF7F9DF63D0  modifyMesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_weld.cc:1881
blender.exe         :0x00007FF7F907B750  BKE_modifier_modify_mesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\modifier.c:999
blender.exe         :0x00007FF7F944B830  modifier_modify_mesh_and_geometry_set C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\DerivedMesh.cc:875
blender.exe         :0x00007FF7F9449450  mesh_calc_modifiers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1224
blender.exe         :0x00007FF7F9448BA0  mesh_build_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1866
blender.exe         :0x00007FF7F9450320  makeDerivedMesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1996
blender.exe         :0x00007FF7F949B8F0  BKE_object_handle_data_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\object_update.c:196
blender.exe         :0x00007FF7F949B720  BKE_object_eval_uber_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\object_update.c:393
blender.exe         :0x00007FF7F9B24670  <lambda_dfec21a1fb9cbd0068712bf807655c50>::operator() C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\builder\deg_builder_nodes.cc:1503
blender.exe         :0x00007FF7F9B1E290  std::invoke<<lambda_dfec21a1fb9cbd0068712bf807655c50> &,Depsgraph *> C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\type_traits:1615
blender.exe         :0x00007FF7F9B160B0  std::_Invoker_ret<void,1>::_Call<<lambda_dfec21a1fb9cbd0068712bf807655c50> &,Depsgraph *> C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\functional:745
blender.exe         :0x00007FF7F9B28910  std::_Func_impl_no_alloc<<lambda_dfec21a1fb9cbd0068712bf807655c50>,void,Depsgraph *>::_Do_call C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\functional:939
blender.exe         :0x00007FF7F9AE4660  std::_Func_class<void,Depsgraph *>::operator() C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\functional:987
blender.exe         :0x00007FF7F9AE5130  blender::deg::`anonymous namespace'::evaluate_node C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:120
blender.exe         :0x00007FF7F9AE4E90  blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:132
blender.exe         :0x00007FF7FB804290  Task::operator() C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:179
blender.exe         :0x00007FF7FB804C20  tbb_task_pool_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:229
blender.exe         :0x00007FF7FB805360  BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:486
blender.exe         :0x00007FF7F9AE57A0  blender::deg::`anonymous namespace'::schedule_node_to_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:79
blender.exe         :0x00007FF7F9AE4170  blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:281
blender.exe         :0x00007FF7F9AE3BD0  blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298
blender.exe         :0x00007FF7F9AE4170  blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:275
blender.exe         :0x00007FF7F9AE3BD0  blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298
blender.exe         :0x00007FF7F9AE4170  blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:275
blender.exe         :0x00007FF7F9AE3BD0  blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298
blender.exe         :0x00007FF7F9AE4E90  blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:133
blender.exe         :0x00007FF7FB804290  Task::operator() C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:179
blender.exe         :0x00007FF7FB804C20  tbb_task_pool_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:229
blender.exe         :0x00007FF7FB805360  BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:486
blender.exe         :0x00007FF7F9AE57A0  blender::deg::`anonymous namespace'::schedule_node_to_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:79
blender.exe         :0x00007FF7F9AE4170  blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:281
blender.exe         :0x00007FF7F9AE3BD0  blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298
blender.exe         :0x00007FF7F9AE4170  blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:275
blender.exe         :0x00007FF7F9AE3BD0  blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298
blender.exe         :0x00007FF7F9AE4E90  blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:133
blender.exe         :0x00007FF7FB804290  Task::operator() C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:179
blender.exe         :0x00007FF7FB804C20  tbb_task_pool_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:229
blender.exe         :0x00007FF7FB804D10  tbb_task_pool_work_and_wait C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:241
blender.exe         :0x00007FF7FB805570  BLI_task_pool_work_and_wait C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:501
blender.exe         :0x00007FF7F9AE4BD0  blender::deg::deg_evaluate_on_refresh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:401
blender.exe         :0x00007FF7F9A8A040  deg_flush_updates_and_refresh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\depsgraph_eval.cc:61
blender.exe         :0x00007FF7F9A8A1D0  DEG_evaluate_on_refresh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\depsgraph_eval.cc:77
blender.exe         :0x00007FF7F91157D0  scene_graph_update_tagged C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\scene.c:2584
blender.exe         :0x00007FF7F910E200  BKE_scene_graph_update_tagged C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\scene.c:2632
blender.exe         :0x00007FF7F8F3BE70  wm_event_do_depsgraph C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:385
blender.exe         :0x00007FF7F8F3DF00  wm_event_do_refresh_wm_and_depsgraph C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:408
blender.exe         :0x00007FF7F8F3D360  wm_event_do_notifiers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:619
blender.exe         :0x00007FF7F8F0F500  WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:645
blender.exe         :0x00007FF7F8F068B0  main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:564
blender.exe         :0x00007FF7FBAA00A0  invoke_main d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79
blender.exe         :0x00007FF7FBA9FE50  __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
blender.exe         :0x00007FF7FBA9FE30  __scrt_common_main d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331
blender.exe         :0x00007FF7FBAA0160  mainCRTStartup d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17
KERNEL32.DLL        :0x00007FFF0BF37020  BaseThreadInitThunk
ntdll.dll           :0x00007FFF0C682630  RtlUserThreadStart```
I can confirm ```lines=10 Stack trace: blender.exe :0x00007FF7FB748CD0 bli_windows_system_backtrace_stack_thread C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\system_win32.c:233 blender.exe :0x00007FF7FB747D50 BLI_windows_system_backtrace_stack C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\system_win32.c:320 blender.exe :0x00007FF7FB747720 BLI_system_backtrace C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\system_win32.c:386 blender.exe :0x00007FF7FB74C540 _BLI_assert_print_backtrace C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\BLI_assert.c:50 blender.exe :0x00007FF7F9DFB6E0 blender::Array<WeldGroupEdge,4,blender::GuardedAllocator>::operator[] C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\BLI_array.hh:212 blender.exe :0x00007FF7F9E03F00 weld_edge_groups_setup C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_weld.cc:617 blender.exe :0x00007FF7F9E04CD0 weld_mesh_context_create C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_weld.cc:1303 blender.exe :0x00007FF7F9E00840 weldModifier_doWeld C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_weld.cc:1691 blender.exe :0x00007FF7F9DF63D0 modifyMesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\modifiers\intern\MOD_weld.cc:1881 blender.exe :0x00007FF7F907B750 BKE_modifier_modify_mesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\modifier.c:999 blender.exe :0x00007FF7F944B830 modifier_modify_mesh_and_geometry_set C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\DerivedMesh.cc:875 blender.exe :0x00007FF7F9449450 mesh_calc_modifiers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1224 blender.exe :0x00007FF7F9448BA0 mesh_build_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1866 blender.exe :0x00007FF7F9450320 makeDerivedMesh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\DerivedMesh.cc:1996 blender.exe :0x00007FF7F949B8F0 BKE_object_handle_data_update C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\object_update.c:196 blender.exe :0x00007FF7F949B720 BKE_object_eval_uber_data C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\object_update.c:393 blender.exe :0x00007FF7F9B24670 <lambda_dfec21a1fb9cbd0068712bf807655c50>::operator() C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\builder\deg_builder_nodes.cc:1503 blender.exe :0x00007FF7F9B1E290 std::invoke<<lambda_dfec21a1fb9cbd0068712bf807655c50> &,Depsgraph *> C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\type_traits:1615 blender.exe :0x00007FF7F9B160B0 std::_Invoker_ret<void,1>::_Call<<lambda_dfec21a1fb9cbd0068712bf807655c50> &,Depsgraph *> C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\functional:745 blender.exe :0x00007FF7F9B28910 std::_Func_impl_no_alloc<<lambda_dfec21a1fb9cbd0068712bf807655c50>,void,Depsgraph *>::_Do_call C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\functional:939 blender.exe :0x00007FF7F9AE4660 std::_Func_class<void,Depsgraph *>::operator() C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29910\include\functional:987 blender.exe :0x00007FF7F9AE5130 blender::deg::`anonymous namespace'::evaluate_node C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:120 blender.exe :0x00007FF7F9AE4E90 blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:132 blender.exe :0x00007FF7FB804290 Task::operator() C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:179 blender.exe :0x00007FF7FB804C20 tbb_task_pool_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:229 blender.exe :0x00007FF7FB805360 BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:486 blender.exe :0x00007FF7F9AE57A0 blender::deg::`anonymous namespace'::schedule_node_to_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:79 blender.exe :0x00007FF7F9AE4170 blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:281 blender.exe :0x00007FF7F9AE3BD0 blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298 blender.exe :0x00007FF7F9AE4170 blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:275 blender.exe :0x00007FF7F9AE3BD0 blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298 blender.exe :0x00007FF7F9AE4170 blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:275 blender.exe :0x00007FF7F9AE3BD0 blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298 blender.exe :0x00007FF7F9AE4E90 blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:133 blender.exe :0x00007FF7FB804290 Task::operator() C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:179 blender.exe :0x00007FF7FB804C20 tbb_task_pool_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:229 blender.exe :0x00007FF7FB805360 BLI_task_pool_push C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:486 blender.exe :0x00007FF7F9AE57A0 blender::deg::`anonymous namespace'::schedule_node_to_pool C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:79 blender.exe :0x00007FF7F9AE4170 blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:281 blender.exe :0x00007FF7F9AE3BD0 blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298 blender.exe :0x00007FF7F9AE4170 blender::deg::`anonymous namespace'::schedule_node<void __cdecl(blender::deg::OperationNode *,int,T C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:275 blender.exe :0x00007FF7F9AE3BD0 blender::deg::`anonymous namespace'::schedule_children<void __cdecl(blender::deg::OperationNode *,i C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:298 blender.exe :0x00007FF7F9AE4E90 blender::deg::`anonymous namespace'::deg_task_run_func C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:133 blender.exe :0x00007FF7FB804290 Task::operator() C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:179 blender.exe :0x00007FF7FB804C20 tbb_task_pool_run C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:229 blender.exe :0x00007FF7FB804D10 tbb_task_pool_work_and_wait C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:241 blender.exe :0x00007FF7FB805570 BLI_task_pool_work_and_wait C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenlib\intern\task_pool.cc:501 blender.exe :0x00007FF7F9AE4BD0 blender::deg::deg_evaluate_on_refresh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\eval\deg_eval.cc:401 blender.exe :0x00007FF7F9A8A040 deg_flush_updates_and_refresh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\depsgraph_eval.cc:61 blender.exe :0x00007FF7F9A8A1D0 DEG_evaluate_on_refresh C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\depsgraph\intern\depsgraph_eval.cc:77 blender.exe :0x00007FF7F91157D0 scene_graph_update_tagged C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\scene.c:2584 blender.exe :0x00007FF7F910E200 BKE_scene_graph_update_tagged C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\blenkernel\intern\scene.c:2632 blender.exe :0x00007FF7F8F3BE70 wm_event_do_depsgraph C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:385 blender.exe :0x00007FF7F8F3DF00 wm_event_do_refresh_wm_and_depsgraph C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:408 blender.exe :0x00007FF7F8F3D360 wm_event_do_notifiers C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm_event_system.c:619 blender.exe :0x00007FF7F8F0F500 WM_main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\blender\windowmanager\intern\wm.c:645 blender.exe :0x00007FF7F8F068B0 main C:\Users\Pratik\Desktop\BlenderOSP\blender\source\creator\creator.c:564 blender.exe :0x00007FF7FBAA00A0 invoke_main d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79 blender.exe :0x00007FF7FBA9FE50 __scrt_common_main_seh d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288 blender.exe :0x00007FF7FBA9FE30 __scrt_common_main d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331 blender.exe :0x00007FF7FBAA0160 mainCRTStartup d:\A01\_work\12\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17 KERNEL32.DLL :0x00007FFF0BF37020 BaseThreadInitThunk ntdll.dll :0x00007FFF0C682630 RtlUserThreadStart```
Germano Cavalcante commented 2022-01-24 23:10:34 +01:00
Member
Copy Link

Added subscribers: @HooglyBoogly, @mano-wii

Added subscribers: @HooglyBoogly, @mano-wii
Germano Cavalcante commented 2022-01-24 23:10:35 +01:00
Member
Copy Link

It's a harmless, simple fix assert.
Perhaps the fix can be applied in D13907: Geometry Nodes: Port weld modifier to the merge by distance node.

diff --git a/source/blender/modifiers/intern/MOD_weld.cc b/source/blender/modifiers/intern/MOD_weld.cc
index 2d4710ca71a..63e129f81cc 100644
--- a/source/blender/modifiers/intern/MOD_weld.cc
+++ b/source/blender/modifiers/intern/MOD_weld.cc
@@ -611,13 +611,10 @@ static void weld_edge_groups_setup(const int medge_len,
 {
   /* Get weld edge groups. */
 
-  struct WeldGroupEdge *wegrp_iter;
-
   int wgroups_len = wedge.size() - edge_kill_len;
   r_edge_groups.reinitialize(wgroups_len);
   r_edge_groups.fill({{0}});
   MutableSpan<WeldGroupEdge> wegroups = r_edge_groups;
-  wegrp_iter = &r_edge_groups[0];
 
   wgroups_len = 0;
   for (const int i : IndexRange(medge_len)) {
@@ -631,11 +628,10 @@ static void weld_edge_groups_setup(const int medge_len,
       }
       else {
         we->edge_dest = we->edge_orig;
-        wegrp_iter->v1 = we->vert_a;
-        wegrp_iter->v2 = we->vert_b;
+        wegroups[wgroups_len].v1 = we->vert_a;
+        wegroups[wgroups_len].v2 = we->vert_b;
         r_edge_groups_map[i] = wgroups_len;
         wgroups_len++;
-        wegrp_iter++;
       }
     }
     else {
@@ -645,6 +641,11 @@ static void weld_edge_groups_setup(const int medge_len,
 
   BLI_assert(wgroups_len == wedge.size() - edge_kill_len);
 
+  if (!wgroups_len) {
+    /* All edges in context are collapsed. */
+    return;
+  }
+
   for (const WeldEdge &we : wedge) {
     if (we.flag == ELEM_COLLAPSED) {
       continue;
It's a harmless, simple fix assert. Perhaps the fix can be applied in [D13907: Geometry Nodes: Port weld modifier to the merge by distance node](https://archive.blender.org/developer/D13907). ``` diff --git a/source/blender/modifiers/intern/MOD_weld.cc b/source/blender/modifiers/intern/MOD_weld.cc index 2d4710ca71a..63e129f81cc 100644 --- a/source/blender/modifiers/intern/MOD_weld.cc +++ b/source/blender/modifiers/intern/MOD_weld.cc @@ -611,13 +611,10 @@ static void weld_edge_groups_setup(const int medge_len, { /* Get weld edge groups. */ - struct WeldGroupEdge *wegrp_iter; - int wgroups_len = wedge.size() - edge_kill_len; r_edge_groups.reinitialize(wgroups_len); r_edge_groups.fill({{0}}); MutableSpan<WeldGroupEdge> wegroups = r_edge_groups; - wegrp_iter = &r_edge_groups[0]; wgroups_len = 0; for (const int i : IndexRange(medge_len)) { @@ -631,11 +628,10 @@ static void weld_edge_groups_setup(const int medge_len, } else { we->edge_dest = we->edge_orig; - wegrp_iter->v1 = we->vert_a; - wegrp_iter->v2 = we->vert_b; + wegroups[wgroups_len].v1 = we->vert_a; + wegroups[wgroups_len].v2 = we->vert_b; r_edge_groups_map[i] = wgroups_len; wgroups_len++; - wegrp_iter++; } } else { @@ -645,6 +641,11 @@ static void weld_edge_groups_setup(const int medge_len, BLI_assert(wgroups_len == wedge.size() - edge_kill_len); + if (!wgroups_len) { + /* All edges in context are collapsed. */ + return; + } + for (const WeldEdge &we : wedge) { if (we.flag == ELEM_COLLAPSED) { continue; ```
blender-admin commented 2022-01-25 20:56:00 +01:00
Copy Link

This issue was referenced by 52b2769b9c

This issue was referenced by 52b2769b9c1283dbe42176fc5581817f9e7d3a94
Hans Goudey commented 2022-01-25 20:56:53 +01:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Hans Goudey self-assigned this 2022-01-25 20:56:53 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
partial-write-refactor
brush-assets-project
universal-scene-description
fix-121021
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Hans Goudey
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#95169
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?