Invalid normals after undo in sculpt mode #95185
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#95185
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: AMD Radeon RX 5700 XT ATI Technologies Inc. 4.5.14802 Core Profile Context 21.12.1 30.0.14011.3017
Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-23 19:27, hash:
abf30007abCaused by d9c6ceb3b8
Short description of error
Whenever sculpting some actions do not update the normals of the surface while others create weird visual glitching.
Exact steps for others to reproduce the error
#95185.blend
before
after
Examples are:
Ctrl + z after pose brush
Projection brush and ctrl+z projection
mesh fairing and ctrl+z the mesh fairing
The normals only update if the region is interacted with again with another brush. Leaving sculpt mode gets back to normal, but entering sculpt mode again brings the weird normals back
Added subscriber: @Diogo_Valadares
#95406 was marked as duplicate of this issue
Added subscriber: @PratikPB2123
Changed status from 'Needs Triage' to: 'Needs User Info'
Hi, thanks for the report. Please provide sample .blend file for reproducing the issue.
well, the file I'm working on is pretty heavy, but I managed to reproduce it just by using a high poly mesh.
In the case below a subdivided cilinder:
fair the pink part.blend
And while trying to reproduce it again, I noted that it only happens if the mesh is in Shade Smooth. on flat shading the problem does not occur. I also tested with factory settings but the problem persists.
Changed status from 'Needs User Info' to: 'Needs Triage'
Added subscriber: @lichtwerk
Changed status from 'Needs Triage' to: 'Confirmed'
Can confirm, assume this is caused by d9c6ceb3b8, will check
Added subscriber: @HooglyBoogly
@HooglyBoogly : mind checking?
Added subscriber: @JosephEagar
I've spent a few hours testing various things-- marking PBVH nodes for updates, tagging verts for updates, skipping dirty checks in the PBVH normal calculation, tagging mesh normals dirty in various places in the sculpt undo code, trying to restore normals from
SculptUndoNode::no. None of it has worked, except completely replacing the PBVH normal calculation with theMeshfunction.I understand the sculpt undo system a bit better now, but I haven't been able to wrap my head around the state it expects everything to be in. In particular, it's not actually clear to me how
SculptUndoNode::nois supposed to be used, or even if it is used at all.I need a break from this for the day, but I'll try again tomorrow. Maybe someone with more experience with the sculpt undo system would be able to spot the error much quicker. Maybe @JosephEagar?
Several Normal glitches/delayed updates in sculpt modeto Invalid normals after undo in sculpt modeI've created a prototype patch here: D13939: Fix #95185: Invalid normals after undo in sculpt mode
Ideally I would get the opinion of someone more experienced in this area.
I have another problem with normals in sculpt mode but I'm not sure if its related to this one. I'm not sure what I am doing to make it but I'm guessing its something to do with dyntopo/wireframe view.
I get these "lines" that change place when I sculpt over then. I don't know if I should open another report for this one.
This issue was referenced by
c8814fb610Changed status from 'Confirmed' to: 'Resolved'
Added subscriber: @IlyasseL