Undo bone rotation after previous frame/keyframe jump operators undoes frame jump as well (frame in UI is still the same though) #95246

New Issue

Jesper Colding - Jørgensen · 2022-01-27T09:40:40+01:00

2022-01-27 09:40:40 +01:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 497.09

Blender Version
Broken: version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: a791bdabd0
Broken: 2.91
Worked: 2.90

Caused by 263148dbac

Short description of error
Undo bone rotation after previous frame/keyframe jump operators undoes frame jump as well (frame in UI is still the same though)

Exact steps for others to reproduce the error
undo-test.blend

Open above .blend
{key Down} to jump to previous keyframe
rotate selected bone
Undo
frame is still at frame zero, but armature and mesh are evaluated as in frame 20

note this is true for all jump operators:

screen.frame_jump
action.frame_jump
graph.frame_jump
screen.frame_jump
screen.keyframe_jump

Undo_3.gif:

First the animation is played (just to show you the animation. There are three keyframes. The pipe goes from straight to bend to straight)
I then step from frame 1 to the next keyframe which is frame 20.
I then change the keyframe.
I then choose Undo.
The Undo function now BOTH undo's the animation change AND steps the user back to frame 0. - aka. Two steps back - Well here's a weird extra thing: It actually still is on frame 20, but SHOWS frame 0.

Note #66913 (Issue with Undoing after using next/previous keyframe shortcut.) might be related (but for one, I cannot reproduce that report in current master, and that issue seems to have been there for much longer, whereas this issue was caused by 263148dbac)

Thanks for an otherwise wonderful software.

Best, Jesper Colding
http://www.jespercolding.dk
(27 years as a 3D-Animator)

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 497.09 **Blender Version** Broken: version: 2.93.5, branch: master, commit date: 2021-10-05 12:04, hash: `a791bdabd0` Broken: 2.91 Worked: 2.90 Caused by 263148dbac **Short description of error** Undo bone rotation after previous frame/keyframe jump operators undoes frame jump as well (frame in UI is still the same though) **Exact steps for others to reproduce the error** [undo-test.blend](https://archive.blender.org/developer/F12827175/undo-test.blend) - Open above .blend - {key Down} to jump to previous keyframe - rotate selected bone - Undo - frame is still at frame zero, but armature and mesh are evaluated as in frame 20 note this is true for all jump operators: - screen.frame_jump - action.frame_jump - graph.frame_jump - screen.frame_jump - screen.keyframe_jump Undo_3.gif: 1. First the animation is played (just to show you the animation. There are three keyframes. The pipe goes from straight to bend to straight) 2. I then step from frame 1 to the next keyframe which is frame 20. 3. I then change the keyframe. 4. I then choose Undo. 5. The Undo function now BOTH undo's the animation change AND steps the user back to frame 0. - aka. Two steps back - Well here's a weird extra thing: It actually still is on frame 20, but SHOWS frame 0. ![Undo_3.gif](https://archive.blender.org/developer/F12827176/Undo_3.gif) Note #66913 (Issue with Undoing after using next/previous keyframe shortcut.) might be related (but for one, I cannot reproduce that report in current master, and that issue seems to have been there for much longer, whereas this issue was caused by 263148dbac) Thanks for an otherwise wonderful software. Best, Jesper Colding [[http://www.jespercolding.dk]] (27 years as a 3D-Animator)

Jesper Colding - Jørgensen commented

2022-01-27 09:40:40 +01:00

Added subscriber: @Njesper

Thomas Kaae Colding commented

2022-01-27 10:38:16 +01:00

Added subscriber: @TKColding

Thomas Kaae Colding commented

2022-01-27 10:38:16 +01:00

Hi Blender people,

This is exactly what I am experiencing on a daily basis working professionally as an animator... in blender.

Especially situation #3 I "hit" all the time.

Step to another frame on the timeline.
Rotate a bone.
Undo the bone rotation.
Result is that the bone rotation is undoed... BUT it now shows me the character from the previous timeline position.... UNTIL i step forward and back a frame then its back to the original.

This is super frustrating that each time you undo a pose change you get a temporary different result visually.

Especially working with stepped keys early in the animation stages - when going back one key can mean a completely different pose of the character... so the change is huge when you undo.

Hope it makes sense... nevertheless super frustrating - especially in a program that on a lot of other areas are deeply satisfying to work with.

Cheers - Thomas

Hi Blender people, This is exactly what I am experiencing on a daily basis working professionally as an animator... in blender. Especially situation #3 I "hit" all the time. 1. Step to another frame on the timeline. 2. Rotate a bone. 3. Undo the bone rotation. 4. Result is that the bone rotation is undoed... BUT it now shows me the character from the previous timeline position.... UNTIL i step forward and back a frame then its back to the original. This is super frustrating that each time you undo a pose change you get a temporary different result visually. Especially working with stepped keys early in the animation stages - when going back one key can mean a completely different pose of the character... so the change is huge when you undo. Hope it makes sense... nevertheless super frustrating - especially in a program that on a lot of other areas are deeply satisfying to work with. Cheers - Thomas

Jakob Baldwin commented

2022-01-27 11:10:24 +01:00

Added subscriber: @JakobBaldwin

Jakob Baldwin commented

2022-01-27 11:14:46 +01:00

+1. I have also run into all 3 examples in blender 2.93 & 3.0.1, pretty weird undo behaviour overall, where it seems certain editor settings are being pushed to the undo stack, when I'd say they shouldn't be/shouldn't get undone along with other actions.

Philipp Oeser commented

2022-01-27 11:56:02 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-01-27 11:56:02 +01:00

First case is the same as #69760 (Undo/Adjust Last Operation: vertex and weightpaint operators/strokes undo more then they should (change back any setting changed prior to execution))

Philipp Oeser commented

2022-01-27 12:19:29 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-01-27 12:19:29 +01:00

Situation 3 I can confirm, too (quite bad...), this broke between 2.90 and 2.91, will check...

For the time being: @JakobBaldwin , @Njesper : would you agree that the first two scenarios could be merged with #69760?
(This way we could remove those from this report and concentrate on the 3rd scenario here)

Situation 3 I can confirm, too (quite bad...), this broke between 2.90 and 2.91, will check... For the time being: @JakobBaldwin , @Njesper : would you agree that the first two scenarios could be merged with #69760? (This way we could remove those from this report and concentrate on the 3rd scenario here)

Philipp Oeser commented

2022-01-27 12:45:50 +01:00

In #95246#1295890, @lichtwerk wrote:
Situation 3 I can confirm, too (quite bad...), this broke between 2.90 and 2.91, will check...

Interestingly, this only happens with the screen.frame_jump action.frame_jump graph.frame_jump and screen.frame_jump operators, changing frames with mouse clicks in the timeline does not expose this glitch.
I recall this might have been reported before, too, will check if I can find the duplicate...

> In #95246#1295890, @lichtwerk wrote: > Situation 3 I can confirm, too (quite bad...), this broke between 2.90 and 2.91, will check... Interestingly, this only happens with the `screen.frame_jump` `action.frame_jump` `graph.frame_jump` and `screen.frame_jump` operators, changing frames with mouse clicks in the timeline does not expose this glitch. I recall this might have been reported before, too, will check if I can find the duplicate...

Pratik Borhade commented

2022-01-27 13:10:41 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-01-27 13:10:41 +01:00

I recall this might have been reported before, too, will check if I can find the duplicate...

@lichtwerk : {#66913}?

> I recall this might have been reported before, too, will check if I can find the duplicate... @lichtwerk : {#66913}?

Thomas Kaae Colding commented

2022-01-27 13:12:06 +01:00

In #95246#1295898, @lichtwerk wrote:

In #95246#1295890, @lichtwerk wrote:
Situation 3 I can confirm, too (quite bad...), this broke between 2.90 and 2.91, will check...

Interestingly, this only happens with the screen.frame_jump action.frame_jump graph.frame_jump and screen.frame_jump operators, changing frames with mouse clicks in the timeline does not expose this glitch.
I recall this might have been reported before, too, will check if I can find the duplicate...

Also happens with screen.keyframe_jump which I use all the time :)

> In #95246#1295898, @lichtwerk wrote: >> In #95246#1295890, @lichtwerk wrote: >> Situation 3 I can confirm, too (quite bad...), this broke between 2.90 and 2.91, will check... > > Interestingly, this only happens with the `screen.frame_jump` `action.frame_jump` `graph.frame_jump` and `screen.frame_jump` operators, changing frames with mouse clicks in the timeline does not expose this glitch. > I recall this might have been reported before, too, will check if I can find the duplicate... Also happens with screen.keyframe_jump which I use all the time :)

Philipp Oeser commented

2022-01-27 13:41:13 +01:00

#66913 (Issue with Undoing after using next/previous keyframe shortcut.) might be related (cannot reproduce that one in current master tbh.).

This one here seems to be a regression from 263148dbac though.

So what I will do is to remove the first two issues from this report (since they are duplicates of #69760) and update the description so it only handles the third scenario.

#66913 (Issue with Undoing after using next/previous keyframe shortcut.) might be related (cannot reproduce that one in current master tbh.). This one here seems to be a regression from 263148dbac though. So what I will do is to remove the first two issues from this report (since they are duplicates of #69760) and update the description so it only handles the third scenario.

Philipp Oeser changed title from ~~Undo, undo's TWO user-performed tasks, if the two tasks differ, tool-wise (and in 3.0.1 it even undo's 3 steps back)!~~ to Undo bone rotation after previous frame/keyframe jump operators undoes frame jump as well (frame in UI is still the same though)

2022-01-27 14:07:00 +01:00

Philipp Oeser commented

2022-01-27 14:07:47 +01:00

Added subscriber: @JacquesLucke

Philipp Oeser commented

2022-01-27 14:07:47 +01:00

@JacquesLucke : since it was your commit, mind having a look?

Thomas Kaae Colding commented

2022-01-27 14:21:08 +01:00

Wow - I am deeply humbled by the reaction time and effort you already are putting into this... any other 3d package manufacturer would have MAYBE commented once like in weeks or months. Good job guys.. and thanks for looking into the matter! Looking forward to see what you figure out :D