Texture border generation. Adjacent faces uses stale UV map when in edit mode. #95250

New Issue

Martijn Versteegh · 2022-01-27T13:08:29+01:00

Martijn Versteegh commented

2022-01-27 13:08:29 +01:00

Broken version: Blender 3.1 alpha 60bd6804db
Last Working Verstion: This is new code which wasn't available in previous versions.

patch:
https://developer.blender.org/D13938

Border generation uses stale UV map if Uv map has changed and you are still in edit mode.

Steps to reproduce from default startup

Setup a material on the default cube with a noise texture on the base color and an unconnected empty image texture to bake to, Select the image texture.
Go to the UV workspace.
Go to editmode.
Select all and rotate the UV mesh
Go to cycles -> baking and bake diffuse color with Adjacent faces as margin algorithm and a nonzero border.
after baking, the baking result is screwed up because the margin is generated with the unrotated UV map.'

Broken version: Blender 3.1 alpha 60bd6804dbd87b5f1907f208394b69610941fd1b Last Working Verstion: This is new code which wasn't available in previous versions. patch: https://developer.blender.org/D13938 Border generation uses stale UV map if Uv map has changed and you are still in edit mode. Steps to reproduce from default startup - Setup a material on the default cube with a noise texture on the base color and an unconnected empty image texture to bake to, Select the image texture. - Go to the UV workspace. - Go to editmode. - Select all and rotate the UV mesh - Go to cycles -> baking and bake diffuse color with Adjacent faces as margin algorithm and a nonzero border. after baking, the baking result is screwed up because the margin is generated with the unrotated UV map.'

Martijn Versteegh commented

2022-01-27 13:08:29 +01:00

Added subscriber: @Baardaap

Martijn Versteegh self-assigned this 2022-01-27 13:08:45 +01:00

Martijn Versteegh commented

2022-01-27 13:08:45 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-01-27 13:12:11 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-01-27 13:12:11 +01:00

Changed status from 'Confirmed' to: 'Needs User Info'

Philipp Oeser commented

2022-01-27 13:12:11 +01:00

@Baardaap : please (as for everyone else) include an example .blend file and reproductions steps (in addition to all the other required information from https://developer.blender.org/maniphest/task/edit/form/1/

Martijn Versteegh commented

2022-01-27 22:58:40 +01:00

Added subscriber: @mont29

Martijn Versteegh commented

2022-01-27 22:58:40 +01:00

@lichtwerk Sorry. As I was already very far along the way in fixing this bug, and I claimed the task myself, it seemed like a waste of time to go through the motions. Should I still add it after the fact? I can understand it would help in reviewing maybe?
It's too late to do it today, but I could cook up a demonstration .blend tomorrow if needed.
@mont29 I asked in the developer chat how I should handle this. As it is a bugfix that should go into 3.1 I was specifically asked to tag it with 3.1. Shouldn't I have done that?

@lichtwerk Sorry. As I was already very far along the way in fixing this bug, and I claimed the task myself, it seemed like a waste of time to go through the motions. Should I still add it after the fact? I can understand it would help in reviewing maybe? It's too late to do it today, but I could cook up a demonstration .blend tomorrow if needed. @mont29 I asked in the developer chat how I should handle this. As it is a bugfix that should go into 3.1 I was specifically asked to tag it with 3.1. Shouldn't I have done that?

Martijn Versteegh commented

2022-01-27 23:16:03 +01:00

added patch:
https://developer.blender.org/D13938

added patch: https://developer.blender.org/D13938

Martijn Versteegh commented

2022-01-28 19:57:30 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'