Frame Selected in 3d viewport does not respect Geo Nodes instances #95262

New Issue

Nikhil Shringarpurey · 2022-01-27T18:15:44+01:00

Nikhil Shringarpurey commented

2022-01-27 18:15:44 +01:00

Blender Version
Broken: current master build

Short description of error
Frame Selected in 3d viewport does not respect Geo Nodes instances

Exact steps for others to reproduce the error

#95262.blend

Open .blend
use {key Numpad ,} to frame selected
result: frames the "original" boundingbox only
set RealizeInstances on the modifier to 1 (notice the overall boundingbox is "unified" - expected -)
use {key Numpad ,} to frame selected
result: frames the overall boundingbox now

So the question is probably: for user actions like these, should always the "realized" bounding box be used?

Original report
The frame selected function (numpad period) is normally used to zoom an object to full screen in the 3D View. When Geometry Nodes has created new mesh data, this function only zooms into the original object and ignores the new geometry.

If a Realize Instances node is added at the end of the tree, then the frame selected function works better, but is still not framing the object correctly.

Guessing this is due to how instances are handled, so I'm not sure if this is a bug that can be fixed, but wanted to log it.

Examples attached showing result of using frame selected with and without a RI node.

Without (zooms in way too far):

With (better, but still not fitting selected object to viewport):

**Blender Version** Broken: current master build **Short description of error** Frame Selected in 3d viewport does not respect Geo Nodes instances **Exact steps for others to reproduce the error** [#95262.blend](https://archive.blender.org/developer/F12830825/T95262.blend) - Open .blend - use {key Numpad ,} to frame selected - result: frames the "original" boundingbox only - set `RealizeInstances` on the modifier to 1 (notice the overall boundingbox is "unified" - expected -) - use {key Numpad ,} to frame selected - result: frames the overall boundingbox now So the question is probably: for user actions like these, should always the "realized" bounding box be used? **Original report** The frame selected function (numpad period) is normally used to zoom an object to full screen in the 3D View. When Geometry Nodes has created new mesh data, this function only zooms into the original object and ignores the new geometry. If a Realize Instances node is added at the end of the tree, then the frame selected function works better, but is still not framing the object correctly. Guessing this is due to how instances are handled, so I'm not sure if this is a bug that can be fixed, but wanted to log it. Examples attached showing result of using frame selected with and without a RI node. Without (zooms in way too far): ![FrameSelected 01.png](https://archive.blender.org/developer/F12828157/FrameSelected_01.png) With (better, but still not fitting selected object to viewport): ![FrameSelected 02.png](https://archive.blender.org/developer/F12828158/FrameSelected_02.png)

Nikhil Shringarpurey commented

2022-01-27 18:15:44 +01:00

Added subscriber: @Nikhil.Net

Philipp Oeser commented

2022-01-28 12:11:24 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-01-28 12:11:24 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-01-28 12:11:24 +01:00

Also true for "regular" instances, will check.

Philipp Oeser commented

2022-01-28 12:14:55 +01:00

In #95262#1296879, @lichtwerk wrote:
Also true for "regular" instances, will check.

Backflip on the "regular" ones, these work.

> In #95262#1296879, @lichtwerk wrote: > Also true for "regular" instances, will check. Backflip on the "regular" ones, these work.

Philipp Oeser commented

2022-01-28 12:30:00 +01:00

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'

Philipp Oeser commented

2022-01-28 12:30:42 +01:00

Basically made this a design question now, this might have been discussed already, will also ask in chat...

Philipp Oeser commented

2022-01-28 12:33:23 +01:00

Not sure if #92206 (Bounding Box: compute during depsgraph evaluation) is related?

Julian Eisel commented

2022-01-28 15:43:47 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2022-01-28 15:43:47 +01:00

Checking this, intend seems to be to include instances already, but it's not working correctly. The dupli-object iterator in BKE_object_minmax_dupli() iterates over the original object multiple times, rather than the original one and then the instanced ones. So object_duplilist() seems to generate the wrong dupli-list.

Simpler way to recreate this:

Open file node_instance_testing.blend
Press numpad {key .}
Notice that the instances go out of view bounds.

In #95262#1296894, @lichtwerk wrote:
Not sure if #92206 (Bounding Box: compute during depsgraph evaluation) is related?

In some way related yeah, but not in that it would help much solving this I think.

Checking this, intend seems to be to include instances already, but it's not working correctly. The dupli-object iterator in `BKE_object_minmax_dupli()` iterates over the original object multiple times, rather than the original one and then the instanced ones. So `object_duplilist()` seems to generate the wrong dupli-list. Simpler way to recreate this: * Open file [node_instance_testing.blend](https://archive.blender.org/developer/F12831140/node_instance_testing.blend) * Press numpad {key .} * Notice that the instances go out of view bounds. > In #95262#1296894, @lichtwerk wrote: > Not sure if #92206 (Bounding Box: compute during depsgraph evaluation) is related? In some way related yeah, but not in that it would help much solving this I think.

Philipp Oeser commented

2022-01-28 16:22:05 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Jacques Lucke commented

2022-01-31 16:21:14 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2022-01-31 16:21:14 +01:00

I guess the issue is that BKE_object_minmax_dupli calls BKE_object_boundbox_get(dob->ob). This ignores dop->ob_data which has to be taken into account here.
That's touching on the more general issue that we don't have bounding boxes on the geometry directly yet, but should be possible to fix either way.

I guess the issue is that `BKE_object_minmax_dupli` calls `BKE_object_boundbox_get(dob->ob)`. This ignores `dop->ob_data` which has to be taken into account here. That's touching on the more general issue that we don't have bounding boxes on the geometry directly yet, but should be possible to fix either way.

blender-admin commented

2022-02-01 11:58:53 +01:00

This issue was referenced by 217e0a2ce6

This issue was referenced by 217e0a2ce615921040da4b524d2393d4db5ab68e

Jacques Lucke commented

2022-02-01 11:59:49 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2022-02-01 11:59:49 +01:00

Jacques Lucke self-assigned this 2022-02-01 11:59:49 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Frame Selected in 3d viewport does not respect Geo Nodes instances #95262