Crash making a node group with a frame #95395

New Issue

Lukas Tönne · 2022-02-01T14:58:24+01:00

Lukas Tönne commented

2022-02-01 14:58:24 +01:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-26 21:12, hash: 0e86c60c28
Worked: (newest version of Blender that worked as expected)

Apparently caused by dd01ce2cd0

Short description of error
Crash when making a node group with a frame node and unselected nodes inside the frame.

Exact steps for others to reproduce the error

Make a simple node tree with one node (does not have to be functional or connected to the output)
Wrap the node in a frame (ctrl+J)
Select only the frame node, the inside node should be unselected.
Make a node group (ctrl+G)
The crash seems to happen if there are any unselected nodes within the frame:

If there are multiple nodes in the frame it crashes if one of them is not selected.
If all nodes inside the frame are selected it works as expected.
If the frame is empty it works as expected.
make_group_crash.blend

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 456.71 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-26 21:12, hash: `0e86c60c28` Worked: (newest version of Blender that worked as expected) Apparently caused by dd01ce2cd0 **Short description of error** Crash when making a node group with a frame node and unselected nodes inside the frame. **Exact steps for others to reproduce the error** 1. Make a simple node tree with one node (does not have to be functional or connected to the output) 1. Wrap the node in a frame (ctrl+J) 1. Select **only** the frame node, the inside node should be unselected.![image.png](https://archive.blender.org/developer/F12839268/image.png) 1. Make a node group (ctrl+G) The crash seems to happen if there are *any* unselected nodes within the frame: * If there are multiple nodes in the frame it crashes if one of them is not selected. * If all nodes inside the frame are selected it works as expected. * If the frame is empty it works as expected. [make_group_crash.blend](https://archive.blender.org/developer/F12839267/make_group_crash.blend)

Lukas Tönne commented

2022-02-01 14:58:24 +01:00

Added subscriber: @LukasTonne

Philipp Oeser commented

2022-02-01 15:01:43 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-02-01 15:01:43 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-02-01 15:01:43 +01:00

Can confirm, will check.

Philipp Oeser commented

2022-02-01 15:51:42 +01:00

Apparently caused by dd01ce2cd0

Apparently caused by dd01ce2cd0

Philipp Oeser commented

2022-02-01 15:53:59 +01:00

Added subscriber: @JacquesLucke

Philipp Oeser commented

2022-02-01 15:53:59 +01:00

Marking as High priority since it is a crash regression (even though maybe not the most likely one to run into).

CC @JacquesLucke

Marking as High priority since it is a crash regression (even though maybe not the most likely one to run into). CC @JacquesLucke

Lukas Tönne commented

2022-02-01 16:36:11 +01:00

even though maybe not the most likely one to run into

I use frames a lot as a method for commenting in nodes, and then i turn them into actual node groups when the frame gets too big and unwieldy. So it happens quite a lot when i want to exclude some of the nodes in the frame. I've learned to avoid it, but i don't think it's particularly unlikely for people making complex node systems.

> even though maybe not the most likely one to run into I use frames a lot as a method for commenting in nodes, and then i turn them into actual node groups when the frame gets too big and unwieldy. So it happens quite a lot when i want to exclude some of the nodes in the frame. I've learned to avoid it, but i don't think it's particularly unlikely for people making complex node systems.

Philipp Oeser commented

2022-02-01 16:40:44 +01:00

In #95395#1299345, @LukasTonne wrote:

even though maybe not the most likely one to run into

I use frames a lot as a method for commenting in nodes, and then i turn them into actual node groups when the frame gets too big and unwieldy. So it happens quite a lot when i want to exclude some of the nodes in the frame. I've learned to avoid it, but i don't think it's particularly unlikely for people making complex node systems.

Sorry, yeah this was not meant to make this less severe, hope this will get fixed due to High prio soonish.
P.S.: you might be interested in D13737

> In #95395#1299345, @LukasTonne wrote: >> even though maybe not the most likely one to run into > > I use frames a lot as a method for commenting in nodes, and then i turn them into actual node groups when the frame gets too big and unwieldy. So it happens quite a lot when i want to exclude some of the nodes in the frame. I've learned to avoid it, but i don't think it's particularly unlikely for people making complex node systems. Sorry, yeah this was not meant to make this less severe, hope this will get fixed due to High prio soonish. P.S.: you might be interested in [D13737](https://archive.blender.org/developer/D13737)

Jacques Lucke self-assigned this 2022-02-01 16:41:45 +01:00

Lukas Tönne commented

2022-02-01 17:00:24 +01:00

In #95395#1299348, @lichtwerk wrote:

In #95395#1299345, @LukasTonne wrote:

even though maybe not the most likely one to run into

I use frames a lot as a method for commenting in nodes, and then i turn them into actual node groups when the frame gets too big and unwieldy. So it happens quite a lot when i want to exclude some of the nodes in the frame. I've learned to avoid it, but i don't think it's particularly unlikely for people making complex node systems.

Sorry, yeah this was not meant to make this less severe, hope this will get fixed due to High prio soonish.
P.S.: you might be interested in D13737

Thanks! I just wanted to add some context. The new select behavior looks good, much more usable.

> In #95395#1299348, @lichtwerk wrote: >> In #95395#1299345, @LukasTonne wrote: >>> even though maybe not the most likely one to run into >> >> I use frames a lot as a method for commenting in nodes, and then i turn them into actual node groups when the frame gets too big and unwieldy. So it happens quite a lot when i want to exclude some of the nodes in the frame. I've learned to avoid it, but i don't think it's particularly unlikely for people making complex node systems. > > Sorry, yeah this was not meant to make this less severe, hope this will get fixed due to High prio soonish. > P.S.: you might be interested in [D13737](https://archive.blender.org/developer/D13737) Thanks! I just wanted to add some context. The new select behavior looks good, much more usable.

blender-admin commented

2022-02-01 17:48:44 +01:00

This issue was referenced by 2bd71b49e7

This issue was referenced by 2bd71b49e79325863bfe3c561fa03653231c9914

Jacques Lucke commented

2022-02-01 17:50:59 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2022-02-01 17:50:59 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash making a node group with a frame #95395