Node Wrangler 'Mesh Line' input sockets not connecting properly using Alt+Shift+RMB drag #96334

Closed
opened 2022-03-11 13:08:28 +01:00 by David Newman · 5 comments

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.79

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-08 23:13, hash: 2146256563
Worked: (newest version of Blender that worked as expected)

Short description of error
Node Wrangler 'Mesh Line' input sockets not connecting properly using Alt+Shift+RMB drag - menu options do not correspond to what actually happens.2022-03-11 12-06-11.mkv

Exact steps for others to reproduce the error

  1. Create Value node and Mesh Line node.

  2. Attempt to connect Value node to Mesh Line using Alt+Shift+RMB drag.

Choosing 'Offset' from the menu will connect to 'Start Location' and choosing 'Start Location' will not connect at all.

Tested on 3.2 Alpha and 3.1 Stable.

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 2070 SUPER/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.79 **Blender Version** Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-03-08 23:13, hash: `2146256563` Worked: (newest version of Blender that worked as expected) **Short description of error** Node Wrangler 'Mesh Line' input sockets not connecting properly using Alt+Shift+RMB drag - menu options do not correspond to what actually happens.[2022-03-11 12-06-11.mkv](https://archive.blender.org/developer/F12921229/2022-03-11_12-06-11.mkv) **Exact steps for others to reproduce the error** 1. Create Value node and Mesh Line node. 2. Attempt to connect Value node to Mesh Line using Alt+Shift+RMB drag. Choosing 'Offset' from the menu will connect to 'Start Location' and choosing 'Start Location' will not connect at all. Tested on 3.2 Alpha and 3.1 Stable.
Author

Added subscriber: @DaveHuman

Added subscriber: @DaveHuman
Member

Added subscribers: @wannes.malfait, @lone_noel

Added subscribers: @wannes.malfait, @lone_noel
Member

Thanks a lot for the report, @DaveHuman! I can reproduce the behavior, but this is not an issue with Blender or Geometry Nodes, but with the Node Wrangler add-on that adds the functionality to connect node sockets with Alt + Shift + RMB. The issue is also present with all nodes that have hidden sockets depending on the mode.

I can't change the title or the tags to reflect the that this is an issue with an add-on rather than Blender itself, so I leave confirming to one of the moderators.


@wannes.malfait It seems like this was accidentally introduced in blender/blender-addons@26c4357e0b.
I think the fix is a just a one liner fixing an indentation. The index in line 4417 (4409 in the commit) has to be incremented, even if the socket is not enabled so the index matches the actual socket that is shown in the menu:

diff --git a/node_wrangler.py b/node_wrangler.py
index 19ccf0c5..436f1909 100644
--- a/node_wrangler.py
+++ b/node_wrangler.py
@@ -4414,7 +4414,7 @@ class NWConnectionListInputs(Menu, NWBase):
                 op = layout.operator(NWMakeLink.bl_idname, text=i.name, icon="FORWARD")
                 op.from_socket = context.scene.NWSourceSocket
                 op.to_socket = index
-                index+=1
+            index+=1
 
 
 class NWMergeMathMenu(Menu, NWBase):
Thanks a lot for the report, @DaveHuman! I can reproduce the behavior, but this is not an issue with Blender or Geometry Nodes, but with the Node Wrangler add-on that adds the functionality to connect node sockets with `Alt` + `Shift` + `RMB`. The issue is also present with all nodes that have hidden sockets depending on the mode. I can't change the title or the tags to reflect the that this is an issue with an add-on rather than Blender itself, so I leave confirming to one of the moderators. --- @wannes.malfait It seems like this was accidentally introduced in blender/blender-addons@26c4357e0b. I think the fix is a just a one liner fixing an indentation. The index in line 4417 (4409 in the commit) has to be incremented, even if the socket is not enabled so the index matches the actual socket that is shown in the menu: ``` diff --git a/node_wrangler.py b/node_wrangler.py index 19ccf0c5..436f1909 100644 --- a/node_wrangler.py +++ b/node_wrangler.py @@ -4414,7 +4414,7 @@ class NWConnectionListInputs(Menu, NWBase): op = layout.operator(NWMakeLink.bl_idname, text=i.name, icon="FORWARD") op.from_socket = context.scene.NWSourceSocket op.to_socket = index - index+=1 + index+=1 class NWMergeMathMenu(Menu, NWBase): ```
David Newman changed title from Geometry Node 'Mesh Line' input sockets not connecting properly using Alt+Shift+RMB drag to Node Wrangler 'Mesh Line' input sockets not connecting properly using Alt+Shift+RMB drag 2022-03-11 22:42:14 +01:00
Author

Thanks for the feedback. I have changed the title to reflect that Node Wrangler is the issue, and I've removed the 'Geometry Nodes' tag. Hope this is OK.

Thanks for the feedback. I have changed the title to reflect that Node Wrangler is the issue, and I've removed the 'Geometry Nodes' tag. Hope this is OK.
Member

Closed as duplicate of blender/blender-addons#94290

Closed as duplicate of blender/blender-addons#94290
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#96334
No description provided.