Asset Browser: dragging custom node group asset adds broken node #97237

New Issue

Sergey · 2022-04-11T09:21:13+02:00

Sergey commented

2022-04-11 09:21:13 +02:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: Intel(R) HD Graphics 630 Intel 4.5.0 - Build 25.20.100.6471

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-04-10 16:45, hash: 2e77a8f974
Worked: (newest version of Blender that worked as expected)

Short description of error
It's possible to add custom node group to asset browser but it's impossible to drag custom group from there. It creates something instead of a group node.

2022-04-11 11-06-19.mp4

Exact steps for others to reproduce the error
untitled.blend

Open the file
Run the script
Choose "Test Tree"
Mark current group node as asset
Drag and drop the asset into the Test Tree

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: Intel(R) HD Graphics 630 Intel 4.5.0 - Build 25.20.100.6471 **Blender Version** Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-04-10 16:45, hash: `2e77a8f974` Worked: (newest version of Blender that worked as expected) **Short description of error** It's possible to add custom node group to asset browser but it's impossible to drag custom group from there. It creates something instead of a group node. [2022-04-11 11-06-19.mp4](https://archive.blender.org/developer/F12994697/2022-04-11_11-06-19.mp4) **Exact steps for others to reproduce the error** [untitled.blend](https://archive.blender.org/developer/F12994698/untitled.blend) 1. Open the file 2. Run the script 3. Choose "Test Tree" 4. Mark current group node as asset 5. Drag and drop the asset into the Test Tree

Sergey commented

2022-04-11 09:21:13 +02:00

Added subscriber: @randum

Philipp Oeser commented

2022-04-11 17:38:52 +02:00

Added subscribers: @JulianEisel, @lichtwerk

Philipp Oeser commented

2022-04-11 17:38:52 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-04-11 17:38:52 +02:00

Can confirm.

Drag n Drop was added in 604e61d81d.
@JulianEisel : mind checking what is wrong

We also have #92811 (Support node groups in asset browser) with a couple of TODOs in this regard, will drop a note about this report there as well...

Can confirm. Drag n Drop was added in 604e61d81d. @JulianEisel : mind checking what is wrong We also have #92811 (Support node groups in asset browser) with a couple of TODOs in this regard, will drop a note about this report there as well...

Philipp Oeser commented

2022-04-14 11:02:50 +02:00

Following the policy "bug in new feature: high prio" I will raise priority here.

Philipp Oeser changed title from ~~Adding custom node group asset~~ to Asset Browser: dragging custom node group asset adds broken node

2022-04-14 11:04:02 +02:00

Bastien Montagne commented

2022-04-28 17:34:01 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2022-04-28 17:34:01 +02:00

@JulianEisel I would simply not allow custom node group as assets currently... Custom node groups have several very bad issues already (at ID management level), let's not add even more complexity in this area?

Julian Eisel commented

2022-05-13 13:08:02 +02:00

In #97237#1348401, @mont29 wrote:
@JulianEisel I would simply not allow custom node group as assets currently... Custom node groups have several very bad issues already (at ID management level), let's not add even more complexity in this area?

I think the #nodes_physics team should decide on that. But I would argue that having them supported as assets doesn't add much to what's already possible. After all it's just a more usable link/append.

Fixing the issue itself is probably simple. I just didn't have a test case for custom nodes when adding the node group drag & drop support (I forgot about the template).

> In #97237#1348401, @mont29 wrote: > @JulianEisel I would simply not allow custom node group as assets currently... Custom node groups have several very bad issues already (at ID management level), let's not add even more complexity in this area? I think the #nodes_physics team should decide on that. But I would argue that having them supported as assets doesn't add much to what's already possible. After all it's just a more usable link/append. Fixing the issue itself is probably simple. I just didn't have a test case for custom nodes when adding the node group drag & drop support (I forgot about the template).

Jacques Lucke commented

2022-05-23 09:32:06 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2022-05-23 09:32:06 +02:00

The issue is that node_add_group_exec does not know what type of node to add. It usually determines the node type by calling node_group_idname, but that only works for built-in tree types.
Note, the fix for the very specific example case is to just return "CustomNodeType" from node_group_idname in the default case, but that's not a generic fix obviously.

It's not clear to me how the fix should work. We'd need some way to determine the group-node type based on a node-group for custom tree types. Issue is that there might be multiple group-node types that could match. So for a general fix, we'd probably need to call some callback of the addon which determines which group to add. Or it would have to specify a "default node group idname" somehow.

Think it's fine to disable supporting assets for custom node tree types for now until a solution is found.

The issue is that `node_add_group_exec` does not know what type of node to add. It usually determines the node type by calling `node_group_idname`, but that only works for built-in tree types. Note, the fix for the very specific example case is to just return `"CustomNodeType"` from `node_group_idname` in the default case, but that's not a generic fix obviously. It's not clear to me how the fix should work. We'd need some way to determine the group-node type based on a node-group for custom tree types. Issue is that there might be multiple group-node types that could match. So for a general fix, we'd probably need to call some callback of the addon which determines which group to add. Or it would have to specify a "default node group idname" somehow. Think it's fine to disable supporting assets for custom node tree types for now until a solution is found.

Jacques Lucke self-assigned this 2022-05-23 11:15:03 +02:00

blender-admin commented

2022-05-23 14:43:12 +02:00

This issue was referenced by 2f2d13b8c6

This issue was referenced by 2f2d13b8c664b90a7d3249d6ad71bac3d519026d

Jacques Lucke commented

2022-05-23 14:44:02 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2022-05-23 14:44:02 +02:00

Thomas Dinges added this to the 3.2 milestone 2023-02-08 15:51:07 +01:00

Bastien Montagne added this to the Pipeline, Assets & IO project 2023-02-09 15:40:49 +01:00

Bastien Montagne removed this from the Pipeline, Assets & IO project 2023-02-10 12:49:29 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Asset Browser: dragging custom node group asset adds broken node #97237