Canvas Selector UX: Add option to create a color attribute in material mode. #97346

New Issue

Jeroen Bakker · 2022-04-15T08:37:26+02:00

Jeroen Bakker commented

2022-04-15 08:37:26 +02:00

In material mode the canvas selector allows creating a new texture and attach it directly to a socket of the Principled BSDF. We should change this operation to also support color attributes.

Current UX:

Proposal:

The operator should have a enum type to switch between Images/Color Attributes. The options can be drawn next to each other.
Note not there are BSDF inputs (like normals and others) that doesn't make sense to have color attributes attached. In this case the color attribute should not be selectable.

In material mode the canvas selector allows creating a new texture and attach it directly to a socket of the Principled BSDF. We should change this operation to also support color attributes. Current UX: ![image.png](https://archive.blender.org/developer/F13002367/image.png) ![image.png](https://archive.blender.org/developer/F13002370/image.png) Proposal: * The operator should have a enum type to switch between Images/Color Attributes. The options can be drawn next to each other. * Note not there are BSDF inputs (like normals and others) that doesn't make sense to have color attributes attached. In this case the color attribute should not be selectable.

Jeroen Bakker commented

2022-04-15 08:37:26 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jeroen Bakker commented

2022-04-15 08:37:26 +02:00

Added subscriber: @Jeroen-Bakker

Ethan-Hall commented

2022-04-20 01:57:04 +02:00

Added subscriber: @Ethan-Hall

Ethan-Hall self-assigned this 2022-04-20 03:13:31 +02:00

Ethan-Hall commented

2022-04-22 05:55:47 +02:00

@Jeroen-Bakker

Note not there are BSDF inputs (like normals and others) that doesn't make sense to have color attributes attached. In this case the color attribute should not be selectable.

I don't think we should prevent the user from selecting color attribute in these circumstances.
It's not like it hurts to allow the option, and explaining to the user why an option is inactive or missing can be avoided.
Someone thinking outside the box may even find it useful.

This is how it looks so far:

The fill color can be added as an option for color attributes, but I think it is better to upgrade paint_image_proj.c to C++ before adding this feature.

@Jeroen-Bakker >Note not there are BSDF inputs (like normals and others) that doesn't make sense to have color attributes attached. In this case the color attribute should not be selectable. I don't think we should prevent the user from selecting color attribute in these circumstances. It's not like it hurts to allow the option, and explaining to the user why an option is inactive or missing can be avoided. Someone thinking outside the box may even find it useful. This is how it looks so far: ![image.png](https://archive.blender.org/developer/F13015302/image.png) ![image.png](https://archive.blender.org/developer/F13015299/image.png) The fill color can be added as an option for color attributes, but I think it is better to upgrade `paint_image_proj.c` to C++ before adding this feature.

Jeroen Bakker commented

2022-04-22 08:28:26 +02:00

Yes I would do attribute filling as a separate patch.
Would suggest to use expand=True on the Slot type property. Saves a click
If you have a patch ready please upload so we can test and review.

Yes I would do attribute filling as a separate patch. Would suggest to use `expand=True` on the Slot type property. Saves a click If you have a patch ready please upload so we can test and review.

Ethan-Hall commented

2022-04-22 08:46:58 +02:00

@Jeroen-Bakker Uploaded: D14724

@Jeroen-Bakker Uploaded: [D14724](https://archive.blender.org/developer/D14724)

Ethan-Hall commented

2022-04-22 08:58:49 +02:00

It may be useful in the future to add grayscale (single component) color attributes and non-color attributes (no gamma correction) to sculpt paint. If that happens, then add paint slot could choose the most relevant setting (like how it chooses the color space when adding image textures.)

Also, "texture paint" is not an accurate term anymore since sculpt painting now includes attributes, but since we are moving to a unified paint system, I won't worry about it.

It may be useful in the future to add grayscale (single component) color attributes and non-color attributes (no gamma correction) to sculpt paint. If that happens, then add paint slot could choose the most relevant setting (like how it chooses the color space when adding image textures.) Also, "texture paint" is not an accurate term anymore since sculpt painting now includes attributes, but since we are moving to a unified paint system, I won't worry about it. ```

Julien Kaspar commented

2022-05-11 10:29:34 +02:00

Added subscriber: @JulienKaspar

Julien Kaspar commented

2022-05-11 10:29:34 +02:00

Can this task be marked as resolved with the commit b96cdbcf7a ?
the second point in the description was not yet implemented. Is that still planned?

Note not there are BSDF inputs (like normals and others) that doesn't make sense to have color attributes attached. In this case the color attribute should not be selectable

Can this task be marked as resolved with the commit b96cdbcf7a ? the second point in the description was not yet implemented. Is that still planned? > Note not there are BSDF inputs (like normals and others) that doesn't make sense to have color attributes attached. In this case the color attribute should not be selectable

Julien Kaspar commented

2022-05-12 09:51:17 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Julien Kaspar closed this issue

2022-05-12 09:51:17 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Canvas Selector UX: Add option to create a color attribute in material mode. #97346