NLA Editor - hotkey to rename active marker dysfunctional #97411

New Issue

Reiner Prokein · 2022-04-17T18:44:33+02:00

Reiner Prokein commented

2022-04-17 18:44:33 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 497.29

Blender Version
Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-04-16 21:32, hash: b9f1b64801

Short description of error
The hotkey to rename the active marker does not work as expected. I can rename the marker from the menu. The correct panel pops up. But when i use the hotkey then i get a no active item message.

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Open Blender
Switch to NLA editor
Add a keyframe
Add a marker from the Marker menu.
Try to rename it with the menu item Rename. You will be able to rename the marker.
Try the same with the hotkey F2. You will not be able to rename the marker,

The commit in question is from 14.04.2022

SHA-1: d6e7241237

Animation: Add F2 for renaming markers

F2 allows renaming lots of different types of active items, and now it
also works for markers.

Before, Ctrl+M was used, and it's context-sensitive: you often get
"Mirror Keys" instead, when your cursor isn't on the markers region, and
that operator has nothing to do with either renaming or markers.

What this commit does:

Replace Ctrl+M shortcut with F2.

Adds the TOPBAR_PT_name_marker panel which is implemented similar
to the global rename panel. This having to press enter twice to
confirm or escape twice to cancel, which would happen if the
marker.rename operator was called directly.

Replace usages of marker.rename in the UI with wm.call_panel.

To make the Industry Compatible keymap consistent with Blender
Default, the rename shortcut only works when hovering the markers
area.

Reviewed By: ChrisLend, sybren

Differential Revision: https://developer.blender.org/D12298

2022-04-17 18-34-23.mp4

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 497.29 **Blender Version** Broken: version: 3.2.0 Alpha, branch: master, commit date: 2022-04-16 21:32, hash: `b9f1b64801` **Short description of error** The hotkey to rename the active marker does not work as expected. I can rename the marker from the menu. The correct panel pops up. But when i use the hotkey then i get a no active item message. **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] - Open Blender - Switch to NLA editor - Add a keyframe - Add a marker from the Marker menu. - Try to rename it with the menu item Rename. You will be able to rename the marker. - Try the same with the hotkey F2. You will not be able to rename the marker, The commit in question is from 14.04.2022 > SHA-1: d6e72412373e2f90969b2f2a6ecfcb420011784b > > * Animation: Add F2 for renaming markers > > F2 allows renaming lots of different types of active items, and now it > also works for markers. > > Before, Ctrl+M was used, and it's context-sensitive: you often get > "Mirror Keys" instead, when your cursor isn't on the markers region, and > that operator has nothing to do with either renaming or markers. > > **What this commit does:** > > - Replace Ctrl+M shortcut with F2. > - Adds the `TOPBAR_PT_name_marker` panel which is implemented similar > to the global rename panel. This having to press enter twice to > confirm or escape twice to cancel, which would happen if the > `marker.rename` operator was called directly. > - Replace usages of `marker.rename` in the UI with `wm.call_panel`. > - To make the Industry Compatible keymap consistent with Blender > Default, the rename shortcut only works when hovering the markers > area. > > Reviewed By: ChrisLend, sybren > > Differential Revision: https://developer.blender.org/D12298 [2022-04-17 18-34-23.mp4](https://archive.blender.org/developer/F13006545/2022-04-17_18-34-23.mp4)

Reiner Prokein commented

2022-04-17 18:44:33 +02:00

Added subscriber: @tiles

Pratik Borhade commented

2022-04-18 06:22:33 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-04-18 06:22:33 +02:00

Changed status from 'Needs Triage' to: 'Archived'

Pratik Borhade closed this issue

2022-04-18 06:22:33 +02:00

Pratik Borhade commented

2022-04-18 06:22:33 +02:00

Hi Reiner, thanks for the report.

the rename shortcut only works when hovering the markers area.

This is expected as stated in the commit message. Shortcut will only work in markers area (bottom portion where markers are present)
I don't think this is a bug. Feel free to comment if there is any misunderstanding. I'll reopen the report in that case :)

Hi Reiner, thanks for the report. > the rename shortcut only works when hovering the markers area. This is expected as stated in the commit message. Shortcut will only work in markers area (bottom portion where markers are present) I don't think this is a bug. Feel free to comment if there is any misunderstanding. I'll reopen the report in that case :)

Reiner Prokein commented

2022-04-18 08:06:07 +02:00

Ah now i see. Thanks. I wasn't aware of this limit. In this regards it works of course as designed. And now i see the need of this limit since renaming the action strip also works with hotkey F2. It would then conflict. I guess there is no other way to solve it then.

All is well :)

Ah now i see. Thanks. I wasn't aware of this limit. In this regards it works of course as designed. And now i see the need of this limit since renaming the action strip also works with hotkey F2. It would then conflict. I guess there is no other way to solve it then. All is well :)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

NLA Editor - hotkey to rename active marker dysfunctional #97411