Assert when pack sound in blender DEBUG #97466

New Issue

Marcos Perez · 2022-04-20T11:21:04+02:00

Marcos Perez commented

2022-04-20 11:21:04 +02:00

System Information
Operating system: Windows 10
Graphics card: Intel

Blender Version
Broken: any tested 3.2 alpha version. For example, last commit: │bf80dc2
It works in "make release" but it fails with "make debug"

Short description of error
with a sound strip selected, you push "pack button" in the "source section" and it crashes with an alert of Assert exception

Exact steps for others to reproduce the error
Open Blender --> New file --> Video editor --> Add sound strip -> source -> pack

Output:
blender_crash_tintwotin_20220330.txt

**System Information** Operating system: Windows 10 Graphics card: Intel **Blender Version** Broken: any tested 3.2 alpha version. For example, last commit: │bf80dc2 It works in "make release" but it fails with "make debug" **Short description of error** with a sound strip selected, you push "pack button" in the "source section" and it crashes with an alert of Assert exception ![blender_r8V4q16N70.png](https://archive.blender.org/developer/F13012103/blender_r8V4q16N70.png) **Exact steps for others to reproduce the error** Open Blender --> New file --> Video editor --> Add sound strip -> source -> pack Output: [blender_crash_tintwotin_20220330.txt](https://archive.blender.org/developer/F13012105/blender_crash_tintwotin_20220330.txt)

Marcos Perez commented

2022-04-20 11:21:04 +02:00

Added subscriber: @pistolario

Philipp Oeser commented

2022-04-20 16:46:05 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-04-20 16:46:05 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-04-20 16:46:05 +02:00

Can confirm

BLI_assert failed: source/blender/blenkernel/intern/sound.c:250, sound_verify_evaluated_id(), at 'id->tag & (LIB_TAG_COPIED_ON_WRITE | LIB_TAG_COPIED_ON_WRITE_EVAL_RESULT | LIB_TAG_NO_MAIN)'
Aborted (core dumped)

1  __pthread_kill_implementation                                               0x7ffff7a90f0c 
2  raise                                                                       0x7ffff7a40a36 
3  abort                                                                       0x7ffff7a2a82f 
4  _BLI_assert_abort                                BLI_assert.c         46    0x10d5edfe     
5  sound_verify_evaluated_id                        sound.c              250   0x3f814e1      
6  BKE_sound_load                                   sound.c              593   0x3f814e1      
7  sound_pack_exec                                  sound_ops.c          764   0x5869f46      
8  wm_operator_invoke                               wm_event_system.c    1400  0x45c5082      
9  wm_operator_call_internal                        wm_event_system.c    1593  0x45c56da      
10 WM_operator_name_call_ptr                        wm_event_system.c    1641  0x45c58db      
11 WM_operator_name_call_ptr_with_depends_on_cursor wm_event_system.c    1833  0x45c5e93      
12 ui_apply_but_funcs_after                         interface_handlers.c 1008  0x592312f      
13 ui_handler_region_menu                           interface_handlers.c 11396 0x593f848      
14 wm_handler_ui_call                               wm_event_system.c    736   0x45c352a      
15 wm_handlers_do_intern                            wm_event_system.c    3116  0x45c93cf      
16 wm_handlers_do                                   wm_event_system.c    3235  0x45c998e      
17 wm_event_do_handlers                             wm_event_system.c    3825  0x45cb842      
18 WM_main                                          wm.c                 623   0x45bce4e      
19 main                                             creator.c            547   0x3d87c74

Can confirm ``` BLI_assert failed: source/blender/blenkernel/intern/sound.c:250, sound_verify_evaluated_id(), at 'id->tag & (LIB_TAG_COPIED_ON_WRITE | LIB_TAG_COPIED_ON_WRITE_EVAL_RESULT | LIB_TAG_NO_MAIN)' Aborted (core dumped) ``` ``` 1 __pthread_kill_implementation 0x7ffff7a90f0c 2 raise 0x7ffff7a40a36 3 abort 0x7ffff7a2a82f 4 _BLI_assert_abort BLI_assert.c 46 0x10d5edfe 5 sound_verify_evaluated_id sound.c 250 0x3f814e1 6 BKE_sound_load sound.c 593 0x3f814e1 7 sound_pack_exec sound_ops.c 764 0x5869f46 8 wm_operator_invoke wm_event_system.c 1400 0x45c5082 9 wm_operator_call_internal wm_event_system.c 1593 0x45c56da 10 WM_operator_name_call_ptr wm_event_system.c 1641 0x45c58db 11 WM_operator_name_call_ptr_with_depends_on_cursor wm_event_system.c 1833 0x45c5e93 12 ui_apply_but_funcs_after interface_handlers.c 1008 0x592312f 13 ui_handler_region_menu interface_handlers.c 11396 0x593f848 14 wm_handler_ui_call wm_event_system.c 736 0x45c352a 15 wm_handlers_do_intern wm_event_system.c 3116 0x45c93cf 16 wm_handlers_do wm_event_system.c 3235 0x45c998e 17 wm_event_do_handlers wm_event_system.c 3825 0x45cb842 18 WM_main wm.c 623 0x45bce4e 19 main creator.c 547 0x3d87c74 ```

Philipp Oeser changed title from ~~Assert crash when pack sound in blender DEBUG~~ to Assert when pack sound in blender DEBUG

2022-04-20 16:46:15 +02:00

Bastien Montagne commented

2022-05-06 14:41:45 +02:00

Added subscribers: @Sergey, @dr.sybren, @mont29

Bastien Montagne commented

2022-05-06 14:41:46 +02:00

This call to BKE_sound_load looks horribly old (from 2008! code) and wrong to me in context of new evaluation with depsgraph, I would expect rather something like that here:

diff --git a/source/blender/editors/sound/sound_ops.c b/source/blender/editors/sound/sound_ops.c
index a63ed142ed8..2f50569c1a8 100644
--- a/source/blender/editors/sound/sound_ops.c
+++ b/source/blender/editors/sound/sound_ops.c
@@ -761,7 +761,7 @@ static int sound_pack_exec(bContext *C, wmOperator *op)
 
   sound->packedfile = BKE_packedfile_new(
       op->reports, sound->filepath, ID_BLEND_PATH(bmain, &sound->id));
-  BKE_sound_load(bmain, sound);
+  DEG_id_tag_update_ex(bmain, &sound->id, ID_RECALC_AUDIO | ID_RECALC_COPY_ON_WRITE);
 
   return OPERATOR_FINISHED;
 }

@Sergey or @dr.sybren, thoughts?

This call to `BKE_sound_load` looks horribly old (from 2008! code) and wrong to me in context of new evaluation with depsgraph, I would expect rather something like that here: ``` diff --git a/source/blender/editors/sound/sound_ops.c b/source/blender/editors/sound/sound_ops.c index a63ed142ed8..2f50569c1a8 100644 --- a/source/blender/editors/sound/sound_ops.c +++ b/source/blender/editors/sound/sound_ops.c @@ -761,7 +761,7 @@ static int sound_pack_exec(bContext *C, wmOperator *op) sound->packedfile = BKE_packedfile_new( op->reports, sound->filepath, ID_BLEND_PATH(bmain, &sound->id)); - BKE_sound_load(bmain, sound); + DEG_id_tag_update_ex(bmain, &sound->id, ID_RECALC_AUDIO | ID_RECALC_COPY_ON_WRITE); return OPERATOR_FINISHED; } ``` @Sergey or @dr.sybren, thoughts?

Sergey Sharybin commented

2022-05-06 14:50:24 +02:00

@mont29 Using DEG_id_tag_update_ex instead of BKE_sound_load is correct. The only thing is that flag should just be ID_RECALC_AUDIO. Basically you almost never want to use explicit ID_RECALC_COPY_ON_WRITE.

@mont29 Using `DEG_id_tag_update_ex` instead of `BKE_sound_load` is correct. The only thing is that flag should just be `ID_RECALC_AUDIO`. Basically you almost never want to use explicit `ID_RECALC_COPY_ON_WRITE`.

Bastien Montagne commented

2022-05-06 14:58:33 +02:00

@Sergey thanks, will commit fix then

blender-admin commented

2022-05-06 15:05:26 +02:00

This issue was referenced by acafc7327e

This issue was referenced by acafc7327ec94358d7b9599a153c509989b809ed

Bastien Montagne commented

2022-05-06 15:06:50 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Bastien Montagne closed this issue

2022-05-06 15:06:50 +02:00

Bastien Montagne self-assigned this 2022-05-06 15:06:50 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Assert when pack sound in blender DEBUG #97466