Dope Sheet standard mode does not show Grease Pencil keyframes #97477

New Issue

Matias Mendiola · 2022-04-20T17:15:47+02:00

Matias Mendiola commented

2022-04-20 17:15:47 +02:00

System Information
Operating system: Windows-10-10.0.19041-SP0 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89

Blender Version
Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: cc66d1020c
Worked: N/A

Short description of error
even though the Dope Sheet Filter options show the Grease Pencil option, the Dope Sheet does not show any Grese Pencil keyframe in the standard mode.

Exact steps for others to reproduce the error

Add a Grease Pencil to the scene.
Draw some keyframes.
Open the Dope Sheet editor in the standrad mode and see that no keyframe is showing up even though the Grease Pencil filter is on.

**System Information** Operating system: Windows-10-10.0.19041-SP0 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 460.89 **Blender Version** Broken: version: 3.1.2, branch: master, commit date: 2022-03-31 17:40, hash: `cc66d1020c` Worked: N/A **Short description of error** even though the Dope Sheet Filter options show the Grease Pencil option, the Dope Sheet does not show any Grese Pencil keyframe in the standard mode. ![gpencil_dopesheet_bug.jpg](https://archive.blender.org/developer/F13012517/gpencil_dopesheet_bug.jpg) **Exact steps for others to reproduce the error** - Add a Grease Pencil to the scene. - Draw some keyframes. - Open the Dope Sheet editor in the standrad mode and see that no keyframe is showing up even though the Grease Pencil filter is on.

Matias Mendiola commented

2022-04-20 17:15:47 +02:00

Added subscriber: @mendio

Germano Cavalcante commented

2022-04-20 23:31:49 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-04-20 23:31:49 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Germano Cavalcante commented

2022-04-20 23:31:49 +02:00

Not sure if it's a bug, although I would expect the Dope Sheet mode to display all sorts of keyframes. (dope-sheet-modes )
I think it's something for the #animation_rigging or #grease_pencil team to clarify.

Not sure if it's a bug, although I would expect the `Dope Sheet` mode to display all sorts of keyframes. ([dope-sheet-modes ](https://docs.blender.org/manual/en/3.2/editors/dope_sheet/introduction.html#dope-sheet-modes)) I think it's something for the #animation_rigging or #grease_pencil team to clarify.

Antonio Vazquez commented

2022-04-21 10:49:50 +02:00

Added subscriber: @antoniov

Antonio Vazquez commented

2022-04-21 10:49:50 +02:00

We have opened this task to annotate this request that is not 100% a bug, but a missing important feature.

Antonio Vazquez commented

2022-04-21 10:49:58 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Antonio Vazquez commented

2022-04-21 10:50:20 +02:00

Added subscriber: @pablovazquez

Antonio Vazquez commented

2022-04-21 10:50:42 +02:00

Removed subscribers: @antoniov, @mendio

Aleš Jelovčan commented

2022-04-21 11:21:52 +02:00

Added subscriber: @frogstomp-4

Aleš Jelovčan commented

2022-04-21 11:21:52 +02:00

There is also an addon addressing this, but last time I checked it was not mature enough, I'm checking with the author on the progress of it.
Addon: https://gitlab.com/andarta.pictures/blender/gp-dopesheets

Point being: depends on scope of the task of course, given the limited core team... maybe it is best to be left to community efforts that are already on the way.

There is also an addon addressing this, but last time I checked it was not mature enough, I'm checking with the author on the progress of it. Addon: https://gitlab.com/andarta.pictures/blender/gp-dopesheets Point being: depends on scope of the task of course, given the limited core team... maybe it is best to be left to community efforts that are already on the way.

Pablo Vazquez commented

2022-04-21 11:41:18 +02:00

Added subscriber: @antoniov

Pablo Vazquez commented

2022-04-21 11:41:18 +02:00

In #97477#1344437, @antoniov wrote:
We have opened this task to annotate this request that is not 100% a bug

I would consider this a bug. The filter has no effect, as far as I can tell.

So either the filter should be removed from the menu (hopefully in favor of introducing a way to show all types of keyframes from other modes too, such as Mask or Cache). Or it should at least show Grease Pencil keyframes as expected.

> In #97477#1344437, @antoniov wrote: > We have opened this task to annotate this request that is not 100% a bug I would consider this a bug. The filter has no effect, as far as I can tell. So either the filter should be removed from the menu (hopefully in favor of introducing a way to show all types of keyframes from other modes too, such as Mask or Cache). Or it should at least show Grease Pencil keyframes as expected.

Matias Mendiola commented

2022-04-21 11:48:53 +02:00

Totally agree with @pablovazquez , If the Grease Pencil filter button is not working as expected we should consider this a bug

Amélie Fondevilla commented

2022-05-10 16:37:20 +02:00

Added subscriber: @amelief

Amélie Fondevilla commented

2022-05-10 16:37:20 +02:00

FYI I'm starting to try and tackle this issue, unless someone else is working on it already ?

Nate Rupsis commented

2022-05-10 17:27:12 +02:00

Added subscriber: @nrupsis

Nate Rupsis commented

2022-05-10 17:27:12 +02:00

@amelief generally if someone is working on it, they would assign themselves to the task.

If you want to work on / claim this task, I would go ahead and assign it to yourself.

@amelief *generally* if someone is working on it, they would assign themselves to the task. If you want to work on / claim this task, I would go ahead and assign it to yourself.

Amélie Fondevilla was assigned by Matias Mendiola

2022-05-10 18:55:50 +02:00

Amélie Fondevilla commented

2022-05-13 09:44:11 +02:00

I've been going through the code, and my understanding of it is the following. So far, I've been able to add the gplayers keyframes in the dopesheet, BUT it fails in most operations, such as translating a keyframe or switching to graph mode. I believe this is because every channel in the dopesheet is assumed to have a F-curve (while GPlayers dont).

I found that many operations act differently whether the context is ANIMCONT_DOPESHEET or ANIMCONT_GPENCIL. Maybe the solution is to have different behavior within the channels of the ANIMCONT_DOPESHEETto filter channels that dont have F-curves. It seems like it was already discussed as I see some commented code mentioning an ANIMFILTER_CURVESONLY (e.g. transform_convert_action.c:779) which could be used to filter such channel, but it does not seem to be implemented.

My main question is, in order to get this bug fixed, should I go on with this and try to implement this filter, or would someone be against going in that direction or advice otherwise ?

I've been going through the code, and my understanding of it is the following. So far, I've been able to add the gplayers keyframes in the dopesheet, BUT it fails in most operations, such as translating a keyframe or switching to graph mode. I believe this is because every channel in the dopesheet is assumed to have a F-curve (while GPlayers dont). I found that many operations act differently whether the context is `ANIMCONT_DOPESHEET` or `ANIMCONT_GPENCIL`. Maybe the solution is to have different behavior within the channels of the `ANIMCONT_DOPESHEET`to filter channels that dont have F-curves. It seems like it was already discussed as I see some commented code mentioning an `ANIMFILTER_CURVESONLY` (e.g. transform_convert_action.c:779) which could be used to filter such channel, but it does not seem to be implemented. My main question is, in order to get this bug fixed, should I go on with this and try to implement this filter, or would someone be against going in that direction or advice otherwise ?

Antonio Vazquez commented

2022-05-13 10:08:29 +02:00

Added subscriber: @dr.sybren

Antonio Vazquez commented

2022-05-13 10:08:29 +02:00

@dr.sybren Could you help to @amelief in the problem she has.

Falk David commented

2022-05-13 12:54:08 +02:00

Added subscriber: @filedescriptor

Yann Lanthony commented

2022-05-13 12:55:17 +02:00

Added subscriber: @yann-lty

Sybren A. Stüvel commented

2022-05-17 11:34:50 +02:00

In #97477#1357928, @amelief wrote:
Maybe the solution is to have different behavior within the channels of the ANIMCONT_DOPESHEETto filter channels that dont have F-curves. It seems like it was already discussed as I see some commented code mentioning an ANIMFILTER_CURVESONLY (e.g. transform_convert_action.c:779) which could be used to filter such channel, but it does not seem to be implemented.

My main question is, in order to get this bug fixed, should I go on with this and try to implement this filter

Please do! Maybe you can "rename" it (between quotes because it doesn't even exist yet) to ANIMFILTER_FCURVESONLY, that way it's clear that it's about the FCurves (and not curve objects).

> In #97477#1357928, @amelief wrote: > Maybe the solution is to have different behavior within the channels of the `ANIMCONT_DOPESHEET`to filter channels that dont have F-curves. It seems like it was already discussed as I see some commented code mentioning an `ANIMFILTER_CURVESONLY` (e.g. transform_convert_action.c:779) which could be used to filter such channel, but it does not seem to be implemented. > > My main question is, in order to get this bug fixed, should I go on with this and try to implement this filter Please do! Maybe you can "rename" it (between quotes because it doesn't even exist yet) to `ANIMFILTER_FCURVESONLY`, that way it's clear that it's about the FCurves (and not curve objects).

Amélie Fondevilla commented

2022-05-20 17:42:01 +02:00

Still needs some work, but here is a first try to solve this issue.

This is in the description, but here are 3 specific things I don't know how to do :

change icon in the layers group channel : for now it is the pencil icon, but it may be more logical to have the layers icon here
update keyframe display when adding a keyframe in autokeying mode : works in the GP dopesheet, but not in the main one for gplayers. I've looked all over the code, and did not find where to add a notifier or such
cleaning function : i've spotted at least one function that needs to be changed to properly clean memory (transform_convert_action.c:858), but I don't exactly know how to look for other ones and fix them.

Still needs some work, but here is a first try to solve this issue. This is in the description, but here are 3 specific things I don't know how to do : - change icon in the layers group channel : for now it is the pencil icon, but it may be more logical to have the layers icon here - update keyframe display when adding a keyframe in autokeying mode : works in the GP dopesheet, but not in the main one for gplayers. I've looked all over the code, and did not find where to add a notifier or such - cleaning function : i've spotted at least one function that needs to be changed to properly clean memory (transform_convert_action.c:858), but I don't exactly know how to look for other ones and fix them.

Aleš Jelovčan commented

2022-05-20 17:57:12 +02:00

@amelief thanks for working on this, just tried, loved it already!

Antonio Vazquez commented

2022-05-23 10:27:54 +02:00

@amelief IIRC all icons definitions are done in anim_channels_defines.c

@amelief IIRC all icons definitions are done in `anim_channels_defines.c`

Amélie Fondevilla commented

2022-05-23 11:27:37 +02:00

In #97477#1362791, @antoniov wrote:
@amelief IIRC all icons definitions are done in anim_channels_defines.c

Thanks, I found it !

> In #97477#1362791, @antoniov wrote: > @amelief IIRC all icons definitions are done in `anim_channels_defines.c` Thanks, I found it !

Amélie Fondevilla commented

2022-05-25 15:26:18 +02:00

I worked on the selection-in-dopesheet-summary issue, and it seems to imply some changes in the current code, I kind of need advice and/or approval from both grease pencil and animation team on this.

Since it is a bit complex to explain, I started a devtalk on it, idk whether it's good pratice or not. If not I can always remove it to have the discussion here. Anyways, it's there : https://devtalk.blender.org/t/gpencil-layers-integration-in-main-dopesheet-selection-issue/24527

I worked on the selection-in-dopesheet-summary issue, and it seems to imply some changes in the current code, I kind of need advice and/or approval from both grease pencil and animation team on this. Since it is a bit complex to explain, I started a devtalk on it, idk whether it's good pratice or not. If not I can always remove it to have the discussion here. Anyways, it's there : https://devtalk.blender.org/t/gpencil-layers-integration-in-main-dopesheet-selection-issue/24527

Falk David commented

2022-05-25 15:43:30 +02:00

Yes, for these more complicated questions, devtalk is the way to go. To me it looks like this will have to be answered by the animation module. I would suggest to post the link in the animation-module channel on blender.chat. (I see that you asked that question there as well).

Yes, for these more complicated questions, devtalk is the way to go. To me it looks like this will have to be answered by the animation module. I would suggest to post the link in the `animation-module` channel on blender.chat. (I see that you asked that question there as well).

Amélie Fondevilla commented

2022-05-25 15:54:25 +02:00

In #97477#1364200, @filedescriptor wrote:
Yes, for these more complicated questions, devtalk is the way to go. To me it looks like this will have to be answered by the animation module. I would suggest to post the link in the animation-module channel on blender.chat. (I see that you asked that question there as well).

Yea ok, thanks, I posted it on the chat

> In #97477#1364200, @filedescriptor wrote: > Yes, for these more complicated questions, devtalk is the way to go. To me it looks like this will have to be answered by the animation module. I would suggest to post the link in the `animation-module` channel on blender.chat. (I see that you asked that question there as well). Yea ok, thanks, I posted it on the chat

Denis Briant commented

2022-05-30 11:55:31 +02:00

Added subscriber: @DenisB

Amélie Fondevilla commented

2022-06-02 16:35:11 +02:00

Some update on this issue.
So, good news is, it's not actually a bug ! The filter has an effect on gpencil animation data.
What I mean is if you animate any property of a grease pencil object data panel, then it will show up on the main dopesheet and can be hidden with the filter (like "X Location (Fill)" in the image).
That's it. Problem solved. Hurray !

Just kidding, we still need to put these GPLayers in the dopesheet..
The fact that gpencil animation data appears in the same group in the dopesheet seems to be an issue for including GPlayers in the GPencilData summary, I think because it only takes into account "action channels"..
Actually, you may notice that the GPencil summary is also not done properly in the grease pencil dopesheet, and the same problem occurs when animating node properties in a 3D material.

Sooo, I don't know what to do with this. Should GPLayers be in a specific 'green' subgroup like "Object Transforms" ? (not sure this will solve the problem though..)

Some update on this issue. So, good news is, it's not actually a bug ! The filter has an effect on gpencil animation data. What I mean is if you animate any property of a grease pencil object data panel, then it will show up on the main dopesheet and can be hidden with the filter (like "X Location (Fill)" in the image). That's it. Problem solved. Hurray ! Just kidding, we still need to put these GPLayers in the dopesheet.. The fact that gpencil animation data appears in the same group in the dopesheet seems to be an issue for including GPlayers in the GPencilData summary, I think because it only takes into account "action channels".. Actually, you may notice that the GPencil summary is also not done properly in the grease pencil dopesheet, and the same problem occurs when animating node properties in a 3D material. ![summary_issue-annotated.png](https://archive.blender.org/developer/F13129327/summary_issue-annotated.png) Sooo, I don't know what to do with this. Should GPLayers be in a specific 'green' subgroup like "Object Transforms" ? (not sure this will solve the problem though..)

Falk David commented

2022-06-02 17:12:15 +02:00

Added subscriber: @lichtwerk

Falk David commented

2022-06-02 17:12:15 +02:00

So, good news is, it's not actually a bug ! The filter has an effect on gpencil animation data.

Ah! I guess this does make sense. Maybe we should close this task then and open a new one for the feature you are working on. @lichtwerk how would you handle this?

Sooo, I don't know what to do with this. Should GPLayers be in a specific 'green' subgroup like "Object Transforms" ? (not sure this will solve the problem though..)

I would not worry about keyframes not showing in the summary for now. It looks like this could be reported as another issue.
Displaying layers in a subgroup would make sense to me. That would separate them cleanly from animated properties. But it might also cause too much indentation so that might be a counter argument.

> So, good news is, it's not actually a bug ! The filter has an effect on gpencil animation data. Ah! I guess this does make sense. Maybe we should close this task then and open a new one for the feature you are working on. @lichtwerk how would you handle this? > Sooo, I don't know what to do with this. Should GPLayers be in a specific 'green' subgroup like "Object Transforms" ? (not sure this will solve the problem though..) I would not worry about keyframes not showing in the summary for now. It looks like this could be reported as another issue. Displaying layers in a subgroup would make sense to me. That would separate them cleanly from animated properties. But it might also cause too much indentation so that might be a counter argument.

Amélie Fondevilla commented

2022-06-20 16:31:30 +02:00

Hi ! I feel like the patch is ready for further review.
Two things are still missing : summaries (as discussed above), and graying out some fcurves related operators in the dopesheet menu. Though, it seems like they both correspond to a pre-existing behavior, so they could be dealed with in a separate issue, as suggested by Falk David.

It would be great if someone could review the code :)

Hi ! I feel like the patch is ready for further review. Two things are still missing : summaries (as discussed above), and graying out some fcurves related operators in the dopesheet menu. Though, it seems like they both correspond to a pre-existing behavior, so they could be dealed with in a separate issue, as suggested by Falk David. It would be great if someone could review the code :)

blender-admin commented

2022-06-30 15:16:05 +02:00

This issue was referenced by 92d7f9ac56

This issue was referenced by 92d7f9ac56e0ff1e65c364487542dfb7c32a0a67

Antonio Vazquez commented

2022-07-03 19:40:01 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Antonio Vazquez closed this issue

2022-07-03 19:40:01 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Dope Sheet standard mode does not show Grease Pencil keyframes #97477