Crash when adding multiple Adjustment layers and then deleting one of them #97507

New Issue

a · 2022-04-21T12:26:07+02:00

a commented

2022-04-21 12:26:07 +02:00

System Information
Operating system: Windows 8.1
Graphics card: NVIDIA GeForce GT 750M (5+years old)

Blender Version
Broken: 3.2.0 Alpha 2882cbe685
Worked: 3.1.0

Adding multiple Adjustment layers, and then deleting one of them will cause a crash. Reported to be an access violation.

Exact steps for others to reproduce the error

Default startup
Change Editor Type to 'Video Sequencer'
Change View Type to 'Sequencer & Preview'
Add adjustment layer
Add second adjustment layer
Add third adjustment layer
Add curves modifier to third adjustment layer
Delete first adjustment layer (using keyboard X key in VSE)
Crash

Supporting Video

https://youtu.be/YR_a8uQv1es

**System Information** Operating system: Windows 8.1 Graphics card: NVIDIA GeForce GT 750M (5+years old) **Blender Version** Broken: 3.2.0 Alpha 2882cbe685e7 Worked: 3.1.0 Adding multiple Adjustment layers, and then deleting one of them will cause a crash. Reported to be an access violation. **Exact steps for others to reproduce the error** 1. Default startup 2. Change Editor Type to 'Video Sequencer' 3. Change View Type to 'Sequencer & Preview' 4. Add adjustment layer 5. Add second adjustment layer 6. Add third adjustment layer 7. Add curves modifier to third adjustment layer 8. Delete first adjustment layer (using keyboard X key in VSE) 9. Crash **Supporting Video** https://youtu.be/YR_a8uQv1es

a commented

2022-04-21 12:26:07 +02:00

Added subscriber: @blenderbug12345

a commented

2022-04-21 12:26:37 +02:00

system-info.txt

[system-info.txt](https://archive.blender.org/developer/F13014078/system-info.txt)

a commented

2022-04-21 12:28:43 +02:00

blender.crash.txt

[blender.crash.txt](https://archive.blender.org/developer/F13014083/blender.crash.txt)

Pratik Borhade commented

2022-04-22 05:30:20 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-04-22 05:30:20 +02:00

Thanks for the report. I cannot reproduce anymore on current master.
Crash is already fixed by 3cef9ebaf8
Please download and test latest 3.2 build from buildbot: https://builder.blender.org/download/daily
Feel free to comment if you can still replicate crash.

Thanks for the report. I cannot reproduce anymore on current master. Crash is already fixed by 3cef9ebaf8 Please download and test latest 3.2 build from buildbot: https://builder.blender.org/download/daily Feel free to comment if you can still replicate crash.

Pratik Borhade commented

2022-04-22 05:30:39 +02:00

Closed as duplicate of #97356

Pratik Borhade closed this issue

2022-04-22 05:30:39 +02:00

a commented

2022-04-22 10:45:30 +02:00

The crash is still there in blender-3.2.0-alpha+master.179100c02126-windows.amd64-release

a commented

2022-04-22 11:19:39 +02:00

I added a video demonstrating the crash on 179100c021

https://youtu.be/YR_a8uQv1es

I added a video demonstrating the crash on 179100c02126 https://youtu.be/YR_a8uQv1es

Pratik Borhade commented

2022-04-22 11:23:32 +02:00

Changed status from 'Duplicate' to: 'Confirmed'

Pratik Borhade reopened this issue

2022-04-22 11:23:32 +02:00

Pratik Borhade commented

2022-04-22 11:23:32 +02:00

Added subscriber: @iss

Pratik Borhade commented

2022-04-22 11:23:32 +02:00

Yes, can confirm. Crash does not occur if preview window is not active
cc @iss

Yes, can confirm. Crash does not occur if preview window is not active cc @iss

Pratik Borhade changed title from ~~EXCEPTION_ACCESS_VIOLATION when adding multiple Adjustment layers, and then deleting one of them~~ to Crash when adding multiple Adjustment layers and then deleting one of them

2022-04-22 11:23:53 +02:00

a commented

2022-04-30 14:04:38 +02:00

Bump!

The current definition of SEQ_get_channels_by_seq is broken, it doesn't return channels. I think the idea was to do this instead:

ListBase *SEQ_get_channels_by_seq(ListBase *seqbase, ListBase *channels, const Sequence *seq)
{
  ListBase *lb = NULL;

  LISTBASE_FOREACH (Sequence *, iseq, seqbase) {
    if (seq == iseq) {
      return channels;
    }
    if ((lb = SEQ_get_channels_by_seq(&iseq->seqbase, &iseq->channels, seq))) {
      return lb;
    }
  }

  return NULL;
}

This code works for me when tested against the steps which crash the VSE.

Bump! The current definition of SEQ_get_channels_by_seq is broken, it doesn't return channels. I think the idea was to do this instead: ``` ListBase *SEQ_get_channels_by_seq(ListBase *seqbase, ListBase *channels, const Sequence *seq) { ListBase *lb = NULL; LISTBASE_FOREACH (Sequence *, iseq, seqbase) { if (seq == iseq) { return channels; } if ((lb = SEQ_get_channels_by_seq(&iseq->seqbase, &iseq->channels, seq))) { return lb; } } return NULL; } ``` This code works for me when tested against the steps which crash the VSE.

a commented

2022-04-30 14:06:21 +02:00

Called as:

...
ListBase *channels = SEQ_get_channels_by_seq(&ed->seqbase, &ed->channels, seq);
...

Called as: ... ListBase *channels = SEQ_get_channels_by_seq(&ed->seqbase, &ed->channels, seq); ...

Richard Antalik commented

2022-05-02 14:05:11 +02:00

@blenderbug12345 Thanks for snippet, your code is correct. I was confused for a bit before I noticed pointer to seqbase is being returned.

blender-admin commented

2022-05-02 18:20:56 +02:00

This issue was referenced by 38a4d96a90

This issue was referenced by 38a4d96a9061808677d3bc770f1482766fe3f3ed

Richard Antalik commented

2022-05-03 09:09:15 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Richard Antalik closed this issue

2022-05-03 09:09:15 +02:00

Richard Antalik self-assigned this 2022-05-03 09:09:15 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when adding multiple Adjustment layers and then deleting one of them #97507