NLA track option buttons can be interacted with even when hidden #97529

New Issue

Colin Basnett · 2022-04-22T02:28:02+02:00

Colin Basnett commented

2022-04-22 02:28:02 +02:00

System Information
Operating system: Windows 10
Graphics card: NVIDIA GTX 1070

Blender Version
Broken: 3.1
Worked: Probably never

Short description of error
The NLA track options (mute & lock) are able to be interacted with even when they have been hidden as a result of another track being "solo'd".

I'm not sure why these elements are being hidden when other tracks are in solo mode. I think the solution here is to just not hide these options.

Exact steps for others to reproduce the error

Make a bunch of NLA tracks
"Solo" one of the tracks
Click around where the mute & lock buttons used to be on non-solo'd tracks

**System Information** Operating system: Windows 10 Graphics card: NVIDIA GTX 1070 **Blender Version** Broken: 3.1 Worked: Probably never **Short description of error** The NLA track options (mute & lock) are able to be interacted with even when they have been hidden as a result of another track being "solo'd". ![solowhatareyadoinbud.gif](https://archive.blender.org/developer/F13015138/solowhatareyadoinbud.gif) I'm not sure why these elements are being hidden when other tracks are in solo mode. I think the solution here is to just not hide these options. **Exact steps for others to reproduce the error** 1. Make a bunch of NLA tracks 2. "Solo" one of the tracks 3. Click around where the mute & lock buttons used to be on non-solo'd tracks

Colin Basnett commented

2022-04-22 02:28:02 +02:00

Added subscriber: @cmbasnett

Brad Clark commented

2022-04-22 03:53:50 +02:00

Added subscriber: @BClark

Brad Clark commented

2022-04-22 04:03:59 +02:00

Great bug find.

I expect the UI change that does the solo to lock selection (meaning it should completely lock away the interaction with those buttons.

Right now it seems to "hide" the display only visually /theme change.

Great bug find. I expect the UI change that does the solo to lock selection (meaning it should completely lock away the interaction with those buttons. Right now it seems to "hide" the display only visually /theme change.

Colin Basnett commented

2022-04-22 20:55:20 +02:00

In #97529#1344869, @BClark wrote:
I expect the UI change that does the solo to lock selection (meaning it should completely lock away the interaction with those buttons.

Other software (specifically audio software like Reaper) allows you to interact with the mute/solo status of all tracks regardless of the status of other tracks. I don't know why Blender users would want to hide these controls hidden; it just creates a hassle for the user because the muting/soloing have to be done in a specific order otherwise the buttons mysteriously disappear on you.

> In #97529#1344869, @BClark wrote: > I expect the UI change that does the solo to lock selection (meaning it should completely lock away the interaction with those buttons. Other software (specifically audio software like Reaper) allows you to interact with the mute/solo status of all tracks regardless of the status of other tracks. I don't know why Blender users would want to hide these controls hidden; it just creates a hassle for the user because the muting/soloing have to be done in a specific order otherwise the buttons mysteriously disappear on you.

Brad Clark commented

2022-04-22 21:06:06 +02:00

Yeah, I think not hiding everything and just doing a shade change would be better than hiding all the other tracks and buttons. In the code can you tell if it is just an overlay or it is really turning off the display of the buttons?

Richard Antalik commented

2022-04-26 03:53:00 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Colin Basnett commented

2022-05-04 11:33:57 +02:00

Alright, did some light investigation here. There's two different problems.

One is the UX problem that the buttons are made hidden when they shouldn't be. This can be easily changed by removing this bit of code in acf_nlatrack_setting_valid:

        /* is track enabled for solo drawing? */
        if ((adt) && (adt->flag & ADT_NLA_SOLO_TRACK)) {
          if (nlt->flag & NLATRACK_SOLO) {
            /* ok - we've got a solo track, and this is it */
            return true;
          }
          /* not ok - we've got a solo track, but this isn't it, so make it more obvious */
          return false;
        }

The second and more insidious bug is that you can interact with buttons that frankly shouldn't even be there. As far as I can tell, the buttons shouldn't be rendered or added to the UI scene, so I'm not clear as to how this is happening. Will pick this up later.

Alright, did some light investigation here. There's two different problems. One is the UX problem that the buttons are made hidden when they shouldn't be. This can be easily changed by removing this bit of code in `acf_nlatrack_setting_valid`: ``` /* is track enabled for solo drawing? */ if ((adt) && (adt->flag & ADT_NLA_SOLO_TRACK)) { if (nlt->flag & NLATRACK_SOLO) { /* ok - we've got a solo track, and this is it */ return true; } /* not ok - we've got a solo track, but this isn't it, so make it more obvious */ return false; } ``` The second and more insidious bug is that you can interact with buttons that frankly shouldn't even be there. As far as I can tell, the buttons shouldn't be rendered or added to the UI scene, so I'm not clear as to how this is happening. Will pick this up later.

Philipp Oeser commented

2022-05-04 13:14:03 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-05-04 13:14:03 +02:00

Weird.
This does not go through achannel_setting_flush_widget_cb.
This does not got through ANIM_channel_setting_set.
Instead, this has an additional handling in mouse_nla_channels

Assume this could go all together? (or at least should be checked with something like bAnimChannelType->has_setting)

Weird. This does not go through `achannel_setting_flush_widget_cb`. This does not got through `ANIM_channel_setting_set`. Instead, this has an additional handling in [mouse_nla_channels ](https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_nla/nla_channels.c$224) Assume this could go all together? (or at least should be checked with something like `bAnimChannelType`->`has_setting`)

Colin Basnett commented

2022-05-06 00:50:09 +02:00

mouse_nla_channels is still responsible for actually selecting channels. The more modern button system doesn't handle that.

If I nullify the mouse_nla_channels function (by just throwing a return at the top), all the buttons (solo, mute, lock) work as expected, but I am unable to select the channel.

Presumably we could just pull out the button handling code. This code note even implies as much:

 * NOTE: eventually,
 * this should probably be phased out when many of these things are replaced with buttons

I'll see what I can do to surgically remove this from that function while keeping everything else intact.

`mouse_nla_channels` is still responsible for actually selecting channels. The more modern button system doesn't handle that. If I nullify the `mouse_nla_channels` function (by just throwing a return at the top), all the buttons (solo, mute, lock) work as expected, but I am unable to select the channel. Presumably we could just pull out the button handling code. This code note even implies as much: ``` * NOTE: eventually, * this should probably be phased out when many of these things are replaced with buttons ``` I'll see what I can do to surgically remove this from that function while keeping everything else intact.

blender-admin commented

2022-05-09 12:12:20 +02:00

This issue was referenced by 4ac6177b8d

This issue was referenced by 4ac6177b8d676d9e678126af71067cad3674ff3b

Sybren A. Stüvel commented

2022-05-09 12:17:06 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2022-05-09 12:17:06 +02:00

Sybren A. Stüvel self-assigned this 2022-05-09 12:17:06 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

NLA track option buttons can be interacted with even when hidden #97529