Renaming bone in Edit Mode then undoing does not update animation channel/group names #97723

New Issue

Cigitia · 2022-04-29T21:36:21+02:00

Cigitia commented

2022-04-29 21:36:21 +02:00

System Information
Operating system: macOS Monterey 12.2.1
Graphics card: MacBook Air (M1, 2020)

Blender Version
Broken: 3.1.2, cc66d1020c, master, 2022-03-31

Short description of error
Renaming bones in Edit Mode also renames its animation channels and its channel group, which is very nice. However, undoing the bone renaming does not revert the names of its animation channels and its channel group. (Undo does work if the bone is renamed in Pose Mode rather than Edit Mode.)

This is probably related to #82816 (Undo in Armature EditMode ignores changes to other IDs).

Exact steps for others to reproduce the error
Setup:

Start a new blank Blender file. Remove the default cube.
Add an armature (single bone) at the world origin. Make sure that armature is the active object.
Switch to the Animation workspace. The 3D Viewport should be in Pose Mode.
Select the single Bone.
Insert a keyframe (Location, Rotation & Scale) for Bone.
Observe that the Dope Sheet now contains a group of channels named “Bone”, and the ten channels inside it are all for Bone. (Expand the new “Bone” channel group in the Dope Sheet as needed.)

Renaming bone in Pose Mode then undoing works:

Use the Rename Active Item… operator in the Topbar Edit Menu to rename Bone to “Bone.X” (while still remaining in Pose Mode). Observe that the group of channels is also now named “Bone.X”, and the ten channels inside it are all for Bone.X – as expected.
Undo. Observe that the group of channels is also now back to being named “Bone”, and the ten channels inside it are all for Bone – as expected.

Renaming bone in Edit Mode then undoing breaks animation channels:

Switch to armature Edit Mode.
Use the Rename Active Item… operator in the Topbar Edit Menu to rename Bone to “Bone.X” (while still remaining in Pose Mode). Observe that the group of channels is also now named “Bone.X”, and the ten channels inside it are all for Bone.X – as expected.
Undo. Observe that the group of channels is unexpectedly still named “Bone.X”, and the ten channels inside it are all for a nonexistent “Bone.X”.
Switch to Pose Mode. Observe that the channels are now marked with red for error, and they are named “pose.bones["Bone.X"].location”, etc.

**System Information** Operating system: macOS Monterey 12.2.1 Graphics card: MacBook Air (M1, 2020) **Blender Version** Broken: 3.1.2, cc66d1020c3b, master, 2022-03-31 **Short description of error** Renaming bones in Edit Mode also renames its animation channels and its channel group, which is very nice. However, undoing the bone renaming does not revert the names of its animation channels and its channel group. (Undo does work if the bone is renamed in Pose Mode rather than Edit Mode.) This is probably related to #82816 (Undo in Armature EditMode ignores changes to other IDs). **Exact steps for others to reproduce the error** Setup: 1. Start a new blank Blender file. Remove the default cube. 2. Add an armature (single bone) at the world origin. Make sure that armature is the active object. 3. Switch to the Animation workspace. The 3D Viewport should be in Pose Mode. 4. Select the single Bone. 5. Insert a keyframe (Location, Rotation & Scale) for Bone. 6. Observe that the Dope Sheet now contains a group of channels named “Bone”, and the ten channels inside it are all for Bone. (Expand the new “Bone” channel group in the Dope Sheet as needed.) Renaming bone in Pose Mode then undoing works: 1. Use the Rename Active Item… operator in the Topbar Edit Menu to rename Bone to “Bone.X” (while still remaining in Pose Mode). Observe that the group of channels is also now named “Bone.X”, and the ten channels inside it are all for Bone.X – as expected. 2. Undo. Observe that the group of channels is also now back to being named “Bone”, and the ten channels inside it are all for Bone – as expected. Renaming bone in Edit Mode then undoing breaks animation channels: 1. Switch to armature Edit Mode. 2. Use the Rename Active Item… operator in the Topbar Edit Menu to rename Bone to “Bone.X” (while still remaining in Pose Mode). Observe that the group of channels is also now named “Bone.X”, and the ten channels inside it are all for Bone.X – as expected. 3. Undo. Observe that the group of channels is unexpectedly **still** named “Bone.X”, and the ten channels inside it are all for a nonexistent “Bone.X”. 4. Switch to Pose Mode. Observe that the channels are now marked with red for error, and they are named “pose.bones["Bone.X"].location”, etc.

Cigitia commented

2022-04-29 21:36:21 +02:00

Added subscriber: @Cigitia