Regression: Memory leak caused by speed control strip in video sequencer #97744

New Issue

tempdevnova · 2022-04-30T18:47:07+02:00

tempdevnova commented

2022-04-30 18:47:07 +02:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.07

Blender Version
Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: f1cca30557
Worked: 2.83

This broke with 47f98a38d0

Short description of error
Using an image strip in combination with the speed control strip in the video sequencer causes a memory leak in both the viewport and during render.

Exact steps for others to reproduce the error

Test file:
Memory leak.blend
When you try to render this sequence as either individual images or as a video file it will leak memory with each and every frame.
In my orginal file an image sequence worth 400 megabytes of disk space took over 8 gigabytes of ram to render.
What's worse is that when rendering larger sequences it also ignores the memory cache limit set by the user sometimes causing the entire OS to crash.
The memory also isn't freed after the render but instead stays allocated until Blender closes or more often crashes.

The behaviour in the viewport is also interesting. When you drag the frame cursor in the timeline it will cause memory to leak depending over how many frames you drag the cursor until you hit your the memory cache limit set by the user.
However Blender only leaks memory when the image sequence is actually displayed on the screen e.g. through the previewer, otherwise it appears to not leak memory (however I can't 100% confirm that it doesn't).

Thank you and have a great day!

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: GeForce GTX 1080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 431.07 **Blender Version** Broken: version: 3.0.0, branch: master, commit date: 2021-12-02 18:35, hash: `f1cca30557` Worked: 2.83 This broke with 47f98a38d0 **Short description of error** Using an image strip in combination with the speed control strip in the video sequencer causes a memory leak in both the viewport and during render. **Exact steps for others to reproduce the error** Test file: [Memory leak.blend](https://archive.blender.org/developer/F13041932/Memory_leak.blend) When you try to render this sequence as either individual images or as a video file it will leak memory with each and every frame. In my orginal file an image sequence worth 400 megabytes of disk space took over 8 gigabytes of ram to render. What's worse is that when rendering larger sequences it also ignores the memory cache limit set by the user sometimes causing the entire OS to crash. The memory also isn't freed after the render but instead stays allocated until Blender closes or more often crashes. The behaviour in the viewport is also interesting. When you drag the frame cursor in the timeline it will cause memory to leak depending over how many frames you drag the cursor until you hit your the memory cache limit set by the user. However Blender only leaks memory when the image sequence is actually displayed on the screen e.g. through the previewer, otherwise it appears to not leak memory (however I can't 100% confirm that it doesn't). Thank you and have a great day!

tempdevnova commented

2022-04-30 18:47:07 +02:00

Added subscriber: @tempdevnova

tempdevnova commented

2022-04-30 19:02:58 +02:00

Tested in Blender 3.1.2 problem still persists.

Jesse Yurkovich commented

2022-05-01 01:48:09 +02:00

Added subscriber: @deadpin

Jesse Yurkovich commented

2022-05-01 01:48:09 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jesse Yurkovich commented

2022-05-01 01:48:09 +02:00

Loading up the file and rendering out a smaller configuration (10% render, 10 frames) shows quite a few leaked ImBuf structures and buffers:

Error: Not freed memory blocks: 100, total unfreed memory 309.484467 MB
ImBuf_struct len: 2480 00001290368B6CB8
imb_addrectImBuf len: 8294400 000012D465DB1838
ImBuf_struct len: 2480 0000129036B080B8
imb_addrectImBuf len: 8294400 000012D461E11838
ImBuf_struct len: 2480 0000129036C9E8B8
imb_addrectImBuf len: 82944 000012B8368E0838
ImBuf_struct len: 2480 0000129036C988B8
imb_addrectImBuf len: 82944 000012B836958838
ImBuf_struct len: 2480 0000129036C928B8
imb_addrectImBuf len: 82944 000012B836A18838
ImBuf_struct len: 2480 0000129036D2ACB8
imb_addrectImBuf len: 82944 000012B836AD8838

Is out being leaked inside do_speed_effect?

  if (s->flags & SEQ_SPEED_USE_INTERPOLATION) {
    out = prepare_effect_imbufs(context, ibuf1, ibuf2, ibuf3);  // ** Leak?
    fac = speed_effect_interpolation_ratio_get(context->scene, seq, timeline_frame);
    /* Current frame is ibuf1, next frame is ibuf2. */
    out = seq_render_effect_execute_threaded(
        &cross_effect, context, NULL, timeline_frame, fac, ibuf1, ibuf2, ibuf3);
    return out;
  }

Loading up the file and rendering out a smaller configuration (10% render, 10 frames) shows quite a few leaked ImBuf structures and buffers: ``` Error: Not freed memory blocks: 100, total unfreed memory 309.484467 MB ImBuf_struct len: 2480 00001290368B6CB8 imb_addrectImBuf len: 8294400 000012D465DB1838 ImBuf_struct len: 2480 0000129036B080B8 imb_addrectImBuf len: 8294400 000012D461E11838 ImBuf_struct len: 2480 0000129036C9E8B8 imb_addrectImBuf len: 82944 000012B8368E0838 ImBuf_struct len: 2480 0000129036C988B8 imb_addrectImBuf len: 82944 000012B836958838 ImBuf_struct len: 2480 0000129036C928B8 imb_addrectImBuf len: 82944 000012B836A18838 ImBuf_struct len: 2480 0000129036D2ACB8 imb_addrectImBuf len: 82944 000012B836AD8838 ``` Is `out` being leaked inside `do_speed_effect`? ``` if (s->flags & SEQ_SPEED_USE_INTERPOLATION) { out = prepare_effect_imbufs(context, ibuf1, ibuf2, ibuf3); // ** Leak? fac = speed_effect_interpolation_ratio_get(context->scene, seq, timeline_frame); /* Current frame is ibuf1, next frame is ibuf2. */ out = seq_render_effect_execute_threaded( &cross_effect, context, NULL, timeline_frame, fac, ibuf1, ibuf2, ibuf3); return out; } ```

Philipp Oeser commented

2022-05-02 15:39:56 +02:00

Added subscribers: @iss, @lichtwerk

Philipp Oeser commented

2022-05-02 15:39:56 +02:00

This broke with 47f98a38d0

@iss: mind checking?

This broke with 47f98a38d0 @iss: mind checking?

Philipp Oeser changed title from ~~Memory leak caused by speed control strip in video sequencer~~ to Regression: Memory leak caused by speed control strip in video sequencer

2022-05-02 15:41:46 +02:00

blender-admin commented

2022-05-03 10:17:28 +02:00

This issue was referenced by daa9edc9be

This issue was referenced by daa9edc9be7a4837283eb46c8908c7b8eccec0c8

Richard Antalik commented

2022-05-03 10:21:10 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Richard Antalik closed this issue

2022-05-03 10:21:10 +02:00

Richard Antalik self-assigned this 2022-05-03 10:21:10 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Memory leak caused by speed control strip in video sequencer #97744