Crash undoing "Make Library Override" for linked collection with shapekey #98136

New Issue

Georg K · 2022-05-15T11:39:03+02:00

Georg K commented

2022-05-15 11:39:03 +02:00

System Information
Operating system: Linux-5.15.32-1-MANJARO-x86_64-with-glibc2.35 64 Bits
Graphics card: AMD VERDE (DRM 2.50.0, 5.15.32-1-MANJARO, LLVM 13.0.1) AMD 4.5 (Core Profile) Mesa 21.3.8

Blender Version
Broken: 3.1.2, version: 3.3.0 Alpha, branch: master, commit date: 2022-05-13 16:07, hash: fa7224d8ed
Worked: never since 0291039079

Short description of error
Blender crashes when trying to undo "Make Library Override" for a linked collection containing an armature and a mesh with a shapekey driven by a bone if there is a second collection in the source file that contains an armature that shares armature data with the linked armature (or uses a copy of the armature data).
But unfortunately, that description is missing something since it was not possible to create a collection that causes the crash by using just these ingredients.

Exact steps for others to reproduce the error

Link the "Link this" collection from the attached file
use Object - Relations - Make Library Override
press Ctrl-Z
Crash

Crash undoing Make Library Override.blend

error message:

 Blender 3.3.0, Commit date: 2022-05-13 16:07, Hash fa7224d8ed88
bpy.ops.object.select_all(action='SELECT')  # Operator
bpy.ops.object.delete(use_global=False)  # Operator
bpy.context.space_data.bookmarks_active = 0  # Property
bpy.ops.object.make_override_library()  # Operator

 backtrace
./blender(BLI_system_backtrace+0x33) [0xc29ed13]
./blender() [0x118571e]
/usr/lib/libc.so.6(+0x42560) [0x7f3b49a2f560]
./blender(_ZN7blender3deg20DepsgraphNodeBuilder16build_collectionEP15LayerCollectionP10Collection+0x1a) [0x18a632a]
./blender(_ZN7blender3deg20DepsgraphNodeBuilder16build_collectionEP15LayerCollectionP10Collection+0x145) [0x18a6455]
./blender(_ZN7blender3deg20DepsgraphNodeBuilder12build_objectEiP6ObjectNS0_26eDepsNode_LinkedState_TypeEb+0x28e) [0x18a682e]
./blender(_ZN7blender3deg20DepsgraphNodeBuilder16build_view_layerEP5SceneP9ViewLayerNS0_26eDepsNode_LinkedState_TypeE+0xb2) [0x18aa132]
./blender(_ZN7blender3deg23AbstractBuilderPipeline16build_step_nodesEv+0x76) [0x1891d76]
./blender(_ZN7blender3deg23AbstractBuilderPipeline5buildEv+0x42) [0x1891f92]
./blender(DEG_graph_build_from_view_layer+0x31) [0x187a631]
./blender() [0x12a3ecc]
./blender(wm_event_do_depsgraph+0xbb) [0x1712b6b]
./blender(wm_event_do_refresh_wm_and_depsgraph+0x87) [0x1712cb7]
./blender(wm_event_do_notifiers+0x609) [0x171ad09]
./blender(WM_main+0x28) [0x170d778]
./blender(main+0x33a) [0x1087a7a]
/usr/lib/libc.so.6(+0x2d310) [0x7f3b49a1a310]
/usr/lib/libc.so.6(__libc_start_main+0x81) [0x7f3b49a1a3c1]
./blender(_start+0x25) [0x1181d85]

**System Information** Operating system: Linux-5.15.32-1-MANJARO-x86_64-with-glibc2.35 64 Bits Graphics card: AMD VERDE (DRM 2.50.0, 5.15.32-1-MANJARO, LLVM 13.0.1) AMD 4.5 (Core Profile) Mesa 21.3.8 **Blender Version** Broken: 3.1.2, version: 3.3.0 Alpha, branch: master, commit date: 2022-05-13 16:07, hash: `fa7224d8ed` Worked: never since 0291039079 **Short description of error** Blender crashes when trying to undo "Make Library Override" for a linked collection containing an armature and a mesh with a shapekey driven by a bone if there is a second collection in the source file that contains an armature that shares armature data with the linked armature (or uses a copy of the armature data). But unfortunately, that description is missing something since it was not possible to create a collection that causes the crash by using just these ingredients. **Exact steps for others to reproduce the error** - Link the "Link this" collection from the attached file - use Object - Relations - Make Library Override - press Ctrl-Z - Crash [Crash undoing Make Library Override.blend](https://archive.blender.org/developer/F13075351/Crash_undoing_Make_Library_Override.blend) error message: ``` Blender 3.3.0, Commit date: 2022-05-13 16:07, Hash fa7224d8ed88 bpy.ops.object.select_all(action='SELECT') # Operator bpy.ops.object.delete(use_global=False) # Operator bpy.context.space_data.bookmarks_active = 0 # Property bpy.ops.object.make_override_library() # Operator backtrace ./blender(BLI_system_backtrace+0x33) [0xc29ed13] ./blender() [0x118571e] /usr/lib/libc.so.6(+0x42560) [0x7f3b49a2f560] ./blender(_ZN7blender3deg20DepsgraphNodeBuilder16build_collectionEP15LayerCollectionP10Collection+0x1a) [0x18a632a] ./blender(_ZN7blender3deg20DepsgraphNodeBuilder16build_collectionEP15LayerCollectionP10Collection+0x145) [0x18a6455] ./blender(_ZN7blender3deg20DepsgraphNodeBuilder12build_objectEiP6ObjectNS0_26eDepsNode_LinkedState_TypeEb+0x28e) [0x18a682e] ./blender(_ZN7blender3deg20DepsgraphNodeBuilder16build_view_layerEP5SceneP9ViewLayerNS0_26eDepsNode_LinkedState_TypeE+0xb2) [0x18aa132] ./blender(_ZN7blender3deg23AbstractBuilderPipeline16build_step_nodesEv+0x76) [0x1891d76] ./blender(_ZN7blender3deg23AbstractBuilderPipeline5buildEv+0x42) [0x1891f92] ./blender(DEG_graph_build_from_view_layer+0x31) [0x187a631] ./blender() [0x12a3ecc] ./blender(wm_event_do_depsgraph+0xbb) [0x1712b6b] ./blender(wm_event_do_refresh_wm_and_depsgraph+0x87) [0x1712cb7] ./blender(wm_event_do_notifiers+0x609) [0x171ad09] ./blender(WM_main+0x28) [0x170d778] ./blender(main+0x33a) [0x1087a7a] /usr/lib/libc.so.6(+0x2d310) [0x7f3b49a1a310] /usr/lib/libc.so.6(__libc_start_main+0x81) [0x7f3b49a1a3c1] ./blender(_start+0x25) [0x1181d85] ```

Georg K commented

2022-05-15 11:39:03 +02:00

Added subscriber: @georgK

Pratik Borhade commented

2022-05-16 07:27:18 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-05-16 07:27:20 +02:00

Added subscriber: @PratikPB2123

blender-admin commented

2022-05-16 15:37:07 +02:00

This issue was referenced by 9df91654dc

This issue was referenced by 9df91654dc979e3d334de69eded7f816bef223e3

Bastien Montagne commented

2022-05-16 15:39:47 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Bastien Montagne closed this issue

2022-05-16 15:39:47 +02:00

Bastien Montagne self-assigned this 2022-05-16 15:39:47 +02:00

Georg K commented

2022-05-17 00:07:25 +02:00

Thanks for fixing the crash! Now there is a greyed out, linked "OVERRIDE_HIDDEN" collection pointing to the "Dup" collection in the example file. Since there seems to be no documentation on this topic, could you please explain what that means and why linking the "Link this" collection now links the other collection, too?

Bastien Montagne commented

2022-05-17 11:51:43 +02:00

Essentially, there should be no local/directly linked object not belonging to at least one collection in Blender. Your Link This collection is pulling in two armature objects, OArmature and Armature, the later from the shapekey, and not being in any collection.

Since this is an indirectly linked data, it's fine, but when making it a liboverride, all objects are overridden, which means the 'invisible' Armature one must also be instantiated in the scene, which is done through that hidden collection.

Note that such process is a bit of a band-aid for badly organized assets, ideally all of your objects should be gathered into collections, with a single well-defined collection as 'root' of the whole hierarchy of dependencies.

Essentially, there should be no local/directly linked object not belonging to at least one collection in Blender. Your `Link This` collection is pulling in **two** armature objects, `OArmature` and `Armature`, the later from the shapekey, and not being in any collection. Since this is an indirectly linked data, it's fine, but when making it a liboverride, all objects are overridden, which means the 'invisible' `Armature` one must also be instantiated in the scene, which is done through that hidden collection. Note that such process is a bit of a band-aid for badly organized assets, ideally all of your objects should be gathered into collections, with a single well-defined collection as 'root' of the whole hierarchy of dependencies.

Georg K commented

2022-05-17 19:44:55 +02:00

Oh, I did not notice that the driver was referencing the wrong armature, that explains a lot actually, thank you!

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash undoing "Make Library Override" for linked collection with shapekey #98136