Node muting connects mismatching sockets #98171

Open
opened 2022-05-16 19:52:17 +02:00 by Serge Lyatin · 6 comments

Blender Version
Broken: 3.2.0 beta

Exact steps for others to reproduce the error

  • Add Float Curve node in any editor (Shader, Geometry Nodes) and connect output to anything else
  • Plug Value nodes into input sockets (both factor and value)
  • Mute Float Curve -> inner noodle connects Factor to Value

Or in provided file mute Float Curve

wrong_mute.blend

**Blender Version** Broken: 3.2.0 beta **Exact steps for others to reproduce the error** - Add *Float Curve* node in any editor (*Shader, Geometry Nodes*) and connect output to anything else - Plug *Value* nodes into input sockets (both factor and value) - Mute *Float Curve* -> inner noodle connects Factor to Value Or in provided file mute *Float Curve* [wrong_mute.blend](https://archive.blender.org/developer/F13079976/wrong_mute.blend)
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

For the records, the drawing in the background is correct, as in, it connects what is being evaluated.

Here is an example for Geometry Nodes:

float_curve.blend

I wonder if the fix could be as simple as flipping the order of the elements (have Value before Factor). Even if that means doversioning.

For the records, the drawing in the background is correct, as in, it connects what is being evaluated. Here is an example for Geometry Nodes: [float_curve.blend](https://archive.blender.org/developer/F13123330/float_curve.blend) I wonder if the fix could be as simple as flipping the order of the elements (have Value before Factor). Even if that means doversioning.

Looking at be4478d1f8 it seems that we just need to have the Muting functionality to use the socket defined in is_default_link_socket.

Looking at be4478d1f8 it seems that we just need to have the Muting functionality to use the socket defined in `is_default_link_socket`.
Cody Henry self-assigned this 2022-06-02 22:41:18 +02:00
Author

Field at Index in integer mode node in Geometry Nodes suffers from the same issue, it connects Index with Value.
GN Switch in boolean mode connects output with switch factor itself.

*Field at Index* in integer mode node in Geometry Nodes suffers from the same issue, it connects *Index* with *Value*. GN *Switch* in boolean mode connects output with switch factor itself.
Philipp Oeser removed the
Interest
Nodes & Physics
label 2023-02-10 08:44:02 +01:00
Member

This appears to have been fixed for the Float Curve node by means of a no_muted_links tag on the Factor socket. For the Field at Index node in Integer mode (!) it is still a problem.

I think we should do a pass over all the nodes and set .no_muted_links() where it makes sense.

This appears to have been fixed for the _Float Curve_ node by means of a `no_muted_links` tag on the Factor socket. For the _Field at Index_ node in Integer mode (!) it is still a problem. I think we should do a pass over all the nodes and set `.no_muted_links()` where it makes sense.

In fact, there were plans to do a little refactoring of how each node type determines for itself how to build internal links.
But so far this is not being developed (when I started experimenting, I realized that it makes sense to clean up the node code ...)

In fact, there were plans to do a little refactoring of how each node type determines for itself how to build internal links. But so far this is not being developed (when I started experimenting, I realized that it makes sense to clean up the node code ...)
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#98171
No description provided.