blender-thumbnailer null pointer reference and free #99744

Closed
opened 2022-07-15 19:28:37 +02:00 by Sangjun Park · 5 comments

System Information
Operating system: Ubuntu 20.04.4 LTS
Graphics card: 2b:00.0 VGA compatible controller: NVIDIA Corporation TU116 [GeForce GTX 1650 SUPER] (rev a1)

Blender Version
Broken: Blender 3.3.0 Alpha branch : master, commit 178868cf42 Date: Thu Jul 14 12:40:43 2022 +1200

Short description of error
convert from .blend file to png using blend-thumbnailer
null pointer free in
blendthumb_create_thumb_from_file

It can be abuse by attacker with other vulnerability

Exact steps for others to reproduce the error
POC Video below
https://youtu.be/SBrPn-5CDtE

POC blend file below
null_pointer_free.blend

**System Information** Operating system: Ubuntu 20.04.4 LTS Graphics card: 2b:00.0 VGA compatible controller: NVIDIA Corporation TU116 [GeForce GTX 1650 SUPER] (rev a1) **Blender Version** Broken: Blender 3.3.0 Alpha branch : master, commit 178868cf42594bf7eedfa4db93ba8b7f3bf017ce Date: Thu Jul 14 12:40:43 2022 +1200 **Short description of error** convert from .blend file to png using blend-thumbnailer null pointer free in ```blendthumb_create_thumb_from_file``` It can be abuse by attacker with other vulnerability **Exact steps for others to reproduce the error** POC Video below https://youtu.be/SBrPn-5CDtE POC blend file below [null_pointer_free.blend](https://archive.blender.org/developer/F13295201/null_pointer_free.blend)
Author

Added subscriber: @sangjun-park

Added subscriber: @sangjun-park

This issue was referenced by c82e9d4ec8

This issue was referenced by c82e9d4ec81c5119b4bf0a211f89273dc3ede9b4

This issue was referenced by f76b537d48

This issue was referenced by f76b537d486029fc8ad5bf3bf9b122bc4b3c9d89

Changed status from 'Needs Triage' to: 'Resolved'

Changed status from 'Needs Triage' to: 'Resolved'
Campbell Barton self-assigned this 2022-07-16 08:35:20 +02:00

Corrected the NULL pointer free since it asserts but I can't see how this could ever cause a security risk as MEM_freeN (therefor MEM_lockfree_freeN) accounts for NULL pointer case already.

Corrected the NULL pointer free since it asserts but I can't see how this could ever cause a security risk as `MEM_freeN` (therefor `MEM_lockfree_freeN`) accounts for NULL pointer case already.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#99744
No description provided.