blender
/
blender
136
406
Fork 590
Code Issues 6.2k Pull Requests 764 Projects 19 Wiki Activity

Curves: cage overlay for sculpt mode #104467

Merged
Jacques Lucke merged 44 commits from JacquesLucke/blender:sculpt-edit-overlay into main 2023-02-14 18:10:24 +01:00
Conversation 0 Commits 44 Files Changed 11 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9c792dd7ab - Show all commits

2
source/blender/editors/sculpt_paint/curves_sculpt_ops.cc
View File

@ -289,7 +289,7 @@ static void curves_sculptmode_enter(bContext *C)
paint_init_pivot(ob, scene);
/* Necessary to change the object mode on the evaluated object. */
DEG_id_tag_update(&ob->id, ID_RECALC_COPY_ON_WRITE);
DEG_id_tag_update(&ob->id, ID_RECALC_COPY_ON_WRITE | ID_RECALC_GEOMETRY);
WM_msg_publish_rna_prop(mbus, &ob->id, ob, Object, mode);
WM_event_add_notifier(C, NC_SCENE | ND_MODE, nullptr);
JacquesLucke marked this conversation as resolved
Hans Goudey commented 2023-02-14 17:38:30 +01:00
Review
Copy Link

Not a big deal if you don't know, but isn't ID_RECALC_COPY_ON_WRITE redundant after ID_RECALC_GEOMETRY is added?

Not a big deal if you don't know, but isn't `ID_RECALC_COPY_ON_WRITE` redundant after `ID_RECALC_GEOMETRY` is added?
Jacques Lucke commented 2023-02-14 17:59:54 +01:00
Review
Copy Link

Seems to work without it now. I'm pretty sure that it was needed at some point. Not sure what changed exactly.

Seems to work without it now. I'm pretty sure that it was needed at some point. Not sure what changed exactly.
}