blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 768 Projects 19 Wiki Activity

Animation: Add "Frame Channel" operators #104523

Merged
Christoph Lendenfeld merged 27 commits from ChrisLend/blender:frame-channel-operator into main 2023-02-17 18:11:10 +01:00
Conversation 3 Commits 27 Files Changed 7 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit de32d0cbc2 - Show all commits

4
source/blender/editors/animation/anim_channels_edit.c
View File

@ -3643,8 +3643,8 @@ static void ANIM_OT_channel_select_keys(wmOperatorType *ot)
/** \name View Channel Operator
* \{ */
dr.sybren marked this conversation as resolved
Sybren A. Stüvel commented 2023-02-14 14:38:34 +01:00
Review
Copy Link

I think these three pointers can all be const, as this only gets the bounds and shouldn't set anything.

I think these three pointers can all be `const`, as this only gets the bounds and shouldn't set anything.
Christoph Lendenfeld commented 2023-02-16 13:21:53 +01:00
Review
Copy Link

only ale can be const in this case
because ANIM_get_normalization_flags and ANIM_unit_mapping_get_factor would throw warnings otherwise since they aren't set to const

only `ale` can be const in this case because `ANIM_get_normalization_flags` and `ANIM_unit_mapping_get_factor` would throw warnings otherwise since they aren't set to const
static void get_normalized_fcurve_bounds(const FCurve *fcu,
const bAnimContext *ac,
static void get_normalized_fcurve_bounds(FCurve *fcu,
bAnimContext *ac,
const bAnimListElem *ale,
ChrisLend marked this conversation as resolved
Sybren A. Stüvel commented 2023-02-14 14:38:06 +01:00
Review
Copy Link

const

`const`
const bool include_handles,
const float range[2],