blender
/
blender
137
409
Fork 592
Code Issues 6.3k Pull Requests 770 Projects 19 Wiki Activity

Curves: Add support for proportional editing #104620

Closed
Falk David wants to merge 15 commits from filedescriptor:curves-proportional-editing into blender-v3.5-release
pull from: filedescriptor:curves-proportional-editing
merge into: blender:blender-v3.5-release

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 15 Files Changed 4 +50 -2
1 changed files with 50 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 87ae4fa294 - Show all commits

52
source/blender/editors/transform/transform_convert_curves.cc
View File

@ -6,6 +6,7 @@
#include "BLI_array.hh"
#include "BLI_index_mask_ops.hh"
#include "BLI_inplace_priority_queue.hh"
#include "BLI_span.hh"
#include "BKE_curves.hh"
@ -23,12 +24,45 @@
namespace blender::ed::transform::curves {
static void calculate_curve_point_distances_for_proportional_editing(
Span<float3> positions, MutableSpan<float> r_distances)
{
Array<bool> visited(positions.size(), false);
filedescriptor marked this conversation as resolved
Hans Goudey commented 2023-02-13 02:26:59 +01:00
Review
Copy Link

prop -> proportional? Curious what you think about that-- saving a few characters doesn't help so much here.

`prop` -> `proportional`? Curious what you think about that-- saving a few characters doesn't help so much here.
InplacePriorityQueue<float> queue(r_distances);
while (!queue.is_empty()) {
int64_t idx = queue.pop_index();
if (!visited[idx]) {
continue;
}
visited[idx] = true;
if (idx > 0) {
filedescriptor marked this conversation as resolved
Hans Goudey commented 2023-02-20 17:50:01 +01:00
Review
Copy Link

Tiny thing, but fairly sure this will end up in a cleanup commit by Campbell to remove the space between TODO and (Falk) :P

I'd remove your name or the space

Tiny thing, but fairly sure this will end up in a cleanup commit by Campbell to remove the space between `TODO` and `(Falk)` :P I'd remove your name or the space
int adj = idx - 1;
float dist = r_distances[idx] + math::distance(positions[idx], positions[adj]);
if (dist < r_distances[adj]) {
r_distances[adj] = dist;
queue.priority_changed(adj);
}
}
if (idx < positions.size() - 1) {
int adj = idx + 1;
float dist = r_distances[idx] + math::distance(positions[idx], positions[adj]);
if (dist < r_distances[adj]) {
r_distances[adj] = dist;
queue.priority_changed(adj);
}
}
}
}
static void createTransCurvesVerts(bContext * /*C*/, TransInfo *t)
{
MutableSpan<TransDataContainer> trans_data_contrainers(t->data_container, t->data_container_len);
Array<Vector<int64_t>> selected_indices_per_object(t->data_container_len);
Array<IndexMask> selection_per_object(t->data_container_len);
const bool is_prop_edit = (t->flag & T_PROP_EDIT) != 0;
const bool is_prop_edit = (t->flag & T_PROP_EDIT_ALL) != 0;
const bool is_prop_connected = (t->flag & T_PROP_CONNECTED) != 0;
filedescriptor marked this conversation as resolved
Hans Goudey commented 2023-02-17 19:59:51 +01:00
Review
Copy Link

is_prop_edit -> use_proportional_edit
is_prop_connected -> proportional_connected_only

Or something like that

`is_prop_edit` -> `use_proportional_edit` `is_prop_connected` -> `proportional_connected_only` Or something like that
/* Count selected elements per object and create TransData structs. */
for (const int i : trans_data_contrainers.index_range()) {
@ -65,12 +99,16 @@ static void createTransCurvesVerts(bContext * /*C*/, TransInfo *t)
MutableSpan<float3> positions = curves.positions_for_write();
if (is_prop_edit) {
filedescriptor marked this conversation as resolved
Hans Goudey commented 2023-02-17 20:01:36 +01:00
Review
Copy Link

Separate positions_read and positions_ptr shouldn't be necessary, the old positions span should still work fine

Separate `positions_read` and `positions_ptr` shouldn't be necessary, the old `positions` span should still work fine
Falk David commented 2023-02-18 15:48:27 +01:00
Review
Copy Link

Last time I tried this, the compiler complained because I was passing pointers to td->loc when the Span is const. So I think I need float3 *positions_ptr = curves.positions_for_write().data(); just to pass the pointers into the TransData struct.

Last time I tried this, the compiler complained because I was passing pointers to `td->loc` when the Span is const. So I think I need `float3 *positions_ptr = curves.positions_for_write().data();` just to pass the pointers into the `TransData` struct.
Hans Goudey commented 2023-02-20 18:45:35 +01:00
Review
Copy Link

Just replacing positions_ptr with a mutable span seems to work fine here

Just replacing `positions_ptr` with a mutable span seems to work fine here
Span<float3> positions_read = curves.positions();
OffsetIndices<int> points_by_curve = curves.points_by_curve();
VArray<bool> selection = curves.attributes().lookup_or_default<bool>(
".selection", ATTR_DOMAIN_POINT, true);
threading::parallel_for(curves.curves_range(), 1024, [&](const IndexRange range) {
threading::parallel_for(curves.curves_range(), 512, [&](const IndexRange range) {
for (const int curve_i : range) {
bool has_any_selected = false;
Span<float3> positions_curve = positions_read.slice(points_by_curve[curve_i]);
Array<float> closest_distances(positions_curve.size(), FLT_MAX);
for (const int point_i : points_by_curve[curve_i]) {
TransData *td = &tc.data[point_i];
float *elem = reinterpret_cast<float *>(&positions[point_i]);
@ -80,6 +118,7 @@ static void createTransCurvesVerts(bContext * /*C*/, TransInfo *t)
if (selection[point_i]) {
has_any_selected = true;
filedescriptor marked this conversation as resolved
Hans Goudey commented 2023-02-17 20:02:45 +01:00
Review
Copy Link

for (const int point_i : points) {

`for (const int point_i : points) {`
closest_distances[point_i - points_by_curve[curve_i].start()] = 0.0f;
}
td->flag = (selection[point_i]) ? TD_SELECTED : 0;
@ -89,6 +128,15 @@ static void createTransCurvesVerts(bContext * /*C*/, TransInfo *t)
copy_m3_m3(td->mtx, mtx);
}
if (is_prop_connected) {
filedescriptor marked this conversation as resolved
Hans Goudey commented 2023-02-17 20:05:22 +01:00
Review
Copy Link

This array makes things a bit more readable, but it isn't really necessary considering all the data will go into TransData.dist right after. It might be worth skipping the array, since this will be an allocation and free for every single curve.

This array makes things a bit more readable, but it isn't really necessary considering all the data will go into `TransData.dist` right after. It might be worth skipping the array, since this will be an allocation and free for every single curve.
Falk David commented 2023-02-18 15:44:07 +01:00
Review
Copy Link

I am not sure how I would rewrite the code to not use an array in this case. The td->dist values are not sequential, so I can't write to them directly. But the implementation needs some container that I can build the InplacePriorityQueue on top of.

I am not sure how I would rewrite the code to not use an array in this case. The `td->dist` values are not sequential, so I can't write to them directly. But the implementation needs some container that I can build the `InplacePriorityQueue` on top of.
Hans Goudey commented 2023-02-18 16:40:01 +01:00
Review
Copy Link

Ah right! That's totally fine, it was just a thought.

Ah right! That's totally fine, it was just a thought.
calculate_curve_point_distances_for_proportional_editing(
positions_curve, closest_distances.as_mutable_span());
for (const int point_i : points_by_curve[curve_i]) {
TransData *td = &tc.data[point_i];
td->dist = closest_distances[point_i - points_by_curve[curve_i].start()];
}
}
if (!has_any_selected) {
for (const int point_i : points_by_curve[curve_i]) {
TransData *td = &tc.data[point_i];