blender
/
blender
136
406
Fork 589
Code Issues 6.3k Pull Requests 766 Projects 19 Wiki Activity

Fix T103354: Author extents on UsdGeomMesh #104676

Merged
Sybren A. Stüvel merged 6 commits from wave/blender_wave_Apple:contribs/T103354_author_extents into main 2023-02-14 12:12:05 +01:00
Conversation 1 Commits 6 Files Changed 6 +17 -17
2 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit be1c115617 - Show all commits

18
source/blender/io/usd/intern/usd_writer_abstract.cc
View File

@ -154,23 +154,7 @@ bool USDAbstractWriter::mark_as_instance(const HierarchyContext &context, const
void USDAbstractWriter::author_extent(const pxr::UsdTimeCode timecode, pxr::UsdGeomBoundable &prim)
{
/* Compute the bounds for a boundable prim, and author the result as the extent attribute.
*
* Although this method works for any boundable prim, it is preferred to use Blender's own
* cached bounds when possible.
*
* This method does not author the extentsHint attribute, which is also important to provide.
* Whereas the extent attribute can only be authored on prims inheriting from UsdGeomBoundable,
* an extentsHint can be provided on any prim, including scopes. This extentsHint should be
* authored on every prim in a hierarchy being exported.
*
* Note that this hint is only useful when importing or inspecting layers, and should not be
* taken into account when computing extents during export.
*
* TODO: also provide method for authoring extentsHint on every prim in a hierarchy.
*/
/* do not use any existing extentsHint that may authored, instead recompute the extent when authoring it */
/* Do not use any existing `extentsHint` that may be authored, instead recompute the extent when authoring it. */
const bool useExtentsHint = false;
const pxr::TfTokenVector includedPurposes{pxr::UsdGeomTokens->default_};
pxr::UsdGeomBBoxCache bboxCache(timecode, includedPurposes, useExtentsHint);

16
source/blender/io/usd/intern/usd_writer_abstract.h
View File

@ -69,6 +69,22 @@ class USDAbstractWriter : public AbstractHierarchyWriter {
*/
virtual bool mark_as_instance(const HierarchyContext &context, const pxr::UsdPrim &prim);
/**
* Compute the bounds for a boundable prim, and author the result as the `extent` attribute.
*
* Although this method works for any boundable prim, it is preferred to use Blender's own
* cached bounds when possible.
*
* This method does not author the `extentsHint` attribute, which is also important to provide.
* Whereas the `extent` attribute can only be authored on prims inheriting from `UsdGeomBoundable`,
* an `extentsHint` can be provided on any prim, including scopes. This `extentsHint` should be
* authored on every prim in a hierarchy being exported.
*
* Note that this hint is only useful when importing or inspecting layers, and should not be
* taken into account when computing extents during export.
*
* TODO: also provide method for authoring extentsHint on every prim in a hierarchy.
*/
virtual void author_extent(const pxr::UsdTimeCode timecode, pxr::UsdGeomBoundable &prim);
};