blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 767 Projects 19 Wiki Activity

BLI_math: fix parameter aliasing in mul_m3_series and mul_m4_series #104934

Merged
Chris Blackbourn merged 2 commits from Chris_Blackbourn/blender:matrix-multiply-series into main 2023-02-20 23:04:20 +01:00
Conversation 4 Commits 2 Files Changed 2 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit aee16ffc0d - Show all commits

2
source/blender/blenlib/tests/BLI_math_matrix_test.cc
View File

@ -131,7 +131,7 @@ TEST(math_matrix, mul_m4_series)
{0.0f, 0.0f, 125.0f, 0.0f},
{0.0f, 0.0f, 0.0f, 343.0f},
};
EXPECT_M3_NEAR(matrix, expect, 1e-5);
EXPECT_M4_NEAR(matrix, expect, 1e-5);
deadpin marked this conversation as resolved
Jesse Yurkovich commented 2023-02-18 23:44:21 +01:00
Review
Copy Link

Should be EXPECT_M4_NEAR

Should be `EXPECT_M4_NEAR`
Chris Blackbourn commented 2023-02-19 03:19:52 +01:00
Review
Copy Link

Nice spotting! Should be fixed now.

Nice spotting! Should be fixed now.
}
namespace blender::tests {