blender
/
blender
136
406
Fork 589
Code Issues 6.3k Pull Requests 766 Projects 19 Wiki Activity

Allow renaming F-curve modifier #104949

Merged
Pratik Borhade merged 7 commits from PratikPB2123/blender:T103855-rename-fmodifier into main 2023-05-02 13:07:55 +02:00
Conversation 9 Commits 7 Files Changed 7 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b8c2d440f4 - Show all commits

2
source/blender/blenkernel/BKE_fcurve.h
View File

@ -241,7 +241,7 @@ void BKE_fcurves_free(ListBase *list);
void BKE_fcurves_copy(ListBase *dst, ListBase *src);
/* Set fcurve modifier name and ensure uniqueness.
Sybren A. Stüvel commented 2023-05-01 16:31:29 +02:00
Outdated
Review
Copy Link

"check" → "ensure"

To "check" doesn't necessarily imply that this uniqueness is ensured. It could also just return a boolean. And the return type of the function shouldn't be necessary to understand its documentation.

"check" → "ensure" To "check" doesn't necessarily imply that this uniqueness is ensured. It could also just return a boolean. And the return type of the function shouldn't be necessary to understand its documentation.
* Pass new name string when its edited otherwise pass empty string. */
* Pass new name string when it's been edited otherwise pass empty string. */
Sybren A. Stüvel commented 2023-05-02 11:11:34 +02:00
Outdated
Review
Copy Link

"its" → "it's been"

"its" → "it's been"
void BKE_fmodifier_name_set(struct FModifier *fcm, const char *name);
/**