blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 780 Projects 19 Wiki Activity

USD Export: New Curves/Hair Support #105375

Merged
Michael Kowalski merged 19 commits from SonnyCampbell_Unity/blender:unity/T102376-USD-Curves-Export into main 2023-05-16 20:04:26 +02:00
Conversation 4 Commits 19 Files Changed 5 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 93fa6259b2 - Show all commits

4
source/blender/io/usd/intern/usd_writer_curves.cc
View File

@ -427,10 +427,10 @@ void USDCurvesWriter::do_write(HierarchyContext &context)
else if (first_frame_curve_type != curve_type) {
const char *first_frame_curve_type_name = nullptr;
RNA_enum_name_from_value(
rna_enum_curves_types, (int)first_frame_curve_type, &first_frame_curve_type_name);
rna_enum_curves_types, int(first_frame_curve_type), &first_frame_curve_type_name);
SonnyCampbell_Unity marked this conversation as resolved Outdated
Hans Goudey commented 2023-05-16 14:37:41 +02:00
Outdated
Review
Copy Link

(int)first_frame_curve_type -> int(first_frame_curve_type)

Functional style casts here (and below) (https://wiki.blender.org/wiki/Style_Guide/C_Cpp#C.2B.2B_Type_Cast)

`(int)first_frame_curve_type` -> `int(first_frame_curve_type)` Functional style casts here (and below) (https://wiki.blender.org/wiki/Style_Guide/C_Cpp#C.2B.2B_Type_Cast)
const char *current_curve_type_name = nullptr;
RNA_enum_name_from_value(rna_enum_curves_types, (int)curve_type, &current_curve_type_name);
RNA_enum_name_from_value(rna_enum_curves_types, int(curve_type), &current_curve_type_name);
WM_reportf(RPT_WARNING,
"USD does not support animating curve types. The curve type changes from %s to "