blender
/
blender
135
420
Fork 601
Code Issues 6.3k Pull Requests 767 Projects 19 Wiki Activity

WIP #104054 Symmetize visible edit bones if nothing has been selected #105385

Closed
Denys Hsu wants to merge 3 commits from cgtinker/blender:104054-symmetrize-armature-nothing-selected into main
pull from: cgtinker/blender:104054-symmetrize-armature-nothing-selected
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 3 Files Changed 1 +8 -2
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0b8d13ba19 - Show all commits

10
source/blender/editors/armature/armature_add.c
View File

@ -1100,9 +1100,15 @@ static int armature_symmetrize_exec(bContext *C, wmOperator *op)
const int direction = RNA_enum_get(op->ptr, "direction");
const int axis = 0;
/* cancel if nothing selected */
/* select all visible bones if nothing selected */
if (CTX_DATA_COUNT(C, selected_bones) == 0) {
Sybren A. Stüvel commented 2023-03-07 17:22:50 +01:00
Review
Copy Link

IMO is_selected doesn't quite cover the purpose. In other code I've used the name is_selection_relevant for this.

IMO `is_selected` doesn't quite cover the purpose. In other code I've used the name `is_selection_relevant` for this.
return OPERATOR_CANCELLED;
CTX_DATA_BEGIN (C, EditBone *, ebone, visible_bones) {
ebone->flag |= (BONE_SELECTED | BONE_TIPSEL | BONE_ROOTSEL);
Sybren A. Stüvel commented 2023-03-07 17:23:52 +01:00
Review
Copy Link

The declaration and if can be reduced to:

const bool is_selected = CTX_DATA_COUNT(C, selected_bones) > 0;

This has the added advantage that now the variable can be const.

The declaration and `if` can be reduced to: ```c const bool is_selected = CTX_DATA_COUNT(C, selected_bones) > 0; ``` This has the added advantage that now the variable can be `const`.
if (ebone->parent) {
ebone->parent->flag |= BONE_TIPSEL;
}
}
CTX_DATA_END;
}
uint objects_len = 0;