blender
/
blender
134
400
Fork 583
Code Issues 6.3k Pull Requests 758 Projects 19 Wiki Activity

Refactor: GLSL: Cleanup Clip Space vs. NDC Space naming #105423

Closed
Prakhar-Singh-Chouhan wants to merge 15 commits from (deleted):fix#105070 into main
pull from: (deleted):fix#105070
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 5 Commits 15 Files Changed 75 +4 -4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5e3bb16251 - Show all commits

8
source/blender/draw/engines/overlay/shaders/overlay_edit_mesh_vert_no_geom.glsl
View File

@ -82,12 +82,12 @@ void main()
vec3 world_pos0 = point_object_to_world(in_pos0);
vec3 world_pos1 = point_object_to_world(in_pos1);
vec4 out_pos0 = point_world_to_homogenous(world_pos0);
vec4 out_pos1 = point_world_to_homogenous(world_pos1);
vec3 view_pos0 = point_world_to_view(world_pos0);
fclem marked this conversation as resolved
Clément Foucault commented 2023-03-04 21:03:34 +01:00
Review
Copy Link

Here

Here
vec3 view_pos1 = point_world_to_view(world_pos1);
vec4 out_pos0 = point_view_to_ndc(view_pos0);
vec4 out_pos1 = point_view_to_ndc(view_pos1);
vec4 out_pos0 = point_world_to_homogenous(world_pos0);
fclem marked this conversation as resolved
Clément Foucault commented 2023-03-06 18:34:19 +01:00
Review
Copy Link

Same thing here.

Same thing here.
vec4 out_pos1 = point_world_to_homogenous(world_pos1);
/* Offset Z position for retopology overlay. */
out_pos0.z += get_homogenous_z_offset(view_pos0.z, out_pos0.w, retopologyOffset);