blender
/
blender
137
416
Fork 599
Code Issues 6.3k Pull Requests 767 Projects 19 Wiki Activity

Cleanup: Reduce nesteds in node.cc #105509

Merged
Hans Goudey merged 12 commits from mod_moder/blender:cleanup_reduce_nesteds into main 2023-04-16 22:53:20 +02:00
Conversation 1 Commits 12 Files Changed 1 +1 -4
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 814b9c36d7 - Show all commits

5
source/blender/blenkernel/intern/node.cc
View File

@ -3758,10 +3758,7 @@ int nodeSocketLinkLimit(const bNodeSocket *sock)
if (!stype.use_link_limits_of_type) {
return sock->limit;
}
if (sock->in_out == SOCK_IN) {
return stype.input_link_limit;
}
return stype.output_link_limit;
return sock->in_out == SOCK_IN ? stype.input_link_limit : stype.output_link_limit;
mod_moder marked this conversation as resolved Outdated
Hans Goudey commented 2023-04-16 21:54:32 +02:00
Outdated
Review
Copy Link

Personally I find this easier to read than what you've done here. It's a simple check and splitting it over multiple lines makes it seem more complex than it is.
return sock->in_out == SOCK_IN ? stype.input_link_limit : stype.output_link_limit;

Personally I find this easier to read than what you've done here. It's a simple check and splitting it over multiple lines makes it seem more complex than it is. ` return sock->in_out == SOCK_IN ? stype.input_link_limit : stype.output_link_limit;`
}
static void update_socket_declarations(ListBase *sockets,