blender
/
blender
136
407
Fork 589
Code Issues 6.3k Pull Requests 779 Projects 19 Wiki Activity

GPU: Refactor API for Clearing Storage Buffers #105521

Merged
Clément Foucault merged 15 commits from Jeroen-Bakker/blender:gpu-storage-buffer-clear-api into main 2023-03-09 18:46:41 +01:00
Conversation 1 Commits 15 Files Changed 10 +4 -4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1967026b22 - Show all commits

8
source/blender/gpu/opengl/gl_storage_buffer.cc
View File

@ -127,19 +127,19 @@ void GLStorageBuf::clear(Span<uint32_t> data)
GLenum format = GL_RED;
Jeroen-Bakker marked this conversation as resolved
Clément Foucault commented 2023-03-07 15:15:55 +01:00
Review
Copy Link

You forgot to change this.

You forgot to change this.
if (data.size() == 1) {
internal_format = GL_R32UI;
format = GL_RED;
format = GL_RED_INTEGER;
}
else if (data.size() == 2) {
internal_format = GL_RG32UI;
format = GL_RG;
format = GL_RG_INTEGER;
}
else if (data.size() == 3) {
internal_format = GL_RGB32UI;
format = GL_RGB;
format = GL_RGB_INTEGER;
}
else if (data.size() == 4) {
internal_format = GL_RGBA32UI;
format = GL_RGBA;
format = GL_RGBA_INTEGER;
}
if (GLContext::direct_state_access_support) {