blender
/
blender
137
416
Fork 599
Code Issues 6.3k Pull Requests 773 Projects 19 Wiki Activity

Mesh: Cache loose vertices #105567

Merged
Hans Goudey merged 29 commits from HooglyBoogly/blender:mesh-loose-vert-cache into main 2023-04-22 13:46:23 +02:00
Conversation 3 Commits 29 Files Changed 16 +6 -22
1 changed files with 6 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8604450162 - Show all commits

28
source/blender/blenkernel/intern/bvhutils.cc
View File

@ -1142,28 +1142,12 @@ BVHTree *bvhtree_from_mesh_looptri_ex(BVHTreeFromMesh *data,
return tree;
}
static BitVector<> loose_verts_map_get(const Span<MEdge> edges,
int verts_num,
int *r_loose_vert_num)
static BitVector<> loose_verts_map_get(const Mesh &mesh, int *r_loose_vert_num)
HooglyBoogly marked this conversation as resolved Outdated
Jacques Lucke commented 2023-04-21 12:50:38 +02:00
Outdated
Review
Copy Link

Does this intentionally return by value instead of const-references? Same below.

Does this intentionally return by value instead of const-references? Same below.
{
BitVector<> loose_verts_mask(verts_num, true);
int num_linked_verts = 0;
for (const int64_t i : edges.index_range()) {
const MEdge &edge = edges[i];
if (loose_verts_mask[edge.v1]) {
loose_verts_mask[edge.v1].reset();
num_linked_verts++;
}
if (loose_verts_mask[edge.v2]) {
loose_verts_mask[edge.v2].reset();
num_linked_verts++;
}
}
*r_loose_vert_num = verts_num - num_linked_verts;
return loose_verts_mask;
using namespace blender::bke;
const LooseVertCache &loose_verts = mesh.loose_verts_edge();
*r_loose_vert_num = loose_verts.count;
return loose_verts.is_loose_bits;
}
static BitVector<> loose_edges_map_get(const Mesh &mesh, int *r_loose_edge_len)
@ -1248,7 +1232,7 @@ BVHTree *BKE_bvhtree_from_mesh_get(struct BVHTreeFromMesh *data,
switch (bvh_cache_type) {
case BVHTREE_FROM_LOOSEVERTS:
mask = loose_verts_map_get(edges, mesh->totvert, &mask_bits_act_len);
mask = loose_verts_map_get(*mesh, &mask_bits_act_len);
ATTR_FALLTHROUGH;
case BVHTREE_FROM_VERTS:
data->tree = bvhtree_from_mesh_verts_create_tree(