blender
/
blender
137
416
Fork 599
Code Issues 6.3k Pull Requests 772 Projects 19 Wiki Activity

Cycles: new Microfacet-based Hair BSDF with elliptical cross-section support #105600

Merged
Weizhen Huang merged 114 commits from weizhen/blender:microfacet_hair into main 2023-08-18 12:46:20 +02:00
Conversation 12 Commits 114 Files Changed 25 +5 -5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8bad526d51 - Show all commits

10
intern/cycles/blender/curves.cpp
View File

@ -326,12 +326,12 @@ static void ExportCurveSegments(Scene *scene, Hair *hair, ParticleCurveData *CDa
if (attr_intercept)
Weizhen Huang commented 2023-04-12 15:04:07 +02:00
Outdated
Review
Copy Link

The curve normal (which is needed for orienting the cross-section) is not considered in the legacy hair curve. I don't want to put too much effort into this if the legacy curve is to be discarded at some point.

The curve normal (which is needed for orienting the cross-section) is not considered in the legacy hair curve. I don't want to put too much effort into this if the legacy curve is to be discarded at some point.
attr_intercept->add(time);
num_curve_keys++;
}
if (attr_normal) {
/* TODO: compute geometry normals. */
attr_normal->add(make_float3(1.0f, 0.0f, 0.0f));
}
if (attr_normal != NULL) {
/* TODO: compute geometry normals. */
attr_normal->add(make_float3(1.0f, 0.0f, 0.0f));
num_curve_keys++;
}
if (attr_length != NULL) {