blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 746 Projects 19 Wiki Activity

Animation: Weight Paint select more/less for faces #105607

Merged
Christoph Lendenfeld merged 13 commits from ChrisLend/blender:weight_paint_grow_sel_face into main 2023-03-31 14:53:12 +02:00
Conversation 6 Commits 13 Files Changed 7 +4 -4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 40d0722dea - Show all commits

8
source/blender/editors/mesh/editface.cc
View File

@ -350,12 +350,12 @@ void paintface_select_linked(bContext *C, Object *ob, const int mval[2], const b
paintface_flush_flags(C, ob, true, false);
}
static bool poly_has_selected_neighbor(blender::Span<int> edge_indices,
static bool poly_has_selected_neighbor(blender::Span<int> poly_edges,
Hans Goudey commented 2023-03-24 14:46:03 +01:00
Outdated
Review
Copy Link

Canonical variable name for the edges of a face is poly_edges

Canonical variable name for the edges of a face is `poly_edges`
blender::Span<MEdge> edges,
blender::Span<bool> select_vert,
const bool face_step)
{
for (const int edge_index : edge_indices) {
for (const int edge_index : poly_edges) {
const MEdge &edge = edges[edge_index];
/* If a poly is selected, all of its verts are selected too, meaning that neighboring faces
* will have some vertices selected. */
@ -408,12 +408,12 @@ void paintface_select_more(Mesh *mesh, const bool face_step)
select_vert.finish();
}
static bool poly_has_unselected_neighbor(blender::Span<int> edge_indices,
static bool poly_has_unselected_neighbor(blender::Span<int> poly_edges,
blender::Span<MEdge> edges,
Hans Goudey commented 2023-03-18 02:26:49 +01:00
Outdated
Review
Copy Link

It's not a big deal, but the function could be a bit simpler without the unselected_neighbor variable. It's nice to assign a variable a meaningful value in the same expression you initialize it, and that's not really the case here. Given the function name, returning early reads as "poly has an unselected neighbor" anyway.

It's not a big deal, but the function could be a bit simpler without the `unselected_neighbor` variable. It's nice to assign a variable a meaningful value in the same expression you initialize it, and that's not really the case here. Given the function name, returning early reads as "poly has an unselected neighbor" anyway.
Christoph Lendenfeld commented 2023-03-23 10:52:16 +01:00
Outdated
Review
Copy Link

I thought to make it explicit what it is that the bool logic tests for, but I agree it's in the function name anyway

I thought to make it explicit what it is that the bool logic tests for, but I agree it's in the function name anyway
blender::BitSpan verts_of_unselected_faces,
const bool face_step)
ChrisLend marked this conversation as resolved Outdated
Hans Goudey commented 2023-03-18 02:23:42 +01:00
Outdated
Review
Copy Link

What do you think about removing the .test() and using BitRef's implicit bool conversion?

What do you think about removing the `.test()` and using `BitRef`'s implicit bool conversion?
Christoph Lendenfeld commented 2023-03-23 10:48:53 +01:00
Outdated
Review
Copy Link

yes good idea, done that

yes good idea, done that
{
for (const int edge_index : edge_indices) {
for (const int edge_index : poly_edges) {
const MEdge &edge = edges[edge_index];
if (face_step) {
if (verts_of_unselected_faces[edge.v1] || verts_of_unselected_faces[edge.v2]) {